NetBSD Problem Report #48882

From hauke@Espresso.Rhein-Neckar.DE  Sun Jun  8 19:33:40 2014
Return-Path: <hauke@Espresso.Rhein-Neckar.DE>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id CE819A5D59
	for <gnats-bugs@gnats.NetBSD.org>; Sun,  8 Jun 2014 19:33:40 +0000 (UTC)
Message-Id: <201406081924.s58JOBXk021376@pizza.causeuse.org>
Date: Sun, 8 Jun 2014 21:24:11 +0200 (CEST)
From: Hauke Fath <hauke@Espresso.Rhein-Neckar.DE>
Reply-To: Hauke Fath <hauke@Espresso.Rhein-Neckar.DE>
To: gnats-bugs@gnats.NetBSD.org
Cc: Hauke Fath <hauke@Espresso.Rhein-Neckar.DE>
Subject: print/cups build fails
X-Send-Pr-Version: 3.95

>Number:         48882
>Category:       pkg
>Synopsis:       print/cups build fails
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jun 08 19:35:00 +0000 2014
>Closed-Date:    Mon Jun 09 20:11:48 +0000 2014
>Last-Modified:  Mon Jun 09 20:11:48 +0000 2014
>Originator:     Hauke Fath
>Release:        NetBSD 6.1_STABLE
>Organization:
Falling Raindrops
>Environment:


System: NetBSD pizza.causeuse.org 6.1_STABLE NetBSD 6.1_STABLE (BLACKBOX-$Revision: 1.85 $) #0: Sat May 3 21:06:28 CEST 2014 hauke@pizza.causeuse.org:/var/obj/netbsd-builds/6/amd64/sys/arch/amd64/compile/BLACKBOX amd64
Architecture: x86_64
Machine: amd64
>Description:

	The build of print/cups fails because of a missing
	declaration.

>How-To-Repeat:

% make -dx
[...]
Compiling dirsvc.c...
Reaping winning child 0x7f7ff7b631b0 PID 13928 
Live child 0x7f7ff7b631b0 (dirsvc.o) PID 25792 
libtool: compile:  gcc -Wall -Wno-format-y2k -Wunused -fPIC -Os -g -fstack-protector -Wno-tautological-compare -I.. -D_CUPS_SOURCE -I/var/obj/pkgsrc/print/cups/work/.buildlink/include -O2 -pipe -Wall -Wno-error -DOPENSSL_DISABLE_OLD_DES_SUPPORT -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_THREAD_SAFE -D_REENTRANT -c dirsvc.c  -fPIC -DPIC -o .libs/dirsvc.o
dirsvc.c: In function 'dnssdErrorString':
dirsvc.c:835:10: error: 'kDNSServiceErr_Timeout' undeclared (first use in this function)
dirsvc.c:835:10: note: each undeclared identifier is reported only once for each function it appears in
At top level:
cc1: warning: unrecognized command line option "-Wno-tautological-compare"
Reaping losing child 0x7f7ff7b631b0 PID 25792 
../Makedefs:247: recipe for target 'dirsvc.o' failed
gmake[1]: *** [dirsvc.o] Error 1
Removing child 0x7f7ff7b631b0 PID 25792 from chain.
Reaping losing child 0x7f7ff7b5d200 PID 22199 
Makefile:31: recipe for target 'all' failed
gmake: *** [all] Error 1
Removing child 0x7f7ff7b5d200 PID 22199 from chain.
*** Error code 2

Stop.
make: stopped in /u1/pkgsrc/print/cups
+ exitcode=1
+ /usr/bin/env 'MAKECONF=/etc/mk.conf' 'PATH=/var/obj/pkgsrc/print/cups/work/.wrapper/bin:/var/obj/pkgsrc/print/cups/work/.buildlink/bin:/var/obj/pkgsrc/print/cups/work/.gcc/bin:/var/obj/pkgsrc/print/cups/work/.tools/bin:/usr/pkg/bin:/home/hauke/bin:/sbin:/usr/sbin:/usr/local/sbin:/usr/pkg/sbin:/bin:/usr/bin:/usr/local/bin:/usr/X11R7/bin:/usr/X11R6/bin:/usr/pkg/bin' 'USE_DESTDIR=yes' /usr/bin/make '_MAKE=/usr/bin/make' OPSYS=NetBSD 'OS_VERSION=6.1_STABLE' 'LOWER_OPSYS=netbsd' '_PKGSRCDIR=/u1/pkgsrc' 'PKGTOOLS_VERSION=20130902' '_CC=/usr/bin/gcc' '_PATH_ORIG=/home/hauke/bin:/sbin:/usr/sbin:/usr/local/sbin:/usr/pkg/sbin:/bin:/usr/bin:/usr/local/bin:/usr/X11R7/bin:/usr/X11R6/bin:/usr/pkg/bin' '_PKGSRC_BARRIER=yes' barrier-error-check
+ set -e
+ /bin/rm -f '/var/obj/pkgsrc/print/cups/work/.warning/*.tmp'
+ test -d '/var/obj/pkgsrc/print/cups/work/.warning'
+ cd '/var/obj/pkgsrc/print/cups/work/.warning'
+ test './*' '!=' './*'
+ exit 0
+ set -e
+ /bin/rm -f '/var/obj/pkgsrc/print/cups/work/.error/*.tmp'
+ test -d '/var/obj/pkgsrc/print/cups/work/.error'
+ cd '/var/obj/pkgsrc/print/cups/work/.error'
+ test './*' '!=' './*'
+ exit 0
+ exit 1
*** Error code 1

Stop.
make: stopped in /u1/pkgsrc/print/cups
% fgrep -R "kDNSServiceErr_Timeout" /var/obj/pkgsrc/print/cups/work/cups-1.7.3/*
scheduler/dirsvc.c:    case kDNSServiceErr_Timeout :
scheduler/dirsvc.c.orig:    case kDNSServiceErr_Timeout :
test/ippfind.c:    case kDNSServiceErr_Timeout :
%


>Fix:
	Restore the missing declaration from Apple's system headers, I
	guess?

>Release-Note:

>Audit-Trail:
From: Leonardo Taccari <iamleot@gmail.com>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/48882: print/cups build fails
Date: Sun, 8 Jun 2014 22:46:25 +0200

 --x+6KMIRAuhnl3hBn
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline

 On Sun, Jun 08, 2014 at 07:35:00PM +0000, Hauke Fath wrote:
 > [...]
 > Compiling dirsvc.c...
 > Reaping winning child 0x7f7ff7b631b0 PID 13928 
 > Live child 0x7f7ff7b631b0 (dirsvc.o) PID 25792 
 > libtool: compile:  gcc -Wall -Wno-format-y2k -Wunused -fPIC -Os -g -fstack-protector -Wno-tautological-compare -I.. -D_CUPS_SOURCE -I/var/obj/pkgsrc/print/cups/work/.buildlink/include -O2 -pipe -Wall -Wno-error -DOPENSSL_DISABLE_OLD_DES_SUPPORT -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_THREAD_SAFE -D_REENTRANT -c dirsvc.c  -fPIC -DPIC -o .libs/dirsvc.o
 > dirsvc.c: In function 'dnssdErrorString':
 > dirsvc.c:835:10: error: 'kDNSServiceErr_Timeout' undeclared (first use in this function)
 > dirsvc.c:835:10: note: each undeclared identifier is reported only once for each function it appears in
 > At top level:
 > cc1: warning: unrecognized command line option "-Wno-tautological-compare"
 > Reaping losing child 0x7f7ff7b631b0 PID 25792 
 > ../Makedefs:247: recipe for target 'dirsvc.o' failed
 > gmake[1]: *** [dirsvc.o] Error 1
 > Removing child 0x7f7ff7b631b0 PID 25792 from chain.
 > Reaping losing child 0x7f7ff7b5d200 PID 22199 
 > Makefile:31: recipe for target 'all' failed
 > gmake: *** [all] Error 1
 > Removing child 0x7f7ff7b5d200 PID 22199 from chain.
 > *** Error code 2
 Sorry, I forgot to add this patch... The attached patches should fix
 this problem.

 --x+6KMIRAuhnl3hBn
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename=cups-patches

 Index: distinfo
 ===================================================================
 RCS file: /cvsroot/pkgsrc/print/cups/distinfo,v
 retrieving revision 1.101
 diff -u -r1.101 distinfo
 --- distinfo	7 Jun 2014 11:54:54 -0000	1.101
 +++ distinfo	8 Jun 2014 20:41:31 -0000
 @@ -17,4 +17,4 @@
  SHA1 (patch-config.h.in) = c18c4afac00eb2c4e03e5886095152091fd217aa
  SHA1 (patch-ppdc_Makefile) = a45af3310e706dd6433f029c55cf62e492de3448
  SHA1 (patch-scheduler_auth.c) = 70f1eda9d6d81eabc080c037fac0c2d4bb229db4
 -SHA1 (patch-scheduler_dirsvc.c) = a4967c2c5841a8b51c24becd5a0f796daa3c5be2
 +SHA1 (patch-scheduler_dirsvc.c) = 79bcc46c2120a77465fc33b1684d60eeee689f8b
 Index: patches/patch-scheduler_dirsvc.c
 ===================================================================
 RCS file: /cvsroot/pkgsrc/print/cups/patches/patch-scheduler_dirsvc.c,v
 retrieving revision 1.3
 diff -u -r1.3 patch-scheduler_dirsvc.c
 --- patches/patch-scheduler_dirsvc.c	7 Jun 2014 11:54:54 -0000	1.3
 +++ patches/patch-scheduler_dirsvc.c	8 Jun 2014 20:41:32 -0000
 @@ -1,6 +1,10 @@
  $NetBSD: patch-scheduler_dirsvc.c,v 1.3 2014/06/07 11:54:54 wiz Exp $

 ---- scheduler/dirsvc.c.orig     2014-03-05 21:11:32.000000000 +0000
 +o Fix building without dnssd option.
 +o net/mDNSResponder-258.14 does not define kDNSServiceErr_Timeout, just threat
 + it like kDNSServiceErr_Unknown.
 +
 +--- scheduler/dirsvc.c.orig	2014-03-05 21:11:32.000000000 +0000
  +++ scheduler/dirsvc.c
  @@ -237,11 +237,13 @@ cupsdStartBrowsing(void)
     if (BrowseLocalProtocols & BROWSE_SMB)
 @@ -32,3 +36,13 @@
     if ((BrowseLocalProtocols & BROWSE_DNSSD) && DNSSDMaster)
       dnssdStop();
   #endif /* HAVE_DNSSD || HAVE_AVAHI */
 +@@ -829,9 +831,6 @@ dnssdErrorString(int error)		/* I - Erro
 + 
 +     case kDNSServiceErr_PollingMode :
 +         return ("Service polling mode error.");
 +-
 +-    case kDNSServiceErr_Timeout :
 +-        return ("Service timeout.");
 +   }
 + 
 + #  else /* HAVE_AVAHI */

 --x+6KMIRAuhnl3hBn--

State-Changed-From-To: open->feedback
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Mon, 09 Jun 2014 09:27:26 +0000
State-Changed-Why:
I've committed Leonardo's patch -- does it fix the problem for you?


From: "Thomas Klausner" <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/48882 CVS commit: pkgsrc/print/cups
Date: Mon, 9 Jun 2014 09:27:10 +0000

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Mon Jun  9 09:27:10 UTC 2014

 Modified Files:
 	pkgsrc/print/cups: distinfo
 	pkgsrc/print/cups/patches: patch-scheduler_dirsvc.c

 Log Message:
 Fix build on NetBSD-6. From Leonardo Taccari in PR 48882.


 To generate a diff of this commit:
 cvs rdiff -u -r1.101 -r1.102 pkgsrc/print/cups/distinfo
 cvs rdiff -u -r1.3 -r1.4 pkgsrc/print/cups/patches/patch-scheduler_dirsvc.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Hauke Fath <hauke@Espresso.Rhein-Neckar.DE>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@NetBSD.org, gnats-admin@NetBSD.org, wiz@NetBSD.org,
        Hauke Fath <hauke@Espresso.Rhein-Neckar.DE>
Subject: Re: pkg/48882 (print/cups build fails)
Date: Mon, 9 Jun 2014 21:52:28 +0200

 At 9:27 Uhr +0000 9.6.2014, wiz@NetBSD.org wrote:
 >I've committed Leonardo's patch -- does it fix the problem for you?

 Confírmed fixed, thanks.

 hauke


 --
 "It's never straight up and down"     (DEVO)


State-Changed-From-To: feedback->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Mon, 09 Jun 2014 20:11:48 +0000
State-Changed-Why:
Confirmed fixed, thanks.


>Unformatted:

Home	PR Database Search