NetBSD Problem Report #48950

From msaitoh@five.execsw.org  Wed Jun 25 16:29:45 2014
Return-Path: <msaitoh@five.execsw.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id BE143A650D
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 25 Jun 2014 16:29:45 +0000 (UTC)
Message-Id: <20140625162942.1C20917E213A@five.execsw.org>
Date: Thu, 26 Jun 2014 01:29:42 +0900 (JST)
From: msaitoh@execsw.org
Reply-To: msaitoh@execsw.org
To: gnats-bugs@NetBSD.org
Subject: Some ethernet intetfaces can't change flow control setting.
X-Send-Pr-Version: 3.95

>Number:         48950
>Category:       kern
>Synopsis:       Some ethernet interfaces can't change flow control setting.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jun 25 16:30:00 +0000 2014
>Closed-Date:    Sun Aug 02 10:41:17 +0000 2020
>Last-Modified:  Sun Aug 02 10:41:17 +0000 2020
>Originator:     SAITOH Masanobu
>Release:        all
>Organization:
>Environment:
Architecture: all
Machine: all
>Description:
	Some ethernet interfaces can't change the setting of flow control.

	e.g. bnx:

		# ifconfig bnx0 mediaopt flow
		ifconfig: SIOCSIFMEDIA: Invalid argument

>How-To-Repeat:
	See above.
>Fix:
	The reason is that the MIIF_DOPAUSE mask isn't passed to
	mii_attach(). Set MIIF_DOPAUSE mask in drivers which support
	the flow control.

>Release-Note:

>Audit-Trail:

From: "SAITOH Masanobu" <msaitoh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/48950 CVS commit: src/sys/arch/powerpc/ibm4xx/dev
Date: Thu, 26 Jun 2014 07:50:29 +0000

 Module Name:	src
 Committed By:	msaitoh
 Date:		Thu Jun 26 07:50:29 UTC 2014

 Modified Files:
 	src/sys/arch/powerpc/ibm4xx/dev: if_emac.c

 Log Message:
  Pass MIIF_DOPAUSE mask to mii_attach() in if_emac.c. emac(4) change a
 register from IFM_FLOW flag, so this change is required to control the
 setting via ifconfig. PR#48950. OK'd by matt@.


 To generate a diff of this commit:
 cvs rdiff -u -r1.41 -r1.42 src/sys/arch/powerpc/ibm4xx/dev/if_emac.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: jdolecek@NetBSD.org
State-Changed-When: Sun, 02 Aug 2020 10:41:17 +0000
State-Changed-Why:
bnx(4) specifically already supports this. If specific driver still needs
it, it's better to have specific PR just for that, so it's actionable.
Thanks for report.


>Unformatted:

Home	PR Database Search