NetBSD Problem Report #48998
From www@NetBSD.org Tue Jul 15 16:53:51 2014
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
by mollari.NetBSD.org (Postfix) with ESMTPS id 9A3BBA654A
for <gnats-bugs@gnats.NetBSD.org>; Tue, 15 Jul 2014 16:53:51 +0000 (UTC)
Message-Id: <20140715165350.413B8A655E@mollari.NetBSD.org>
Date: Tue, 15 Jul 2014 16:53:50 +0000 (UTC)
From: n54@gmx.com
Reply-To: n54@gmx.com
To: gnats-bugs@NetBSD.org
Subject: uhso(4) support for Globetrotter HSUPA Modem
X-Send-Pr-Version: www-1.0
>Number: 48998
>Category: kern
>Synopsis: uhso(4) support for Globetrotter HSUPA Modem
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: skrll
>State: closed
>Class: support
>Submitter-Id: net
>Arrival-Date: Tue Jul 15 16:55:00 +0000 2014
>Closed-Date: Sat Jul 11 09:53:33 +0000 2015
>Last-Modified: Sat Jul 11 09:53:33 +0000 2015
>Originator: Kamil Rytarowski
>Release: 6.1, current
>Organization:
>Environment:
NetBSD compaq 6.99.47 NetBSD 6.99.47 (NO_DRM) #0: Tue Jul 15 15:16:22 CEST 2014 kamil@compaq:/home/kamil/NetBSD-current/src/sys/arch/amd64/compile/NO_DRM amd64
>Description:
uhso(4) missing support for Globetrotter HSUPA Modem(0x8300), Option N.V.(0x0af0)
It's good idea to sync list of devices from hso.c (Linux) with uhso.c (NetBSD).
>How-To-Repeat:
Get stable or current, verify that there is a lack of support.
>Fix:
Apply the attached patch, rebuild the kernel and boot it.
('1111' - PIN, replace with your own)
Configuration for Orange (Polska).
$ cat ppp/chat.orange
ABORT "NO DIALTONE"
ABORT "NO ERROR"
ABORT "NO ANSWER"
ABORT "BUSY"
"" "AT"
OK "AT&F"
OK "AT+CPIN=1111"
OK "AT+CMEE=1"
OK 'AT+CGDCONT=1,"IP","internet"'
OK "ATDT*99***1#"
$ cat ppp/peers/orange
/dev/ttyHS0.08
115200
crtscts
connect '/usr/sbin/chat -v -f /etc/ppp/chat.orange'
noauth
local
ipcp-accept-local
defaultroute
novj
nobsdcomp
novjccomp
nopcomp
noaccomp
user "ppp"
# pppd call orange
And Voilą!
Patch against sources:
Index: src/share/man/man4/uhso.4
===================================================================
RCS file: /cvsroot/src/share/man/man4/uhso.4,v
retrieving revision 1.3
diff -u -r1.3 uhso.4
--- src/share/man/man4/uhso.4 26 Aug 2011 07:56:00 -0000 1.3
+++ src/share/man/man4/uhso.4 15 Jul 2014 16:42:00 -0000
@@ -42,6 +42,7 @@
.It GlobeTrotter Express 40x
.It GlobeTrotter Express HSUPA
.It GlobeTrotter HSUPA
+.It GlobeTrotter HSUPA Modem
.It GlobeTrotter Max HSDPA
.It GlobeTrotter Module 382
.It GlobeTrotter iCON 225
Index: src/sys/dev/usb/uhso.c
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/uhso.c,v
retrieving revision 1.14
diff -u -r1.14 uhso.c
--- src/sys/dev/usb/uhso.c 5 Jun 2014 23:48:16 -0000 1.14
+++ src/sys/dev/usb/uhso.c 15 Jul 2014 16:42:01 -0000
@@ -243,6 +243,7 @@
{ USB_VENDOR_OPTIONNV, USB_PRODUCT_OPTIONNV_ICON401, UHSOTYPE_CONFIG },
{ USB_VENDOR_OPTIONNV, USB_PRODUCT_OPTIONNV_GTM382, UHSOTYPE_CONFIG },
{ USB_VENDOR_OPTIONNV, USB_PRODUCT_OPTIONNV_GE40X4, UHSOTYPE_CONFIG },
+ { USB_VENDOR_OPTIONNV, USB_PRODUCT_OPTIONNV_GTHSUPAM, UHSOTYPE_CONFIG },
{ USB_VENDOR_OPTIONNV, USB_PRODUCT_OPTIONNV_ICONEDGE, UHSOTYPE_DEFAULT },
{ USB_VENDOR_OPTIONNV, USB_PRODUCT_OPTIONNV_MODHSXPA, UHSOTYPE_ICON321 },
{ USB_VENDOR_OPTIONNV, USB_PRODUCT_OPTIONNV_ICON321, UHSOTYPE_ICON321 },
Index: src/sys/dev/usb/usbdevs
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/usbdevs,v
retrieving revision 1.674
diff -u -r1.674 usbdevs
--- src/sys/dev/usb/usbdevs 14 Jul 2014 12:02:59 -0000 1.674
+++ src/sys/dev/usb/usbdevs 15 Jul 2014 16:42:02 -0000
@@ -2402,6 +2402,7 @@
product OPTIONNV ICON401 0x7401 iCON 401
product OPTIONNV GTM382 0x7501 GTM 382
product OPTIONNV GE40X4 0x7601 GE40x
+product OPTIONNV GTHSUPAM 0x8300 Globetrotter HSUPA Modem
product OPTIONNV ICONEDGE 0xc031 iCON EDGE
product OPTIONNV MODHSXPA 0xd013 Module HSxPA
product OPTIONNV ICON321 0xd031 iCON 321
Index: src/sys/dev/usb/usbdevs.h
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/usbdevs.h,v
retrieving revision 1.666
diff -u -r1.666 usbdevs.h
--- src/sys/dev/usb/usbdevs.h 14 Jul 2014 12:03:42 -0000 1.666
+++ src/sys/dev/usb/usbdevs.h 15 Jul 2014 16:42:02 -0000
@@ -1,10 +1,10 @@
-/* $NetBSD: usbdevs.h,v 1.666 2014/07/14 12:03:42 ryoon Exp $ */
+/* $NetBSD$ */
/*
* THIS FILE IS AUTOMATICALLY GENERATED. DO NOT EDIT.
*
* generated from:
- * NetBSD: usbdevs,v 1.673 2014/06/11 07:05:03 njoly Exp
+ * NetBSD: usbdevs,v 1.674 2014/07/14 12:02:59 ryoon Exp
*/
/*
@@ -2409,6 +2409,7 @@
#define USB_PRODUCT_OPTIONNV_ICON401 0x7401 /* iCON 401 */
#define USB_PRODUCT_OPTIONNV_GTM382 0x7501 /* GTM 382 */
#define USB_PRODUCT_OPTIONNV_GE40X4 0x7601 /* GE40x */
+#define USB_PRODUCT_OPTIONNV_GTHSUPAM 0x8300 /* Globetrotter HSUPA Modem */
#define USB_PRODUCT_OPTIONNV_ICONEDGE 0xc031 /* iCON EDGE */
#define USB_PRODUCT_OPTIONNV_MODHSXPA 0xd013 /* Module HSxPA */
#define USB_PRODUCT_OPTIONNV_ICON321 0xd031 /* iCON 321 */
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: kern-bug-people->skrll
Responsible-Changed-By: skrll@NetBSD.org
Responsible-Changed-When: Sat, 19 Jul 2014 07:24:25 +0000
Responsible-Changed-Why:
Take
From: "Nick Hudson" <skrll@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/48998 CVS commit: src/sys/dev/usb
Date: Sat, 19 Jul 2014 14:17:49 +0000
Module Name: src
Committed By: skrll
Date: Sat Jul 19 14:17:49 UTC 2014
Modified Files:
src/sys/dev/usb: usbdevs
Log Message:
PR/48998 (uhso(4) support for Globetrotter HSUPA Modem)
Add the product id.
To generate a diff of this commit:
cvs rdiff -u -r1.674 -r1.675 src/sys/dev/usb/usbdevs
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->feedback
State-Changed-By: skrll@NetBSD.org
State-Changed-When: Sat, 19 Jul 2014 14:24:07 +0000
State-Changed-Why:
I've commited the suggested changes. I saw the locking email and suggest a different PR.
OK to close?
From: "Nick Hudson" <skrll@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/48998 CVS commit: src
Date: Sat, 19 Jul 2014 14:20:46 +0000
Module Name: src
Committed By: skrll
Date: Sat Jul 19 14:20:46 UTC 2014
Modified Files:
src/share/man/man4: uhso.4
src/sys/dev/usb: uhso.c
Log Message:
PR/48998: uhso(4) support for Globetrotter HSUPA Modem
To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/share/man/man4/uhso.4
cvs rdiff -u -r1.14 -r1.15 src/sys/dev/usb/uhso.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "Kamil Rytarowski" <n54@gmx.com>
To: gnats-bugs@netbsd.org, skrll@netbsd.org
Cc:
Subject: Re: kern/48998 (uhso(4) support for Globetrotter HSUPA Modem)
Date: Sat, 19 Jul 2014 19:54:42 +0200
Please add more devices from:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/net/usb/hso.c?id=refs/tags/v3.16-rc5
lines 426-481
This will make life easier for other users.
Thank you!
From: "Kamil Rytarowski" <n54@gmx.com>
To: gnats-bugs@gnats.netbsd.org
Cc:
Subject: Re: kern/48998
Date: Sun, 27 Jul 2014 12:37:17 +0200
Please add more devices from:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/net/usb/hso.c?id=refs/tags/v3.16-rc5
lines 426-481
This will make life easier for other users.
Thank you!
State-Changed-From-To: feedback->open
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 27 Dec 2014 23:49:44 +0000
State-Changed-Why:
fixed, but submitter wants more device ids added
State-Changed-From-To: open->closed
State-Changed-By: kamil@NetBSD.org
State-Changed-When: Sat, 11 Jul 2015 11:53:33 +0200
State-Changed-Why:
Patch has been applied. The request for more IDs is withdrawn.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.
Home