NetBSD Problem Report #49004

From www@NetBSD.org  Thu Jul 17 05:37:12 2014
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id F0DBEA5832
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 17 Jul 2014 05:37:11 +0000 (UTC)
Message-Id: <20140717053711.0DB72A655C@mollari.NetBSD.org>
Date: Thu, 17 Jul 2014 05:37:11 +0000 (UTC)
From: yaneurabeya@gmail.com
Reply-To: yaneurabeya@gmail.com
To: gnats-bugs@NetBSD.org
Subject: [patch] t_sigqueue: mark unused variables in functions __unused and explicitly test with getpid()
X-Send-Pr-Version: www-1.0

>Number:         49004
>Category:       bin
>Synopsis:       [patch] t_sigqueue: mark unused variables in functions __unused and explicitly test with getpid()
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jul 17 05:40:00 +0000 2014
>Closed-Date:    Fri Aug 25 23:09:26 +0000 2017
>Last-Modified:  Fri Aug 25 23:09:26 +0000 2017
>Originator:     Garrett Cooper
>Release:        n/a
>Organization:
EMC / Isilon Storage Division
>Environment:
n/a
>Description:
FreeBSD fails the testcase with pid == 0, but passes with getpid(). POSIX doesn't state how == 0 should be treated, so this might be passing as a side-effect of how sigqueue is implemented on NetBSD.

Several unused arguments in handler were also marked __unused so clang didn't complain about them with -Wunused.
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: Garrett Cooper <yaneurabeya@gmail.com>
To: "gnats-bugs@NetBSD.org" <gnats-bugs@netbsd.org>
Cc: 
Subject: Re: bin/49004: [patch] t_sigqueue: mark unused variables in functions
 __unused and explicitly test with getpid()
Date: Wed, 16 Jul 2014 22:44:02 -0700

 --bcaec5186d70d371a104fe5d20e0
 Content-Type: text/plain; charset=UTF-8

 On Wed, Jul 16, 2014 at 10:40 PM,  <gnats-admin@netbsd.org> wrote:
 > Thank you very much for your problem report.
 > It has the internal identification `bin/49004'.
 > The individual assigned to look at your
 > report is: bin-bug-people.
 >
 >>Category:       bin
 >>Responsible:    bin-bug-people
 >>Synopsis:       [patch] t_sigqueue: mark unused variables in functions __unused and explicitly test with getpid()
 >>Arrival-Date:   Thu Jul 17 05:40:00 +0000 2014

 Patch attached -- thanks :)!
 -Garrett

 --bcaec5186d70d371a104fe5d20e0
 Content-Type: application/octet-stream; 
 	name="t_sigqueue-mark-unused-arguments-with-__unused-and-explicitly-use-getpid-with-sigqueue.patch"
 Content-Disposition: attachment; 
 	filename="t_sigqueue-mark-unused-arguments-with-__unused-and-explicitly-use-getpid-with-sigqueue.patch"
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_hxpnk8dl0

 SW5kZXg6IHRlc3RzL2xpYi9saWJjL3N5cy90X3NpZ3F1ZXVlLmMKPT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmls
 ZTogL2N2c3Jvb3Qvc3JjL3Rlc3RzL2xpYi9saWJjL3N5cy90X3NpZ3F1ZXVlLmMsdgpyZXRyaWV2
 aW5nIHJldmlzaW9uIDEuNApkaWZmIC11IC1yMS40IHRfc2lncXVldWUuYwotLS0gdGVzdHMvbGli
 L2xpYmMvc3lzL3Rfc2lncXVldWUuYwk3IEp1bCAyMDExIDE2OjMxOjExIC0wMDAwCTEuNAorKysg
 dGVzdHMvbGliL2xpYmMvc3lzL3Rfc2lncXVldWUuYwkxNyBKdWwgMjAxNCAwNDo1MTo1NiAtMDAw
 MApAQCAtNDYsNyArNDYsNyBAQAogc3RhdGljIGludCB2YWx1ZTsKIAogc3RhdGljIHZvaWQKLWhh
 bmRsZXIoaW50IHNpZ25vLCBzaWdpbmZvX3QgKmluZm8sIHZvaWQgKmRhdGEpCitoYW5kbGVyKGlu
 dCBzaWdubyBfX3VudXNlZCwgc2lnaW5mb190ICppbmZvLCB2b2lkICpkYXRhIF9fdW51c2VkKQog
 ewogCXZhbHVlID0gaW5mby0+c2lfdmFsdWUuc2l2YWxfaW50OwogCWtpbGwoMCwgU0lHSU5GTyk7
 CkBAIC03Miw3ICs3Miw3IEBACiAKIAlzdi5zaXZhbF9pbnQgPSBWQUxVRTsKIAotCWlmIChzaWdx
 dWV1ZSgwLCBTSUdVU1IxLCBzdikgIT0gMCkKKwlpZiAoc2lncXVldWUoZ2V0cGlkKCksIFNJR1VT
 UjEsIHN2KSAhPSAwKQogCQlhdGZfdGNfZmFpbCgic2lncXVldWUgZmFpbGVkIik7CiAKIAlzY2hl
 ZF95aWVsZCgpOwo=
 --bcaec5186d70d371a104fe5d20e0--

State-Changed-From-To: open->closed
State-Changed-By: ginsbach@NetBSD.org
State-Changed-When: Fri, 25 Aug 2017 23:09:26 +0000
State-Changed-Why:
Fixed by christos via duplicate 51847. Thanks!


>Unformatted:

Home	PR Database Search