NetBSD Problem Report #49012

From www@NetBSD.org  Thu Jul 17 21:13:57 2014
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 9427AA6541
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 17 Jul 2014 21:13:57 +0000 (UTC)
Message-Id: <20140717211356.82BE6A655B@mollari.NetBSD.org>
Date: Thu, 17 Jul 2014 21:13:56 +0000 (UTC)
From: yaneurabeya@gmail.com
Reply-To: yaneurabeya@gmail.com
To: gnats-bugs@NetBSD.org
Subject: [patch] t_dup: missing stdbool.h #include for false/true per POSIX and has a redundant static declaration for check_mode
X-Send-Pr-Version: www-1.0

>Number:         49012
>Category:       bin
>Synopsis:       [patch] t_dup: missing stdbool.h #include for false/true per POSIX and has a redundant static declaration for check_mode
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jul 17 21:15:00 +0000 2014
>Closed-Date:    Thu Aug 10 01:57:28 +0000 2017
>Last-Modified:  Thu Aug 10 02:01:31 +0000 2017
>Originator:     Garrett Cooper
>Release:        n/a
>Organization:
EMC / Isilon Storage Division
>Environment:
n/a
>Description:
t_dup fails to compile on FreeBSD with clang for the following reasons:
- It doesn't #include stdbool.h, but references false/true (stdbool.h is required per POSIX to access these definitions).
- It has a duplicate static declaration for the check_mode function, which isn't required.
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: Garrett Cooper <yaneurabeya@gmail.com>
To: "gnats-bugs@NetBSD.org" <gnats-bugs@netbsd.org>
Cc: 
Subject: Re: bin/49012: [patch] t_dup: missing stdbool.h #include for
 false/true per POSIX and has a redundant static declaration for check_mode
Date: Thu, 17 Jul 2014 14:16:08 -0700

 --047d7bdc07e23a99f204fe6a2617
 Content-Type: text/plain; charset=UTF-8

 On Thu, Jul 17, 2014 at 2:15 PM,  <gnats-admin@netbsd.org> wrote:
 > Thank you very much for your problem report.
 > It has the internal identification `bin/49012'.
 > The individual assigned to look at your
 > report is: bin-bug-people.
 >
 >>Category:       bin
 >>Responsible:    bin-bug-people
 >>Synopsis:       [patch] t_dup: missing stdbool.h #include for false/true per POSIX and has a redundant static declaration for check_mode
 >>Arrival-Date:   Thu Jul 17 21:15:00 +0000 2014

 Here's the patch -- thanks :)!
 -Garrett

 --047d7bdc07e23a99f204fe6a2617
 Content-Type: application/octet-stream; 
 	name="t_dup-add-stdbool-and-remove-redundant-static-declaration-for-check_mode.patch"
 Content-Disposition: attachment; 
 	filename="t_dup-add-stdbool-and-remove-redundant-static-declaration-for-check_mode.patch"
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_hxqkv39b0

 SW5kZXg6IHRlc3RzL2xpYi9saWJjL3N5cy90X2R1cC5jCj09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9j
 dnNyb290L3NyYy90ZXN0cy9saWIvbGliYy9zeXMvdF9kdXAuYyx2CnJldHJpZXZpbmcgcmV2aXNp
 b24gMS44CmRpZmYgLXUgLXIxLjggdF9kdXAuYwotLS0gdGVzdHMvbGliL2xpYmMvc3lzL3RfZHVw
 LmMJMTggTWFyIDIwMTIgMDc6MDA6NTEgLTAwMDAJMS44CisrKyB0ZXN0cy9saWIvbGliYy9zeXMv
 dF9kdXAuYwkxNyBKdWwgMjAxNCAyMToxMToyOCAtMDAwMApAQCAtMzksNiArMzksNyBAQAogI2lu
 Y2x1ZGUgPGVycm5vLmg+CiAjaW5jbHVkZSA8ZmNudGwuaD4KICNpbmNsdWRlIDxsaW1pdHMuaD4K
 KyNpbmNsdWRlIDxzdGRib29sLmg+CiAjaW5jbHVkZSA8c3RkaW8uaD4KICNpbmNsdWRlIDxzdGRs
 aWIuaD4KICNpbmNsdWRlIDxzdHJpbmcuaD4KQEAgLTQ2LDcgKzQ3LDYgQEAKICNpbmNsdWRlIDxz
 eXNleGl0cy5oPgogCiBzdGF0aWMgY2hhcglwYXRoW10gPSAiZHVwIjsKLXN0YXRpYyB2b2lkCWNo
 ZWNrX21vZGUoYm9vbCwgYm9vbCwgYm9vbCk7CiAKIHN0YXRpYyB2b2lkCiBjaGVja19tb2RlKGJv
 b2wgX2R1cCwgYm9vbCBfZHVwMiwgYm9vbCBfZHVwMykK
 --047d7bdc07e23a99f204fe6a2617--

State-Changed-From-To: open->closed
State-Changed-By: ginsbach@NetBSD.org
State-Changed-When: Thu, 10 Aug 2017 01:57:28 +0000
State-Changed-Why:
christos committed change for PR/51851 fixing this same issue.


>Unformatted:

Home	PR Database Search