NetBSD Problem Report #49187

From gson@gson.org  Tue Sep  9 10:40:03 2014
Return-Path: <gson@gson.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 86DBDCCDCA
	for <gnats-bugs@gnats.NetBSD.org>; Tue,  9 Sep 2014 10:40:03 +0000 (UTC)
Message-Id: <20140909103954.EDD8275E3E@guava.gson.org>
Date: Tue,  9 Sep 2014 13:39:54 +0300 (EEST)
From: gson@gson.org (Andreas Gustafsson)
Reply-To: gson@gson.org (Andreas Gustafsson)
To: gnats-bugs@gnats.NetBSD.org
Subject: ATF detect_unused_tests tests failing
X-Send-Pr-Version: 3.95

>Number:         49187
>Category:       toolchain
>Synopsis:       ATF detect_unused_tests tests failing
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    toolchain-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Sep 09 10:45:00 +0000 2014
>Last-Modified:  Fri Jan 30 07:55:00 +0000 2015
>Originator:     Andreas Gustafsson
>Release:        NetBSD-current, source date > 2014-03-11 23:22:36
>Organization:

>Environment:
System: NetBSD
Architecture: x86_64
Machine: amd64
>Description:

The following tests have been failing on the TNF testbed on each
of amd64, i386, and sparc ever since they were switched to gcc 4.8:

  atf/atf-c/macros_test/detect_unused_tests
  atf/atf-c++/macros_test/detect_unused_tests

In a discussion on current-users on March 27, Martin Husemann noted:

> The detect_unused_tests are generic gcc 4.8.x bugs, there are upstream
> tickets for it (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57201).

I'm filing this as a PR so that the tests can be marked as expected
failures.

>How-To-Repeat:

Run the ATF tests.

>Fix:

>Audit-Trail:
From: Andreas Gustafsson <gson@gson.org>
To: jmmv@NetBSD.org
Cc: gnats-bugs@NetBSD.org
Subject: Re: toolchain/49187: ATF detect_unused_tests tests failing
Date: Thu, 11 Sep 2014 14:41:56 +0300

 Hi Julio,

 I would like to mark the failing detect_unused_tests test cases as
 "expected failures" but it's not clear to me how to to do that since
 the source for the tests in case is in src/external/bsd/atf rather
 than src/tests.

 Does this need to go in the ATF distribution itself, or is there some
 other way to do it?
 -- 
 Andreas Gustafsson, gson@gson.org

From: Julio Merino <jmmv@netbsd.org>
To: Andreas Gustafsson <gson@gson.org>
Cc: gnats-bugs@netbsd.org
Subject: Re: toolchain/49187: ATF detect_unused_tests tests failing
Date: Thu, 11 Sep 2014 08:10:44 -0400

 On Thu, Sep 11, 2014 at 7:41 AM, Andreas Gustafsson <gson@gson.org> wrote:
 > Hi Julio,
 >
 > I would like to mark the failing detect_unused_tests test cases as
 > "expected failures"

 How is it failing?  Is the failure consistent?  In all platforms?
 Does it happen with gcc and clang?

 I remember fixing some failures in this specific test months ago, and
 now see that the fixes went into atf 0.20 (which is in the tree).  In
 fact, the test tries first to see if the compiler "works" by running a
 simple "pre-check" and then executes the real test.  I recall some
 compiler bug (can't remember if gcc or clang) that prevented this from
 working properly though so this test is actually reporting a real
 issue somewhere.

 > but it's not clear to me how to to do that since
 > the source for the tests in case is in src/external/bsd/atf rather
 > than src/tests.

 Ideally, just like with any other software in src/external/: you can
 patch it, but you should feed back any fixes upstream. And if the
 fixes/changes are not clear, try to discuss them with upstream first.
 Which is what you are doing here, so cool!

 > Does this need to go in the ATF distribution itself, or is there some
 > other way to do it?

 Well, if it really turns out to be a compiler problem... patching the
 test in NetBSD directly is probably reasonable.

From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@NetBSD.org
Cc: toolchain-manager@netbsd.org, gnats-admin@netbsd.org,
	netbsd-bugs@netbsd.org, Andreas Gustafsson <gson@gson.org>
Subject: Re: toolchain/49187: ATF detect_unused_tests tests failing
Date: Thu, 11 Sep 2014 14:16:47 +0200

 On Thu, Sep 11, 2014 at 12:15:01PM +0000, Julio Merino wrote:
 >  Well, if it really turns out to be a compiler problem... patching the
 >  test in NetBSD directly is probably reasonable.

 It is a gcc 4.8.3 compiler problem, it fails on all architectures we
 tried so far.

 Martin

From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: toolchain/49187: ATF detect_unused_tests tests failing
Date: Thu, 11 Sep 2014 14:53:50 +0200

 On Thu, Sep 11, 2014 at 12:20:00PM +0000, Martin Husemann wrote:
 > The following reply was made to PR toolchain/49187; it has been noted by GNATS.
 > 
 > From: Martin Husemann <martin@duskware.de>
 > To: gnats-bugs@NetBSD.org
 > Cc: toolchain-manager@netbsd.org, gnats-admin@netbsd.org,
 > 	netbsd-bugs@netbsd.org, Andreas Gustafsson <gson@gson.org>
 > Subject: Re: toolchain/49187: ATF detect_unused_tests tests failing
 > Date: Thu, 11 Sep 2014 14:16:47 +0200
 > 
 >  On Thu, Sep 11, 2014 at 12:15:01PM +0000, Julio Merino wrote:
 >  >  Well, if it really turns out to be a compiler problem... patching the
 >  >  test in NetBSD directly is probably reasonable.
 >  
 >  It is a gcc 4.8.3 compiler problem, it fails on all architectures we
 >  tried so far.

 Well, I disagree with the GCC PR in so far as clang has the same issue.

 Joerg

From: "Andreas Gustafsson" <gson@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49187 CVS commit: src/external/bsd/atf/dist
Date: Thu, 22 Jan 2015 12:33:36 +0000

 Module Name:	src
 Committed By:	gson
 Date:		Thu Jan 22 12:33:36 UTC 2015

 Modified Files:
 	src/external/bsd/atf/dist/atf-c: macros_test.c
 	src/external/bsd/atf/dist/atf-c++: macros_test.cpp

 Log Message:
 Mark atf/atf-c/macros_test/detect_unused_tests and
 atf/atf-c++/macros_test/detect_unused_tests as expected failures
 when using versions of GCC where they are known to fail, with a
 reference to PR toolchain/49187.


 To generate a diff of this commit:
 cvs rdiff -u -r1.4 -r1.5 src/external/bsd/atf/dist/atf-c/macros_test.c
 cvs rdiff -u -r1.1.1.8 -r1.2 \
     src/external/bsd/atf/dist/atf-c++/macros_test.cpp

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49187 CVS commit: [netbsd-7] src/external/bsd/atf/dist
Date: Fri, 30 Jan 2015 07:53:15 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Fri Jan 30 07:53:15 UTC 2015

 Modified Files:
 	src/external/bsd/atf/dist/atf-c [netbsd-7]: macros_test.c
 	src/external/bsd/atf/dist/atf-c++ [netbsd-7]: macros_test.cpp

 Log Message:
 Pull up following revision(s) (requested by gson in ticket #471):
 	external/bsd/atf/dist/atf-c++/macros_test.cpp: revision 1.2
 	external/bsd/atf/dist/atf-c/macros_test.c: revision 1.5
 Mark atf/atf-c/macros_test/detect_unused_tests and
 atf/atf-c++/macros_test/detect_unused_tests as expected failures
 when using versions of GCC where they are known to fail, with a
 reference to PR toolchain/49187.


 To generate a diff of this commit:
 cvs rdiff -u -r1.4 -r1.4.4.1 src/external/bsd/atf/dist/atf-c/macros_test.c
 cvs rdiff -u -r1.1.1.8 -r1.1.1.8.4.1 \
     src/external/bsd/atf/dist/atf-c++/macros_test.cpp

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Home	PR Database Search