NetBSD Problem Report #49233
From www@NetBSD.org Tue Sep 23 23:48:04 2014
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
by mollari.NetBSD.org (Postfix) with ESMTPS id 40E55A6555
for <gnats-bugs@gnats.NetBSD.org>; Tue, 23 Sep 2014 23:48:04 +0000 (UTC)
Message-Id: <20140923234802.7ADF8A6568@mollari.NetBSD.org>
Date: Tue, 23 Sep 2014 23:48:02 +0000 (UTC)
From: pr@i3enedek.neomailbox.net
Reply-To: pr@i3enedek.neomailbox.net
To: gnats-bugs@NetBSD.org
Subject: add huwaei E353 to usbdevs
X-Send-Pr-Version: www-1.0
>Number: 49233
>Category: misc
>Synopsis: add huwaei E353 to usbdevs
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: misc-bug-people
>State: closed
>Class: change-request
>Submitter-Id: net
>Arrival-Date: Tue Sep 23 23:50:00 +0000 2014
>Closed-Date: Wed Oct 15 12:44:15 +0000 2014
>Last-Modified: Wed Oct 15 12:44:15 +0000 2014
>Originator: Ben Gergely
>Release: current
>Organization:
>Environment:
NetBSD 7.99.1
>Description:
adding Huwaei E353 3G dongle to usbdevs
>How-To-Repeat:
>Fix:
? E353.patch
Index: u3g.c
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/u3g.c,v
retrieving revision 1.30
diff -u -r1.30 u3g.c
--- u3g.c 2 Sep 2013 07:39:03 -0000 1.30
+++ u3g.c 23 Sep 2014 23:31:54 -0000
@@ -192,6 +192,7 @@
{ USB_VENDOR_HUAWEI, USB_PRODUCT_HUAWEI_K3765 },
{ USB_VENDOR_HUAWEI, USB_PRODUCT_HUAWEI_MOBILE },
{ USB_VENDOR_HUAWEI, USB_PRODUCT_HUAWEI_E171 },
+ { USB_VENDOR_HUAWEI, USB_PRODUCT_HUAWEI_E353 },
/* OEM: Merlin */
{ USB_VENDOR_MERLIN, USB_PRODUCT_MERLIN_V620 },
/* OEM: Novatel */
@@ -464,7 +465,6 @@
return send_bulkmsg(dev, cmd, sizeof(cmd));
}
-
static int
u3g_huawei_e171_reinit(usbd_device_handle dev)
{
@@ -485,6 +485,28 @@
}
static int
+u3g_huawei_e353_reinit(usbd_device_handle dev)
+{
+ unsigned char cmd[31];
+
+ /* magic string adapted from some webpage */
+ memset(cmd, 0, sizeof(cmd));
+ cmd[0] = 0x55;
+ cmd[1] = 0x53;
+ cmd[2] = 0x42;
+ cmd[3] = 0x43;
+ cmd[4] = 0x7f;
+ cmd[9] = 0x02;
+ cmd[12] = 0x80;
+ cmd[14] = 0x0a;
+ cmd[15] = 0x11;
+ cmd[16] = 0x06;
+ cmd[17] = 0x20;
+ cmd[23] = 0x01;
+ return send_bulkmsg(dev, cmd, sizeof(cmd));
+}
+
+static int
u3g_sierra_reinit(usbd_device_handle dev)
{
/* Some Sierra devices presents themselves as a umass device with
@@ -545,6 +567,9 @@
case USB_PRODUCT_HUAWEI_E171INIT:
return u3g_huawei_e171_reinit(uaa->device);
break;
+ case USB_PRODUCT_HUAWEI_E353INIT:
+ return u3g_huawei_e353_reinit(uaa->device);
+ break;
default:
return u3g_huawei_reinit(uaa->device);
break;
Index: usbdevs
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/usbdevs,v
retrieving revision 1.680
diff -u -r1.680 usbdevs
--- usbdevs 4 Aug 2014 19:59:37 -0000 1.680
+++ usbdevs 23 Sep 2014 23:32:08 -0000
@@ -1733,6 +1733,7 @@
product HUAWEI E1820 0x14ac Huawei E1820
product HUAWEI E171INIT 0x14fe Huawei E171 USB CD
product HUAWEI E171 0x1506 Huawei E171
+product HUAWEI E353 0x1f01 Huawei E353
product HUAWEI K3765INIT 0x1520 Huawei K3765 USB CD
/* Huawei-3Com products */
Index: usbdevs.h
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/usbdevs.h,v
retrieving revision 1.672
diff -u -r1.672 usbdevs.h
--- usbdevs.h 4 Aug 2014 20:01:12 -0000 1.672
+++ usbdevs.h 23 Sep 2014 23:32:29 -0000
@@ -1740,6 +1740,8 @@
#define USB_PRODUCT_HUAWEI_E1820 0x14ac /* Huawei E1820 */
#define USB_PRODUCT_HUAWEI_E171INIT 0x14fe /* Huawei E171 USB CD */
#define USB_PRODUCT_HUAWEI_E171 0x1506 /* Huawei E171 */
+#define USB_PRODUCT_HUAWEI_E353INIT 0x1f01 /* Huawei E353 USB CD */
+#define USB_PRODUCT_HUAWEI_E353 0x1507 /* Huawei E353 */
#define USB_PRODUCT_HUAWEI_K3765INIT 0x1520 /* Huawei K3765
USB CD */
/* Huawei-3Com products */
Index: usbdevs_data.h
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/usbdevs_data.h,v
retrieving revision 1.673
diff -u -r1.673 usbdevs_data.h
--- usbdevs_data.h 4 Aug 2014 20:01:12 -0000 1.673
+++ usbdevs_data.h 23 Sep 2014 23:32:40 -0000
@@ -5459,6 +5459,10 @@
"Huawei E171",
},
{
+ USB_VENDOR_HUAWEI, USB_PRODUCT_HUAWEI_E353,
+ "Huawei E353",
+ },
+ {
USB_VENDOR_HUAWEI, USB_PRODUCT_HUAWEI_K3765INIT,
"Huawei K3765 USB CD",
},
@@ -10183,4 +10187,4 @@
"Prestige",
},
};
-const int usb_nproducts = 2005;
+const int usb_nproducts = 2006;
>Release-Note:
>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/49233 CVS commit: src/sys/dev/usb
Date: Tue, 23 Sep 2014 20:17:13 -0400
Module Name: src
Committed By: christos
Date: Wed Sep 24 00:17:13 UTC 2014
Modified Files:
src/sys/dev/usb: u3g.c usbdevs
Log Message:
PR/49233: Ben Gergely: Add huawei e353 to u3g
(factor out some common code in the process)
To generate a diff of this commit:
cvs rdiff -u -r1.30 -r1.31 src/sys/dev/usb/u3g.c
cvs rdiff -u -r1.681 -r1.682 src/sys/dev/usb/usbdevs
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Benedek Gergely <i3enedek@neomailbox.net>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: PR/49233 CVS commit: src/sys/dev/usb
Date: Fri, 10 Oct 2014 15:05:04 +0000
--3gk1bTGVZuaU9V5/
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Checked in current; works as expected.
--3gk1bTGVZuaU9V5/
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iEYEARECAAYFAlQ39aAACgkQEhpIefUvZHNf8ACgmNIVuAeeZv9Un1rSaXL4T9kz
HZkAn3bRdoN1A1uhApHaQuv+wLRu4l7r
=Mmhb
-----END PGP SIGNATURE-----
--3gk1bTGVZuaU9V5/--
From: David Holland <dholland-bugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: PR/49233 CVS commit: src/sys/dev/usb
Date: Tue, 14 Oct 2014 05:58:44 +0000
On Fri, Oct 10, 2014 at 04:25:00PM +0000, Benedek Gergely wrote:
> Checked in current; works as expected.
Thanks.
For the moment it's waiting for Christos (or someone) to file the
pullup request for netbsd-7...
--
David A. Holland
dholland@netbsd.org
From: christos@zoulas.com (Christos Zoulas)
To: gnats-bugs@NetBSD.org, misc-bug-people@netbsd.org,
gnats-admin@netbsd.org, netbsd-bugs@netbsd.org,
pr@i3enedek.neomailbox.net
Cc:
Subject: Re: PR/49233 CVS commit: src/sys/dev/usb
Date: Tue, 14 Oct 2014 08:34:31 -0400
On Oct 14, 6:00am, dholland-bugs@netbsd.org (David Holland) wrote:
-- Subject: Re: PR/49233 CVS commit: src/sys/dev/usb
| The following reply was made to PR misc/49233; it has been noted by GNATS.
|
| From: David Holland <dholland-bugs@netbsd.org>
| To: gnats-bugs@NetBSD.org
| Cc:
| Subject: Re: PR/49233 CVS commit: src/sys/dev/usb
| Date: Tue, 14 Oct 2014 05:58:44 +0000
|
| On Fri, Oct 10, 2014 at 04:25:00PM +0000, Benedek Gergely wrote:
| > Checked in current; works as expected.
|
| Thanks.
|
| For the moment it's waiting for Christos (or someone) to file the
| pullup request for netbsd-7...
I filed it
christos
From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/49233 CVS commit: [netbsd-7] src/sys/dev/usb
Date: Wed, 15 Oct 2014 08:43:08 +0000
Module Name: src
Committed By: martin
Date: Wed Oct 15 08:43:08 UTC 2014
Modified Files:
src/sys/dev/usb [netbsd-7]: u3g.c usbdevs
Log Message:
Pull up following revision(s) (requested by christos in ticket #142):
sys/dev/usb/u3g.c: revision 1.31
sys/dev/usb/usbdevs: revision 1.681
sys/dev/usb/usbdevs: revision 1.682
PR/49233: Ben Gergely: Add huawei e353 to u3g
(factor out some common code in the process)
To generate a diff of this commit:
cvs rdiff -u -r1.30 -r1.30.4.1 src/sys/dev/usb/u3g.c
cvs rdiff -u -r1.680 -r1.680.2.1 src/sys/dev/usb/usbdevs
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Wed, 15 Oct 2014 12:44:15 +0000
State-Changed-Why:
fixed, confirmed, and pulled up; thanks
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2014
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.
Home