NetBSD Problem Report #49356

From www@NetBSD.org  Mon Nov  3 20:55:35 2014
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id CCDC2A65ED
	for <gnats-bugs@gnats.NetBSD.org>; Mon,  3 Nov 2014 20:55:35 +0000 (UTC)
Message-Id: <20141103205534.5471FA6669@mollari.NetBSD.org>
Date: Mon,  3 Nov 2014 20:55:34 +0000 (UTC)
From: yaneurabeya@gmail.com
Reply-To: yaneurabeya@gmail.com
To: gnats-bugs@NetBSD.org
Subject: atf-c/config.h has been removed in ATF v0.2.1; several tests reference the header
X-Send-Pr-Version: www-1.0

>Number:         49356
>Category:       misc
>Synopsis:       atf-c/config.h has been removed in ATF v0.2.1; several tests reference the header
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    misc-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Nov 03 21:00:00 +0000 2014
>Closed-Date:    Fri Nov 21 05:20:12 +0000 2014
>Last-Modified:  Fri Nov 21 05:20:12 +0000 2014
>Originator:     Garrett Cooper
>Release:        n/a
>Organization:
EMC / Isilon Storage Division
>Environment:
n/a
>Description:
A recent update by jmmv@ to ATF 0.2.1 removed atf-c/config.h installation on FreeBSD:
https://svnweb.freebsd.org/base/head/lib/atf/libatf-c/Makefile?limit_changes=0&r1=273929&r2=273928&pathrev=273929

Several of the NetBSD testcases that have been ported to FreeBSD still reference the header:

$ grep -r atf-c/config.h tests/
tests/include/t_paths.c:#include <atf-c/config.h>
tests/lib/libc/gen/t_fpsetmask.c:#include <atf-c/config.h>
tests/lib/libc/gen/t_isnan.c:#include <atf-c/config.h>
tests/lib/libc/gen/t_siginfo.c:#include <atf-c/config.h>
tests/lib/libc/gen/t_floatunditf.c:#include <atf-c/config.h>
tests/lib/libc/gen/.#t_siginfo.c.1.20:#include <atf-c/config.h>
tests/lib/libc/stdlib/t_strtod.c:#include <atf-c/config.h>
tests/lib/libc/sys/t_sigaction.c:#include <atf-c/config.h>
tests/lib/libexecinfo/t_backtrace.c:#include <atf-c/config.h>
tests/lib/libm/t_ldexp.c:#include <atf-c/config.h>
tests/lib/libm/t_log.c:#include <atf-c/config.h>
tests/lib/libm/t_precision.c:#include <atf-c/config.h>
tests/lib/libpthread/t_mutex.c:#include <atf-c/config.h>
tests/lib/libpthread/t_sem.c:#include <atf-c/config.h>

>How-To-Repeat:
Attempt to upgrade ATF to v0.2.1 in a manner similar to the above commit to FreeBSD.
>Fix:

>Release-Note:

>Audit-Trail:
From: Justin Cormack <justin@specialbusservice.com>
To: gnats-bugs@netbsd.org
Cc: misc-bug-people@netbsd.org, gnats-admin@netbsd.org, netbsd-bugs@netbsd.org
Subject: Re: misc/49356: atf-c/config.h has been removed in ATF v0.2.1;
 several tests reference the header
Date: Mon, 3 Nov 2014 22:54:09 +0000

 On Mon, Nov 3, 2014 at 9:00 PM,  <yaneurabeya@gmail.com> wrote:
 >>Number:         49356
 >>Category:       misc
 >>Synopsis:       atf-c/config.h has been removed in ATF v0.2.1; several tests reference the header
 >>Confidential:   no
 >>Severity:       non-critical
 >>Priority:       low
 >>Responsible:    misc-bug-people
 >>State:          open
 >>Class:          sw-bug
 >>Submitter-Id:   net
 >>Arrival-Date:   Mon Nov 03 21:00:00 +0000 2014
 >>Originator:     Garrett Cooper
 >>Release:        n/a
 >>Organization:
 > EMC / Isilon Storage Division
 >>Environment:
 > n/a
 >>Description:
 > A recent update by jmmv@ to ATF 0.2.1 removed atf-c/config.h installation on FreeBSD:
 > https://svnweb.freebsd.org/base/head/lib/atf/libatf-c/Makefile?limit_changes=0&r1=273929&r2=273928&pathrev=273929
 >
 > Several of the NetBSD testcases that have been ported to FreeBSD still reference the header:
 >
 > $ grep -r atf-c/config.h tests/
 > tests/include/t_paths.c:#include <atf-c/config.h>
 > tests/lib/libc/gen/t_fpsetmask.c:#include <atf-c/config.h>
 > tests/lib/libc/gen/t_isnan.c:#include <atf-c/config.h>
 > tests/lib/libc/gen/t_siginfo.c:#include <atf-c/config.h>
 > tests/lib/libc/gen/t_floatunditf.c:#include <atf-c/config.h>
 > tests/lib/libc/gen/.#t_siginfo.c.1.20:#include <atf-c/config.h>
 > tests/lib/libc/stdlib/t_strtod.c:#include <atf-c/config.h>
 > tests/lib/libc/sys/t_sigaction.c:#include <atf-c/config.h>
 > tests/lib/libexecinfo/t_backtrace.c:#include <atf-c/config.h>
 > tests/lib/libm/t_ldexp.c:#include <atf-c/config.h>
 > tests/lib/libm/t_log.c:#include <atf-c/config.h>
 > tests/lib/libm/t_precision.c:#include <atf-c/config.h>
 > tests/lib/libpthread/t_mutex.c:#include <atf-c/config.h>
 > tests/lib/libpthread/t_sem.c:#include <atf-c/config.h>
 >
 >>How-To-Repeat:
 > Attempt to upgrade ATF to v0.2.1 in a manner similar to the above commit to FreeBSD.
 >>Fix:

 Well it does not look very necessary, as it only has a prototype that
 is not actually used anywhere, so will look at removing these includes
 so we can upgrade...

 Justin

From: "Justin Cormack" <justin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49356 CVS commit: src/tests
Date: Tue, 4 Nov 2014 00:20:19 +0000

 Module Name:	src
 Committed By:	justin
 Date:		Tue Nov  4 00:20:19 UTC 2014

 Modified Files:
 	src/tests/include: t_paths.c
 	src/tests/lib/libc/gen: t_floatunditf.c t_fpsetmask.c t_isnan.c
 	    t_siginfo.c
 	src/tests/lib/libc/stdlib: t_strtod.c
 	src/tests/lib/libc/sys: t_sigaction.c
 	src/tests/lib/libexecinfo: t_backtrace.c
 	src/tests/lib/libm: t_ldexp.c t_log.c t_precision.c
 	src/tests/lib/libpthread: t_mutex.c t_sem.c

 Log Message:
 PR misc/49356 remove unnecessary references to atf-c/config.h

 The function included via this header is not used and is removed in
 later versions of atf, so let us avoid it.


 To generate a diff of this commit:
 cvs rdiff -u -r1.13 -r1.14 src/tests/include/t_paths.c
 cvs rdiff -u -r1.5 -r1.6 src/tests/lib/libc/gen/t_floatunditf.c
 cvs rdiff -u -r1.13 -r1.14 src/tests/lib/libc/gen/t_fpsetmask.c
 cvs rdiff -u -r1.4 -r1.5 src/tests/lib/libc/gen/t_isnan.c
 cvs rdiff -u -r1.23 -r1.24 src/tests/lib/libc/gen/t_siginfo.c
 cvs rdiff -u -r1.31 -r1.32 src/tests/lib/libc/stdlib/t_strtod.c
 cvs rdiff -u -r1.2 -r1.3 src/tests/lib/libc/sys/t_sigaction.c
 cvs rdiff -u -r1.15 -r1.16 src/tests/lib/libexecinfo/t_backtrace.c
 cvs rdiff -u -r1.13 -r1.14 src/tests/lib/libm/t_ldexp.c
 cvs rdiff -u -r1.11 -r1.12 src/tests/lib/libm/t_log.c
 cvs rdiff -u -r1.1 -r1.2 src/tests/lib/libm/t_precision.c
 cvs rdiff -u -r1.6 -r1.7 src/tests/lib/libpthread/t_mutex.c
 cvs rdiff -u -r1.7 -r1.8 src/tests/lib/libpthread/t_sem.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: msaitoh@NetBSD.org
State-Changed-When: Fri, 21 Nov 2014 05:20:12 +0000
State-Changed-Why:
Submitter verified that it was fixed.
Thanks.


>Unformatted:

Home	PR Database Search