NetBSD Problem Report #49559

From www@NetBSD.org  Mon Jan 12 19:31:55 2015
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 4F02BA650D
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 12 Jan 2015 19:31:55 +0000 (UTC)
Message-Id: <20150112193154.526FCA65BE@mollari.NetBSD.org>
Date: Mon, 12 Jan 2015 19:31:54 +0000 (UTC)
From: brueffer@FreeBSD.org
Reply-To: brueffer@FreeBSD.org
To: gnats-bugs@NetBSD.org
Subject: makefs erroneously parses the FFS maxbpg option as maxbpf
X-Send-Pr-Version: www-1.0

>Number:         49559
>Category:       bin
>Synopsis:       makefs erroneously parses the FFS maxbpg option as maxbpf
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jan 12 19:35:01 +0000 2015
>Closed-Date:    Tue Apr 14 05:36:30 +0000 2015
>Last-Modified:  Tue Apr 14 05:36:30 +0000 2015
>Originator:     Christian Brueffer
>Release:        CURRENT
>Organization:
>Environment:
>Description:
This problem was reported as FreeBSD bug 196598 by Dan McGregor and has been fixed in FreeBSD revision r277085.
>How-To-Repeat:
(from the original PR)

# makefs -t ffs -o version=2,maxbpg=4096 -s 4g -N etc ../rootfs METALOG
makefs: Unknown option `maxbpg'
>Fix:
This is the diff committed to FreeBSD, the NetBSD one is analogous.

Modified: head/usr.sbin/makefs/ffs.c
==============================================================================
--- head/usr.sbin/makefs/ffs.c	Mon Jan 12 18:43:34 2015	(r277084)
+++ head/usr.sbin/makefs/ffs.c	Mon Jan 12 19:26:31 2015	(r277085)
@@ -191,7 +191,7 @@ ffs_parse_opts(const char *option, fsinf
 					"bytes per inode" },
 		{ "minfree",	&ffs_opts->minfree,	0,	99,
 					"minfree" },
-		{ "maxbpf",	&ffs_opts->maxbpg,	1,	INT_MAX,
+		{ "maxbpg",	&ffs_opts->maxbpg,	1,	INT_MAX,
 					"max blocks per file in a cg" },
 		{ "avgfilesize", &ffs_opts->avgfilesize,1,	INT_MAX,
 					"expected average file size" },

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49559 CVS commit: src/usr.sbin/makefs
Date: Mon, 12 Jan 2015 14:50:25 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Mon Jan 12 19:50:25 UTC 2015

 Modified Files:
 	src/usr.sbin/makefs: ffs.c

 Log Message:
 PR/49559: Christian Brueffer: Fix typo maxbpf instead of maxbpg.


 To generate a diff of this commit:
 cvs rdiff -u -r1.63 -r1.64 src/usr.sbin/makefs/ffs.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Soren Jacobsen" <snj@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49559 CVS commit: [netbsd-7] src/usr.sbin/makefs
Date: Tue, 14 Apr 2015 05:08:09 +0000

 Module Name:	src
 Committed By:	snj
 Date:		Tue Apr 14 05:08:09 UTC 2015

 Modified Files:
 	src/usr.sbin/makefs [netbsd-7]: ffs.c

 Log Message:
 Pull up following revision(s) (requested by christos in ticket #684):
 	usr.sbin/makefs/ffs.c: revision 1.64
 PR/49559: Christian Brueffer: Fix typo maxbpf instead of maxbpg.


 To generate a diff of this commit:
 cvs rdiff -u -r1.63 -r1.63.6.1 src/usr.sbin/makefs/ffs.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: snj@NetBSD.org
State-Changed-When: Tue, 14 Apr 2015 05:36:30 +0000
State-Changed-Why:
Fixed in current, pulled up to netbsd-7.  Thanks for the PR!


>Unformatted:

Home	PR Database Search