NetBSD Problem Report #49588

From www@NetBSD.org  Mon Jan 19 20:56:03 2015
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 949C8A57FE
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 19 Jan 2015 20:56:03 +0000 (UTC)
Message-Id: <20150119205602.A201CA654D@mollari.NetBSD.org>
Date: Mon, 19 Jan 2015 20:56:02 +0000 (UTC)
From: darkstar@city-net.com
Reply-To: darkstar@city-net.com
To: gnats-bugs@NetBSD.org
Subject: mtree does not return failure if extra files or directories are found and -e is not specified...
X-Send-Pr-Version: www-1.0

>Number:         49588
>Category:       bin
>Synopsis:       mtree does not return failure if extra files or directories are found and -e is not specified...
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jan 19 21:00:00 +0000 2015
>Originator:     Matthew Orgass
>Release:        src and pkgsrc as of 2015-01-19
>Organization:
>Environment:
>Description:

>How-To-Repeat:
test against an empty spec file -> returns success :(

>Fix:
--- verify.c.orig	2015-01-19 12:22:26.177578504 -0800
+++ verify.c	2015-01-19 12:23:24.336574657 -0800
@@ -170,9 +170,11 @@
 				    ? rmdir : unlink)(p->fts_accpath)) {
 					printf(", not removed: %s",
 					    strerror(errno));
+					rval = MISMATCHEXIT;
 				} else
 					printf(", removed");
-			}
+			} else
+				rval = MISMATCHEXIT;
 			putchar('\n');
 		}
 		fts_set(t, p, FTS_SKIP);

Home	PR Database Search