NetBSD Problem Report #49604
From www@NetBSD.org Sun Jan 25 15:54:48 2015
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
by mollari.NetBSD.org (Postfix) with ESMTPS id 3EC86A654C
for <gnats-bugs@gnats.NetBSD.org>; Sun, 25 Jan 2015 15:54:48 +0000 (UTC)
Message-Id: <20150125155446.E807BA6555@mollari.NetBSD.org>
Date: Sun, 25 Jan 2015 15:54:46 +0000 (UTC)
From: lenzi.sergio@gmail.com
Reply-To: lenzi.sergio@gmail.com
To: gnats-bugs@NetBSD.org
Subject: hald aborts core
X-Send-Pr-Version: www-1.0
>Number: 49604
>Category: pkg
>Synopsis: hald aborts core
>Confidential: no
>Severity: critical
>Priority: high
>Responsible: pkg-manager
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Sun Jan 25 15:55:00 +0000 2015
>Closed-Date: Sun Jan 25 18:46:25 +0000 2015
>Last-Modified: Sun Jan 25 18:50:00 +0000 2015
>Originator: sergio lenzi
>Release: NetBSD 6.1.5_PATCH
>Organization:
http://www.k1.com.br
>Environment:
NetBSD netbsd61.homenet 6.1.5_PATCH NetBSD 6.1.5_PATCH (GENERIC) #0: Sat Jan 17 21:29:06 BRST 2015 root@z5000.lenzicasa:/usr/obj/sys/arch/i386/compile/GENERIC i386
>Description:
hald aborts core with --verbose=yes AND when you insert an unknown pen-drive in the system
>How-To-Repeat:
execute hald --daemon=no --verbose=yes
>Fix:
recode some portions of hald code...
patch follows
============================================================
diff -up hald/netbsd/devinfo_mass.c.orig hald/netbsd/devinfo_mass.c
--- hald/netbsd/devinfo_mass.c.orig 2015-01-24 23:13:19.000000000 -0200
+++ hald/netbsd/devinfo_mass.c 2015-01-24 23:17:04.000000000 -0200
@@ -230,7 +230,7 @@ devinfo_mass_add(HalDevice *parent, cons
}
if (gparent_devnode && strstr (gparent_devnode, "umass") == gparent_devnode)
hal_device_property_set_string (d, "storage.bus", "usb");
- else if (strstr (parent_devnode, "atabus") == parent_devnode)
+ else if (parent_devnode && strstr (parent_devnode, "atabus") == parent_devnode)
hal_device_property_set_string (d, "storage.bus", "ide");
else
hal_device_property_set_string (d, "storage.bus", "scsi");
diff -up hald/netbsd/devinfo_misc.c.orig hald/netbsd/devinfo_misc.c
--- hald/netbsd/devinfo_misc.c.orig 2015-01-24 22:53:54.000000000 -0200
+++ hald/netbsd/devinfo_misc.c 2015-01-24 22:53:56.000000000 -0200
@@ -137,12 +137,12 @@ devinfo_default_apply_quirks(HalDevice *
/* acpiacad(4) */
if (strncmp (devnode, "acpiacad", 8) == 0) {
- HAL_INFO (("%s: applying acpiacad quirks"));
+ HAL_INFO (("%s: applying acpiacad quirks",devnode));
hal_device_add_capability (d, "ac_adapter");
/* acpibat(4) */
} else if (strncmp (devnode, "acpibat", 7) == 0) {
- HAL_INFO (("%s: applying acpibat quirks"));
+ HAL_INFO (("%s: applying acpibat quirks",devnode));
hal_device_add_capability (d, "battery");
hal_device_property_set_string (d, "battery.type", "primary");
}
diff -up hald/netbsd/drvctl.c.orig hald/netbsd/drvctl.c
--- hald/netbsd/drvctl.c.orig 2015-01-24 22:53:54.000000000 -0200
+++ hald/netbsd/drvctl.c 2015-01-24 22:53:56.000000000 -0200
@@ -123,7 +123,7 @@ drvctl_dev_add(gchar *name)
parent = hal_device_store_match_key_value_string (
hald_get_gdl(), "netbsd.device", pdevnode);
if (parent == NULL)
- HAL_INFO (("dev_add: name=%s but netbsd.device=%s not found", pdevnode));
+ HAL_INFO (("dev_add: name=%s but netbsd.device=%s not found",name, pdevnode));
}
d = devinfo_add_node (parent, name);
@@ -245,7 +245,7 @@ drvctl_find_device_with_child(const gcha
if (laa.l_childname)
free(laa.l_childname);
- /* HAL_INFO (("%s: couldn't find device with child %s", curnode, devnode)); */
+ HAL_INFO (("%s: couldn't find device with child %s", curnode, devnode));
return FALSE;
}
[root@netbsd61 /usr/pkgsrc/sysutils/hal]# ^C
[root@netbsd61 /usr/pkgsrc/sysutils/hal]# cat patches/patch-lenzi
diff -up hald/netbsd/devinfo_mass.c.orig hald/netbsd/devinfo_mass.c
--- hald/netbsd/devinfo_mass.c.orig 2015-01-24 23:13:19.000000000 -0200
+++ hald/netbsd/devinfo_mass.c 2015-01-24 23:17:04.000000000 -0200
@@ -230,7 +230,7 @@ devinfo_mass_add(HalDevice *parent, cons
}
if (gparent_devnode && strstr (gparent_devnode, "umass") == gparent_devnode)
hal_device_property_set_string (d, "storage.bus", "usb");
- else if (strstr (parent_devnode, "atabus") == parent_devnode)
+ else if (parent_devnode && strstr (parent_devnode, "atabus") == parent_devnode)
hal_device_property_set_string (d, "storage.bus", "ide");
else
hal_device_property_set_string (d, "storage.bus", "scsi");
diff -up hald/netbsd/devinfo_misc.c.orig hald/netbsd/devinfo_misc.c
--- hald/netbsd/devinfo_misc.c.orig 2015-01-24 22:53:54.000000000 -0200
+++ hald/netbsd/devinfo_misc.c 2015-01-24 22:53:56.000000000 -0200
@@ -137,12 +137,12 @@ devinfo_default_apply_quirks(HalDevice *
/* acpiacad(4) */
if (strncmp (devnode, "acpiacad", 8) == 0) {
- HAL_INFO (("%s: applying acpiacad quirks"));
+ HAL_INFO (("%s: applying acpiacad quirks",devnode));
hal_device_add_capability (d, "ac_adapter");
/* acpibat(4) */
} else if (strncmp (devnode, "acpibat", 7) == 0) {
- HAL_INFO (("%s: applying acpibat quirks"));
+ HAL_INFO (("%s: applying acpibat quirks",devnode));
hal_device_add_capability (d, "battery");
hal_device_property_set_string (d, "battery.type", "primary");
}
diff -up hald/netbsd/drvctl.c.orig hald/netbsd/drvctl.c
--- hald/netbsd/drvctl.c.orig 2015-01-24 22:53:54.000000000 -0200
+++ hald/netbsd/drvctl.c 2015-01-24 22:53:56.000000000 -0200
@@ -123,7 +123,7 @@ drvctl_dev_add(gchar *name)
parent = hal_device_store_match_key_value_string (
hald_get_gdl(), "netbsd.device", pdevnode);
if (parent == NULL)
- HAL_INFO (("dev_add: name=%s but netbsd.device=%s not found", pdevnode));
+ HAL_INFO (("dev_add: name=%s but netbsd.device=%s not found",name, pdevnode));
}
d = devinfo_add_node (parent, name);
@@ -245,7 +245,7 @@ drvctl_find_device_with_child(const gcha
if (laa.l_childname)
free(laa.l_childname);
- /* HAL_INFO (("%s: couldn't find device with child %s", curnode, devnode)); */
+ HAL_INFO (("%s: couldn't find device with child %s", curnode, devnode));
return FALSE;
}
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Sun, 25 Jan 2015 18:46:25 +0000
State-Changed-Why:
Committed, thanks.
Responsible-Changed-From-To: port-i386-maintainer->pkg-manager
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Sun, 25 Jan 2015 18:46:39 +0000
Responsible-Changed-Why:
pkgsrc bug report
From: "Thomas Klausner" <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/49604 CVS commit: pkgsrc/sysutils/hal
Date: Sun, 25 Jan 2015 18:46:09 +0000
Module Name: pkgsrc
Committed By: wiz
Date: Sun Jan 25 18:46:09 UTC 2015
Modified Files:
pkgsrc/sysutils/hal: Makefile
pkgsrc/sysutils/hal/files/hald-netbsd: devinfo_mass.c devinfo_misc.c
drvctl.c
Log Message:
Apply some bug fixes for the NetBSD hald from sergio lenzi in PR 49604.
Bump PKGREVISION.
To generate a diff of this commit:
cvs rdiff -u -r1.70 -r1.71 pkgsrc/sysutils/hal/Makefile
cvs rdiff -u -r1.4 -r1.5 pkgsrc/sysutils/hal/files/hald-netbsd/devinfo_mass.c
cvs rdiff -u -r1.5 -r1.6 pkgsrc/sysutils/hal/files/hald-netbsd/devinfo_misc.c
cvs rdiff -u -r1.3 -r1.4 pkgsrc/sysutils/hal/files/hald-netbsd/drvctl.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.