NetBSD Problem Report #49672

From www@NetBSD.org  Tue Feb 17 21:19:41 2015
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 9E5D7A567D
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 17 Feb 2015 21:19:41 +0000 (UTC)
Message-Id: <20150217211940.4FFF9A654F@mollari.NetBSD.org>
Date: Tue, 17 Feb 2015 21:19:40 +0000 (UTC)
From: youri.mout@gmail.com
Reply-To: youri.mout@gmail.com
To: gnats-bugs@NetBSD.org
Subject: Patch for devel/patch no Mac OS X (with fix)
X-Send-Pr-Version: www-1.0

>Number:         49672
>Category:       pkg
>Synopsis:       Patch for devel/patch no Mac OS X (with fix)
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Feb 17 21:20:00 +0000 2015
>Closed-Date:    Sun Feb 22 22:17:53 +0000 2015
>Last-Modified:  Sun Feb 22 22:17:53 +0000 2015
>Originator:     Youri Mouton
>Release:        current
>Organization:
>Environment:
Darwin mac.local 14.1.0 Darwin Kernel Version 14.1.0: Mon Dec 22 23:10:38 PST 2014; root:xnu-2782.10.72~2/RELEASE_X86_64 x86_64

>Description:
Fails to build because symlinkat.c requires sys/stat.h.
I also added string.h to remove a warning about implicitly calling strlen.
>How-To-Repeat:

>Fix:
diff --git a/devel/patch/Makefile b/devel/patch/Makefile
index f643a05..78564d8 100644
--- a/devel/patch/Makefile
+++ b/devel/patch/Makefile
@@ -20,6 +20,10 @@ CONFIGURE_ARGS+=	--program-prefix=g
 INSTALLATION_DIRS=	${PKGGNUDIR}bin ${PKGGNUDIR}${PKGMANDIR}/man1

 do-patch:
+	${MV} ${WRKSRC}/lib/symlinkat.c ${WRKSRC}/lib/symlinkat.c.orig
+	${AWK} '{gsub(/errno\.h\>/, "errno\.h>\n#include <string.h>\n#include <sys/stat.h>");print}'	\
+		< ${WRKSRC}/lib/symlinkat.c.orig	\
+		> ${WRKSRC}/lib/symlinkat.c
 	${MV} ${WRKSRC}/src/pch.c ${WRKSRC}/src/pch.c.orig
 	${AWK} '/#include <pch.h>/{print $$0 "\n#include <sys/param.h>";next;}\
 		/^#if HAVE_SETMODE_DOS/					\

>Release-Note:

>Audit-Trail:
From: Tobias Nygren <tnn@NetBSD.org>
To: gnats-bugs@NetBSD.org
Cc: youri.mout@gmail.com
Subject: Re: pkg/49672: Patch for devel/patch no Mac OS X (with fix)
Date: Wed, 18 Feb 2015 08:55:09 +0100

 Hi!

 Can you please test if it works to do this instead?
 (Patch-by-awk hurts my eyes >_<)

 Thanks,
 -Tobias
 =======================

 do-patch:
 .for stdhdr in sys/param.h sys/stat.h string.h
 	echo "#ifdef HAVE_${stdhdr:tu:C,[/.],_,g}" >> ${WRKSRC}/config.hin
 	echo "#include <${stdhdr}>" >> ${WRKSRC}/config.hin
 	echo "#endif" >> ${WRKSRC}/config.hin
 .endfor

From: youri <youri.mout@gmail.com>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/49672: Patch for devel/patch no Mac OS X (with fix)
Date: Thu, 19 Feb 2015 00:00:20 +0100

 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1

 Sure, this works too.

 On 18/02/15 09:00, Tobias Nygren wrote:
 > The following reply was made to PR pkg/49672; it has been noted by
 > GNATS.
 > 
 > From: Tobias Nygren <tnn@NetBSD.org> To: gnats-bugs@NetBSD.org Cc:
 > youri.mout@gmail.com Subject: Re: pkg/49672: Patch for devel/patch
 > no Mac OS X (with fix) Date: Wed, 18 Feb 2015 08:55:09 +0100
 > 
 > Hi!
 > 
 > Can you please test if it works to do this instead? (Patch-by-awk
 > hurts my eyes >_<)
 > 
 > Thanks, -Tobias =======================
 > 
 > do-patch: .for stdhdr in sys/param.h sys/stat.h string.h echo
 > "#ifdef HAVE_${stdhdr:tu:C,[/.],_,g}" >> ${WRKSRC}/config.hin echo
 > "#include <${stdhdr}>" >> ${WRKSRC}/config.hin echo "#endif" >>
 > ${WRKSRC}/config.hin .endfor
 > 
 > 
 -----BEGIN PGP SIGNATURE-----

 iQIcBAEBAgAGBQJU5RmEAAoJEGoJXMYtmcj3o20QAIXQVbgb/QLt/A1H+/WA/KIw
 bZdlFd/E2ZQp6CjX9pNz3seQuMOq3E5Rxj7qgkWp7COR7BsVHoEo94mTw1q0UBIo
 TeAEZOBcFYz0thiTGKj2rADLPSDPrC27ZixEucF++s3k0ycrbPqFEK1g+crkfZFL
 YDF3C1Xg0vy/AeKJvk8mBs87f7TS4qU1ZJQ3g4RMEzt0CrFP3+2/LG8RoDnQDm4f
 FN3Y/V9TJgAaBIPW1aILQO+fhuDr+h9Ocj26jT7swtqa0J0O5//pENy6sYMLyjvZ
 FBblg+b2xkvz05Q5TXf0sONl3zoSs9dd3oGCw56+IPuEDgjKmdLmqrVttuw/yC3x
 /0cZeZYtZzziATEZOcjx0oSz/fJMw7tRWySpqLZNdD4JyctIaiSFaVjtzWLlOCzb
 PbV/PNhiA7mZk3Bk/XJRy6npiihKwAqLypask58CGMZsuGGTGY1Qv9vR4P7WNdpc
 LH9omw9idU2+N/R5MKFCJ2hBxbTDXYj2fi+qGp2k1Q8FyPxkkP+BErUsn+IweLUT
 3hVuh7ASmjky8++0bTwwAQVQyiLW1jnKwA7GchJACQE/kMRtyff42OjcasQrZewe
 j9SM1IrBClCPTWrYAvcD/gj8onroGW1w0JflM/RyYTJtlEri2whIuZBCCv6Oo7FW
 uOwdWDgFrscapL7rGRLC
 =FtB+
 -----END PGP SIGNATURE-----

From: "Tobias Nygren" <tnn@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49672 CVS commit: pkgsrc/devel/patch
Date: Fri, 20 Feb 2015 07:09:19 +0000

 Module Name:	pkgsrc
 Committed By:	tnn
 Date:		Fri Feb 20 07:09:19 UTC 2015

 Modified Files:
 	pkgsrc/devel/patch: Makefile

 Log Message:
 PR pkg/49672: OSX build fix (already reported and fixed upstream)
 While here simplify Interix fix by overriding autoconf test instead of
 manually patching the sources.


 To generate a diff of this commit:
 cvs rdiff -u -r1.41 -r1.42 pkgsrc/devel/patch/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Matthias Scheler" <tron@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49672 CVS commit: [pkgsrc-2014Q4] pkgsrc/devel/patch
Date: Fri, 20 Feb 2015 19:55:43 +0000

 Module Name:	pkgsrc
 Committed By:	tron
 Date:		Fri Feb 20 19:55:43 UTC 2015

 Modified Files:
 	pkgsrc/devel/patch [pkgsrc-2014Q4]: Makefile

 Log Message:
 Pullup ticket #4626 - requested by tnn
 devel/patch: build fix

 Revisions pulled up:
 - devel/patch/Makefile                                          1.42

 ---
    Module Name:	pkgsrc
    Committed By:	tnn
    Date:		Fri Feb 20 07:09:19 UTC 2015

    Modified Files:
    	pkgsrc/devel/patch: Makefile

    Log Message:
    PR pkg/49672: OSX build fix (already reported and fixed upstream)
    While here simplify Interix fix by overriding autoconf test instead of
    manually patching the sources.


 To generate a diff of this commit:
 cvs rdiff -u -r1.40.2.1 -r1.40.2.2 pkgsrc/devel/patch/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: tnn@NetBSD.org
State-Changed-When: Sun, 22 Feb 2015 22:17:53 +0000
State-Changed-Why:
Fixed and pulled up, thanks


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.