NetBSD Problem Report #49870

From www@NetBSD.org  Sat May  2 18:25:21 2015
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id F4031A650D
	for <gnats-bugs@gnats.NetBSD.org>; Sat,  2 May 2015 18:25:20 +0000 (UTC)
Message-Id: <20150502182519.8B799A6567@mollari.NetBSD.org>
Date: Sat,  2 May 2015 18:25:19 +0000 (UTC)
From: vchaves@ymail.com
Reply-To: vchaves@ymail.com
To: gnats-bugs@NetBSD.org
Subject: postinstall script skipping fontconfig check
X-Send-Pr-Version: www-1.0

>Number:         49870
>Category:       install
>Synopsis:       postinstall script skipping fontconfig check
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    martin
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat May 02 18:30:00 +0000 2015
>Closed-Date:    Fri May 08 18:49:46 +0000 2015
>Last-Modified:  Fri May 08 18:49:46 +0000 2015
>Originator:     Vicente Chaves
>Release:        NetBSD 7.0_BETA
>Organization:
>Environment:
System: NetBSD netbsd7.vbox.lab 7.0_BETA NetBSD 7.0_BETA (GENERIC) #1: Sat May 2 02:57:33 UTC 2015 vchaves@netbsd7.vbox.lab:/home/vchaves/netbsd-7/src/sys/arch/amd64/compile/obj/GENERIC amd64
Architecture: x86_64
Machine: amd64
>Description:
At the end of the ./build.sh -U -x install =/  the postinstall script searches for X11 sources in /usr/xsrc despite receiving the -s option correctly.


postinstall-check ===> .        (with: DESTDIR=/)
   === Post installation checks ===
AWK=/home/vchaves/netbsd-7/src/obj/tooldir.NetBSD-7.0_BETA-amd64/bin/nbawk               DB=/home/vchaves/netbsd-7/src/obj/tooldir.NetBSD-7.0_BETA-amd64/bin/nbdb                        HOST_SH=/bin/sh                 MAKE=/home/vchaves/netbsd-7/src/obj/tooldir.NetBSD-7.0_BETA-amd64/bin/nbmake                    PWD_MKDB=/home/vchaves/netbsd-7/src/obj/tooldir.NetBSD-7.0_BETA-amd64/bin/nbpwd_mkdb    SED=/home/vchaves/netbsd-7/src/obj/tooldir.NetBSD-7.0_BETA-amd64/bin/nbsed              STAT=/home/vchaves/netbsd-7/src/obj/tooldir.NetBSD-7.0_BETA-amd64/bin/nbstat /bin/sh /home/vchaves/netbsd-7/src/usr.sbin/postinstall/postinstall  -m amd64 -a x86_64 -s /home/vchaves/netbsd-7/src -d // check; if [ $? -gt 1 ]; then exit 1; fi
Source directory: /home/vchaves/netbsd-7/src
Target directory: //
bluetooth check:
ddbonpanic check:
defaults check:
        /tmp/_postinstall.17194.0/defaults/rc.conf != ///etc/defaults/rc.conf
dhcpcd check:
dhcpcdrundir check:
envsys check:
fontconfig check:
        /usr/src/../xsrc/external/mit/fontconfig/dist/conf.d is not a directory; skipping check
gid check:
gpio check:
hosts check:
iscsi check:
makedev check:
motd check:
eval: cannot open /home/vchaves/netbsd-7/src/etc/motd: no such file
        Bug reporting messages do not seem to match the installed release
mtree check:
        /tmp/_postinstall.17194.0/NetBSD.dist != ///etc/mtree/NetBSD.dist
named check:
pam check:
periodic check:
pf check:
pwd_mkdb check:
rc check:
ssh check:
wscons check:
x11 check:
xkb check:
uid check:
varrwho check:
tcpdumpchroot check:
atf check:
catpages check:
ptyfsoldnodes check:
        Remove legacy device node ///dev/ptyp0
        Remove legacy device node ///dev/ptyp1
        Remove legacy device node ///dev/ttyp0
        Remove legacy device node ///dev/ttyp1
varshm check:
obsolete check:
        Remove obsolete file ///lib/libc.so.12.193
        Remove obsolete link ///usr/lib/libc.so.12.193
        Remove obsolete file ///usr/lib/i386/libc.so.12.193
postinstall checks passed: bluetooth ddbonpanic dhcpcd dhcpcdrundir envsys fontconfig gid gpio hosts iscsi makedev named pam periodic pf pwd_mkdb rc ssh wscons x11 xkb uid varrwho tcpdumpchroot atf catpages varshm
postinstall checks failed: defaults motd mtree ptyfsoldnodes obsolete
To fix, run:
    /bin/sh /home/vchaves/netbsd-7/src/usr.sbin/postinstall/postinstall -s /home/vchaves/netbsd-7/src -d // fix defaults motd mtree ptyfsoldnodes obsolete
Note that this may overwrite local changes.

>How-To-Repeat:
Try installing the distribution with ./build.sh -U -x install=/ , and the sources are not in their default location.
>Fix:
the following patch worked for me

cvs diff: Diffing usr.sbin/postinstall
Index: usr.sbin/postinstall/postinstall
===================================================================
RCS file: /cvsroot/src/usr.sbin/postinstall/postinstall,v
retrieving revision 1.175.2.4
diff -r1.175.2.4 postinstall
2115d2114
<       XSRC_DIR="${SRC_ARG}/../xsrc"
2211a2211,2214
>       if [ -z "${XSRC_DIR}" ]; then
>               XSRC_DIR="${SRC_DIR}/../xsrc"
>       fi
>

>Release-Note:

>Audit-Trail:
From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: install/49870: postinstall script skipping fontconfig check
Date: Sat, 2 May 2015 21:05:24 +0200

 I think instead of changing the (documented) default for postinstall(8),
 we should pass the proper arguments from the Makefile (as we certainly
 know the directory there).

 The attached (mostly untested) patch should do that - can you give it
 a try?

 Thanks,

 Martin

 (note: this is -current, didn't check wether it applies cleanly, but the
 idea should be obvious)


 Index: Makefile
 ===================================================================
 RCS file: /cvsroot/src/Makefile,v
 retrieving revision 1.312
 diff -u -r1.312 Makefile
 --- Makefile	7 Jan 2015 20:42:01 -0000	1.312
 +++ Makefile	2 May 2015 19:01:04 -0000
 @@ -181,24 +181,28 @@
  	SED=${TOOL_SED:Q}		\
  	STAT=${TOOL_STAT:Q}

 +.if ${MKX11} != "no"
 +_POSTINSTALL_X11=-x ${X11SRCDIR}
 +.endif
 +
  postinstall-check: .PHONY
  	@echo "   === Post installation checks ==="
 -	${_POSTINSTALL_ENV} ${HOST_SH} ${_POSTINSTALL} -s ${.CURDIR} -d ${DESTDIR}/ check; if [ $$? -gt 1 ]; then exit 1; fi
 +	${_POSTINSTALL_ENV} ${HOST_SH} ${_POSTINSTALL} -s ${.CURDIR} ${_POSTINSTALL_X11} -d ${DESTDIR}/ check; if [ $$? -gt 1 ]; then exit 1; fi
  	@echo "   ================================"

  postinstall-fix: .NOTMAIN .PHONY
  	@echo "   === Post installation fixes ==="
 -	${_POSTINSTALL_ENV} ${HOST_SH} ${_POSTINSTALL} -s ${.CURDIR} -d ${DESTDIR}/ fix
 +	${_POSTINSTALL_ENV} ${HOST_SH} ${_POSTINSTALL} -s ${.CURDIR} ${_POSTINSTALL_X11} -d ${DESTDIR}/ fix
  	@echo "   ==============================="

  postinstall-fix-obsolete: .NOTMAIN .PHONY
  	@echo "   === Removing obsolete files ==="
 -	${_POSTINSTALL_ENV} ${HOST_SH} ${_POSTINSTALL} -s ${.CURDIR} -d ${DESTDIR}/ fix obsolete
 +	${_POSTINSTALL_ENV} ${HOST_SH} ${_POSTINSTALL} -s ${.CURDIR} ${_POSTINSTALL_X11} -d ${DESTDIR}/ fix obsolete
  	@echo "   ==============================="

  postinstall-fix-obsolete_stand: .NOTMAIN .PHONY
  	@echo "   === Removing obsolete files ==="
 -	${_POSTINSTALL_ENV} ${HOST_SH} ${_POSTINSTALL} -s ${.CURDIR} -d ${DESTDIR}/ fix obsolete_stand
 +	${_POSTINSTALL_ENV} ${HOST_SH} ${_POSTINSTALL} -s ${.CURDIR} ${_POSTINSTALL_X11} -d ${DESTDIR}/ fix obsolete_stand
  	@echo "   ==============================="



From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@netbsd.org, vchaves@ymail.com
Cc: 
Subject: Re: install/49870: postinstall script skipping fontconfig check
Date: Sun, 3 May 2015 10:30:00 +0200

 On Sat, May 02, 2015 at 07:10:07PM +0000, Martin Husemann wrote:
 >  +.if ${MKX11} != "no"
 >  +_POSTINSTALL_X11=-x ${X11SRCDIR}

 This should, of course, be: -x ${X11SRCDIR:Q}

 Martin

From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49870 CVS commit: src
Date: Sun, 3 May 2015 15:13:13 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Sun May  3 15:13:13 UTC 2015

 Modified Files:
 	src: Makefile

 Log Message:
 PR 49870: pass the xsrc path to postinstall


 To generate a diff of this commit:
 cvs rdiff -u -r1.312 -r1.313 src/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Vicente Chaves de Melo <vchaves@ymail.com>
To: Martin Husemann <martin@duskware.de>, gnats-bugs@netbsd.org
Cc: 
Subject: Re: install/49870: postinstall script skipping fontconfig check
Date: Sun, 03 May 2015 11:01:35 -0300

 Hello Martin,
 I confirm that the patch mentioned by you fixes the problem and now the 
 postinstall script receives the option -x pointing correct location of 
 the X11 sources.
 Thank you very much,
 Vchaves.

 On 5/3/2015 5:30 AM, Martin Husemann wrote:
 > On Sat, May 02, 2015 at 07:10:07PM +0000, Martin Husemann wrote:
 >>   +.if ${MKX11} != "no"
 >>   +_POSTINSTALL_X11=-x ${X11SRCDIR}
 > This should, of course, be: -x ${X11SRCDIR:Q}
 >
 > Martin

Responsible-Changed-From-To: install-manager->martin
Responsible-Changed-By: martin@NetBSD.org
Responsible-Changed-When: Sun, 03 May 2015 19:33:43 +0000
Responsible-Changed-Why:
take


State-Changed-From-To: open->pending-pullups
State-Changed-By: martin@NetBSD.org
State-Changed-When: Sun, 03 May 2015 19:34:38 +0000
State-Changed-Why:
Waiting for #733


From: "Jeff Rizzo" <riz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49870 CVS commit: [netbsd-7] src
Date: Mon, 4 May 2015 20:24:42 +0000

 Module Name:	src
 Committed By:	riz
 Date:		Mon May  4 20:24:42 UTC 2015

 Modified Files:
 	src [netbsd-7]: Makefile

 Log Message:
 Pull up following revision(s) (requested by martin in ticket #733):
 	Makefile: revision 1.313
 PR 49870: pass the xsrc path to postinstall


 To generate a diff of this commit:
 cvs rdiff -u -r1.309.2.1 -r1.309.2.2 src/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: pending-pullups->closed
State-Changed-By: martin@NetBSD.org
State-Changed-When: Fri, 08 May 2015 18:49:46 +0000
State-Changed-Why:
pullups done


>Unformatted:

Home	PR Database Search