NetBSD Problem Report #49879

From hf@spg.tu-darmstadt.de  Tue May  5 11:47:43 2015
Return-Path: <hf@spg.tu-darmstadt.de>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 31F09A654B
	for <gnats-bugs@gnats.NetBSD.org>; Tue,  5 May 2015 11:47:43 +0000 (UTC)
Message-Id: <201505051146.t45BkG0g025998@Gstoder.nt.e-technik.tu-darmstadt.de>
Date: Tue, 5 May 2015 13:46:16 +0200 (CEST)
From: Hauke Fath <hf@spg.tu-darmstadt.de>
Reply-To: Hauke Fath <hf@spg.tu-darmstadt.de>
To: gnats-bugs@gnats.NetBSD.org
Cc: Hauke Fath <hf@spg.tu-darmstadt.de>
Subject: netbsd-7 ixgbe.o link failure without 'pseudo-device vlan'
X-Send-Pr-Version: 3.95

>Number:         49879
>Category:       kern
>Synopsis:       ixgbe.o link failure without 'pseudo-device vlan'
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    msaitoh
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue May 05 11:50:00 +0000 2015
>Closed-Date:    Sun May 10 18:41:46 +0000 2015
>Last-Modified:  Sun May 10 18:41:46 +0000 2015
>Originator:     Hauke Fath
>Release:        netbsd-7
>Organization:
Technische Universitaet Darmstadt
>Environment:


System: NetBSD netbsd-7 of 2015-05-05 sources
Architecture: i386
Machine: i386
>Description:

	A kernel configured without 'pseudo-device vlan' fails to link:

#      link  VLANTEST/netbsd
/u/netbsd-builds/7/i386/tools/bin/i486--netbsdelf-ld -Map netbsd.map --cref -T /public/netbsd-7/sys/arch/i386/conf/kern.ldscript -Ttext c0100000 -e start -X -o netbsd ${SYSTEM_OBJ} ${EXTRA_OBJ} vers.o
ixgbe.o: In function `ixgbe_detach':
ixgbe.c:(.text+0x32fc): undefined reference to `vlan_ifdetach'
*** [netbsd] Error code 1

nbmake: stopped in /var/obj/netbsd-builds/7/i386/sys/arch/i386/compile/VLANTEST
1 error

>How-To-Repeat:

Build a kernel with the following config

# Non MODULAR
#
include "arch/i386/conf/GENERIC"

no options		MODULAR
no pseudo-device	vlan	# IEEE 802.1q encapsulation


>Fix:
	Conditionally compile vlan support in ixgbe.c, I guess.

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: kern-bug-people->msaitoh
Responsible-Changed-By: msaitoh@NetBSD.org
Responsible-Changed-When: Wed, 06 May 2015 09:16:46 +0000
Responsible-Changed-Why:
mine.


From: "SAITOH Masanobu" <msaitoh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49879 CVS commit: src/sys/dev/pci/ixgbe
Date: Wed, 6 May 2015 09:21:22 +0000

 Module Name:	src
 Committed By:	msaitoh
 Date:		Wed May  6 09:21:22 UTC 2015

 Modified Files:
 	src/sys/dev/pci/ixgbe: ixgbe.c

 Log Message:
  Fixes link error without vlan. PR#49879.


 To generate a diff of this commit:
 cvs rdiff -u -r1.28 -r1.29 src/sys/dev/pci/ixgbe/ixgbe.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Jeff Rizzo" <riz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49879 CVS commit: [netbsd-7] src/sys/dev/pci/ixgbe
Date: Wed, 6 May 2015 23:29:21 +0000

 Module Name:	src
 Committed By:	riz
 Date:		Wed May  6 23:29:21 UTC 2015

 Modified Files:
 	src/sys/dev/pci/ixgbe [netbsd-7]: LICENSE ixgbe.c ixgbe.h ixgbe_82598.c
 	    ixgbe_82598.h ixgbe_82599.c ixgbe_82599.h ixgbe_api.c ixgbe_api.h
 	    ixgbe_common.c ixgbe_common.h ixgbe_mbx.h ixgbe_netbsd.h
 	    ixgbe_osdep.h ixgbe_phy.c ixgbe_phy.h ixgbe_type.h ixgbe_vf.c
 	    ixgbe_vf.h ixgbe_x540.c ixgbe_x540.h ixv.c

 Log Message:
 Pull up following revisions (requested by msaitoh in ticket #734):
 sys/dev/pci/ixgbe/LICENSE			1.2
 sys/dev/pci/ixgbe/ixgbe.c			1.28-1.29
 sys/dev/pci/ixgbe/ixgbe.h			1.7
 sys/dev/pci/ixgbe/ixgbe_82598.c			1.4
 sys/dev/pci/ixgbe/ixgbe_82598.h			1.3
 sys/dev/pci/ixgbe/ixgbe_82599.c			1.9
 sys/dev/pci/ixgbe/ixgbe_82599.h			1.2
 sys/dev/pci/ixgbe/ixgbe_api.c			1.7
 sys/dev/pci/ixgbe/ixgbe_api.h			1.4
 sys/dev/pci/ixgbe/ixgbe_common.c		1.5
 sys/dev/pci/ixgbe/ixgbe_common.h		1.4
 sys/dev/pci/ixgbe/ixgbe_mbx.h			1.4
 sys/dev/pci/ixgbe/ixgbe_netbsd.h		1.3
 sys/dev/pci/ixgbe/ixgbe_osdep.h			1.7
 sys/dev/pci/ixgbe/ixgbe_phy.c			1.5
 sys/dev/pci/ixgbe/ixgbe_phy.h			1.4
 sys/dev/pci/ixgbe/ixgbe_type.h			1.10
 sys/dev/pci/ixgbe/ixgbe_vf.c			1.4
 sys/dev/pci/ixgbe/ixgbe_vf.h			1.5
 sys/dev/pci/ixgbe/ixgbe_x540.c			1.3
 sys/dev/pci/ixgbe/ixgbe_x540.h			1.2
 sys/dev/pci/ixgbe/ixv.c				1.8

 	- Sync ixg(4) up to FreeBSD r250108:
 	  - Cleanup some unused counters and some unused code.
 	  - Improve performance.
 	  - Fix flow control - don't override user value on re-init
 	  - Fix to make 1G optics work correctly
 	  - Change to interrupt enabling - some bits were incorrect
 	    for certain hardware.
 	  - Certain stats fixes, remove a duplicate increment of
 	    ierror, thanks to Scott Long for pointing these out.
 	  - Fix the setting of RX which related to multicast.
 	  - Some netmap related fixes.
 	- Fixes link error without vlan. PR#49879 reported by Hauke Fath.
 	[msaitoh, ticket #734]


 To generate a diff of this commit:
 cvs rdiff -u -r1.1 -r1.1.28.1 src/sys/dev/pci/ixgbe/LICENSE
 cvs rdiff -u -r1.14.2.4 -r1.14.2.5 src/sys/dev/pci/ixgbe/ixgbe.c
 cvs rdiff -u -r1.1.28.3 -r1.1.28.4 src/sys/dev/pci/ixgbe/ixgbe.h
 cvs rdiff -u -r1.1.28.1 -r1.1.28.2 src/sys/dev/pci/ixgbe/ixgbe_82598.c \
     src/sys/dev/pci/ixgbe/ixgbe_api.h src/sys/dev/pci/ixgbe/ixgbe_common.h \
     src/sys/dev/pci/ixgbe/ixgbe_mbx.h src/sys/dev/pci/ixgbe/ixgbe_phy.h \
     src/sys/dev/pci/ixgbe/ixgbe_vf.c
 cvs rdiff -u -r1.2.4.2 -r1.2.4.3 src/sys/dev/pci/ixgbe/ixgbe_82598.h \
     src/sys/dev/pci/ixgbe/ixgbe_x540.c src/sys/dev/pci/ixgbe/ixv.c
 cvs rdiff -u -r1.3.2.2 -r1.3.2.3 src/sys/dev/pci/ixgbe/ixgbe_82599.c
 cvs rdiff -u -r1.1.4.2 -r1.1.4.3 src/sys/dev/pci/ixgbe/ixgbe_82599.h \
     src/sys/dev/pci/ixgbe/ixgbe_x540.h
 cvs rdiff -u -r1.2.2.2 -r1.2.2.3 src/sys/dev/pci/ixgbe/ixgbe_api.c \
     src/sys/dev/pci/ixgbe/ixgbe_type.h
 cvs rdiff -u -r1.2.2.1 -r1.2.2.2 src/sys/dev/pci/ixgbe/ixgbe_common.c \
     src/sys/dev/pci/ixgbe/ixgbe_phy.c
 cvs rdiff -u -r1.2 -r1.2.2.1 src/sys/dev/pci/ixgbe/ixgbe_netbsd.h
 cvs rdiff -u -r1.3.4.1 -r1.3.4.2 src/sys/dev/pci/ixgbe/ixgbe_osdep.h
 cvs rdiff -u -r1.1.28.2 -r1.1.28.3 src/sys/dev/pci/ixgbe/ixgbe_vf.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sun, 10 May 2015 18:41:46 +0000
State-Changed-Why:
fixed, thanks


>Unformatted:

Home	PR Database Search