NetBSD Problem Report #49980

From www@NetBSD.org  Tue Jun 16 16:40:39 2015
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 5A74FA6551
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 16 Jun 2015 16:40:39 +0000 (UTC)
Message-Id: <20150616164038.1294DA65BB@mollari.NetBSD.org>
Date: Tue, 16 Jun 2015 16:40:38 +0000 (UTC)
From: ishit@oak.dti.ne.jp
Reply-To: ishit@oak.dti.ne.jp
To: gnats-bugs@NetBSD.org
Subject: fix uninitialized value errr pkgtools/url2pkg-2.22
X-Send-Pr-Version: www-1.0

>Number:         49980
>Category:       pkg
>Synopsis:       fix uninitialized value errr pkgtools/url2pkg-2.22
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Jun 16 16:45:00 +0000 2015
>Closed-Date:    Wed Jun 17 12:00:25 +0000 2015
>Last-Modified:  Wed Jun 17 12:05:00 +0000 2015
>Originator:     ISIHARA Takanori
>Release:        pkgsrc-current 2015/6/16
>Organization:
Nagoya *BSD Users' Group :-)
>Environment:
NetBSD ishitPc14.home 7.0_BETA NetBSD 7.0_BETA (ISHITPC14) #9: Sun Jun  7 11:04:51 JST 2015  sysbuild@ishitPc14.home:/opt/sysbuild/netbsd-7/obj/amd64/sys/arch/amd64/compile/ISHITPC14 amd64

>Description:
I fixed uninitialized value error.

>How-To-Repeat:
run url2pkg.

for example:
% url2pkg http://jnovy.fedorapeople.org/pxz/pxz-4.999.9beta.20091201git.tar.xz 2>aaaa
<snip>
% head -3 aaaa
Use of uninitialized value $gh_project in string ne at /usr/pkg/bin/url2pkg line 365, <SITES> line 331.
Use of uninitialized value $gh_release in string ne at /usr/pkg/bin/url2pkg line 365, <SITES> line 331.
Use of uninitialized value $dist_subdir in string ne at /usr/pkg/bin/url2pkg line 365, <SITES> line 331.

>Fix:
apply patch, please.

Index: url2pkg.pl
===================================================================
RCS file: /cvsroot/pkgsrc/pkgtools/url2pkg/files/url2pkg.pl,v
retrieving revision 1.28
diff -u -u -r1.28 url2pkg.pl
--- url2pkg.pl	7 Apr 2015 00:10:33 -0000	1.28
+++ url2pkg.pl	16 Jun 2015 16:19:48 -0000
@@ -333,6 +333,8 @@
 			} else {
 				die("$0: ERROR: Invalid GitHub URL: ${url}\n");
 			}
+		} else {
+			$gh_project = ""; $gh_release = ""; $dist_subdir = "";
 		}
 	}


>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Wed, 17 Jun 2015 12:00:25 +0000
State-Changed-Why:
Committed, thanks.


From: "Thomas Klausner" <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49980 CVS commit: pkgsrc/pkgtools/url2pkg
Date: Wed, 17 Jun 2015 11:59:59 +0000

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Wed Jun 17 11:59:58 UTC 2015

 Modified Files:
 	pkgsrc/pkgtools/url2pkg: Makefile
 	pkgsrc/pkgtools/url2pkg/files: url2pkg.pl

 Log Message:
 Fix uninitialized variables warnings.
 From ISIHARA Takanori in PR 49980.


 To generate a diff of this commit:
 cvs rdiff -u -r1.78 -r1.79 pkgsrc/pkgtools/url2pkg/Makefile
 cvs rdiff -u -r1.28 -r1.29 pkgsrc/pkgtools/url2pkg/files/url2pkg.pl

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.