NetBSD Problem Report #50178

From www@NetBSD.org  Wed Aug 26 17:56:05 2015
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 1B861A5B2E
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 26 Aug 2015 17:56:05 +0000 (UTC)
Message-Id: <20150826175602.A5B33A6554@mollari.NetBSD.org>
Date: Wed, 26 Aug 2015 17:56:02 +0000 (UTC)
From: nonakap@gmail.com
Reply-To: nonakap@gmail.com
To: gnats-bugs@NetBSD.org
Subject: www/gitweb: gitweb.js is not generate
X-Send-Pr-Version: www-1.0

>Number:         50178
>Category:       pkg
>Synopsis:       www/gitweb: gitweb.js is not generate
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    ryoon
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Aug 26 18:00:00 +0000 2015
>Closed-Date:    Sun Aug 30 10:56:56 +0000 2015
>Last-Modified:  Sun Aug 30 10:56:56 +0000 2015
>Originator:     NONAKA Kimihiro
>Release:        pkgsrc-HEAD 20150826
>Organization:
>Environment:
NetBSD koharu.myhome.nonakap.org 7.99.21 NetBSD 7.99.21 (KOHARU) #3180: Wed Aug 26 00:09:27 JST 2015  nonaka@koharu.myhome.nonakap.org:/home/snapshot/NetBSD/20150822/obj.NetBSD-amd64/amd64/sys/arch/amd64/compile/KOHARU amd64
>Description:
gitweb.js is required by gitweb.cgi.
But gitweb.js is not generate and install.
>How-To-Repeat:
1) cd pkgsrc/www/gitweb && make install.
2) See /usr/pkg/libexec/cgi-bin/gitweb.cgi.

> # URI of gitweb.js (JavaScript code for gitweb)
> our $javascript = "static/gitweb.js";
>Fix:
Please apply the following patch.

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/www/gitweb/Makefile,v
retrieving revision 1.30
diff -u -r1.30 Makefile
--- Makefile	31 Jul 2015 12:57:23 -0000	1.30
+++ Makefile	26 Aug 2015 07:55:12 -0000
@@ -15,13 +15,14 @@
 USE_TOOLS+=	perl:run

 BUILD_DIRS=	gitweb
-BUILD_TARGET=	gitweb.cgi
+BUILD_TARGET=	gitweb.cgi static/gitweb.js
 MAKE_FLAGS=	prefix=${PREFIX}
 MAKE_FLAGS+=	GITWEB_FAVICON=/gitweb/git-favicon.png
 MAKE_FLAGS+=	GITWEB_CONFIG=${GITWEB_CONFIG}
 MAKE_FLAGS+=	GITWEB_CSS=/gitweb/gitweb.css
 MAKE_FLAGS+=	GITWEB_HOMETEXT=${GITWEB_HTDOCS}/indextext.html
 MAKE_FLAGS+=	GITWEB_LOGO=/gitweb/git-logo.png
+MAKE_FLAGS+=	GITWEB_JS=/gitweb/gitweb.js
 MAKE_FLAGS+=	PERL_PATH=${PERL5:Q}

 GITWEB_CONFIG=	${PKG_SYSCONFDIR}/gitweb.conf
@@ -38,7 +39,7 @@

 do-install:
 	${INSTALL_SCRIPT} ${WRKSRC}/gitweb/gitweb.cgi ${DESTDIR}${GITWEB_CGIBIN}
-.for f in git-favicon.png git-logo.png gitweb.css
+.for f in git-favicon.png git-logo.png gitweb.css gitweb.js
 	${INSTALL_DATA} ${WRKSRC}/gitweb/static/${f} ${DESTDIR}${GITWEB_HTDOCS}
 .endfor
 	${INSTALL_DATA} ${WRKSRC}/gitweb/README \
Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/www/gitweb/PLIST,v
retrieving revision 1.3
diff -u -r1.3 PLIST
--- PLIST	5 Mar 2010 16:12:07 -0000	1.3
+++ PLIST	26 Aug 2015 07:55:12 -0000
@@ -5,3 +5,4 @@
 share/examples/gitweb/htdocs/git-favicon.png
 share/examples/gitweb/htdocs/git-logo.png
 share/examples/gitweb/htdocs/gitweb.css
+share/examples/gitweb/htdocs/gitweb.js

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->ryoon
Responsible-Changed-By: ryoon@NetBSD.org
Responsible-Changed-When: Sun, 30 Aug 2015 06:55:17 +0000
Responsible-Changed-Why:
Take it.


From: "Ryo ONODERA" <ryoon@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50178 CVS commit: pkgsrc/www/gitweb
Date: Sun, 30 Aug 2015 06:56:19 +0000

 Module Name:	pkgsrc
 Committed By:	ryoon
 Date:		Sun Aug 30 06:56:19 UTC 2015

 Modified Files:
 	pkgsrc/www/gitweb: Makefile PLIST

 Log Message:
 Bump PKGREVISION

 * Generate gitweb.js and install it.
   Fix PR pkg/50178.


 To generate a diff of this commit:
 cvs rdiff -u -r1.30 -r1.31 pkgsrc/www/gitweb/Makefile
 cvs rdiff -u -r1.3 -r1.4 pkgsrc/www/gitweb/PLIST

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: ryoon@NetBSD.org
State-Changed-When: Sun, 30 Aug 2015 10:56:56 +0000
State-Changed-Why:
Patch is applied.
Thank you.


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.