NetBSD Problem Report #50426

From dtyson@t400.anduin.org.uk  Fri Nov 13 20:14:12 2015
Return-Path: <dtyson@t400.anduin.org.uk>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id B0B04A64EF
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 13 Nov 2015 20:14:12 +0000 (UTC)
Message-Id: <20151113201410.044BB4C3AA@t400.anduin.org.uk>
Date: Fri, 13 Nov 2015 20:14:09 +0000 (GMT)
From: dtyson@anduin.org.uk
Reply-To: dtyson@anduin.org.uk
To: gnats-bugs@NetBSD.org
Subject: Latest ntpd reports wrong version (with fix) 
X-Send-Pr-Version: 3.95

>Number:         50426
>Category:       kern
>Synopsis:       latest version of ntp mis-reports version as 4.2.8p3 rather than 4.4.8p4
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Nov 13 20:15:00 +0000 2015
>Closed-Date:    Fri Nov 13 22:15:02 +0000 2015
>Last-Modified:  Tue Nov 17 19:10:07 +0000 2015
>Originator:     Dave Tyson
>Release:        NetBSD 7.99.21
>Organization:
	Anduin
>Environment:


System: NetBSD t400.anduin.org.uk 7.99.21 NetBSD 7.99.21 (GENERIC) #0: Fri Nov 13 12:31:06 GMT 2015 root@t400.anduin.org.uk:/usr/obj/sys/arch/amd64/compile/GENERIC amd64
Architecture: x86_64
Machine: amd64
>Description:
After doing a make release followed by make install it was noticed that ntpd reported the version to be ntpd 4.2.8p3-o Fri Oct 23 13:57:19 EDT 2015 (import)
which didn't agree with the changes in /usr/src/doc/CHANGES. A look at the build process files showed that the script file mkver had not been updated and so the wrong version
string was compiled into the binary.
>How-To-Repeat:
Update to latest current, do a make release (or just build ntp). invoke the new ntp and note it reports the wrong version on startup or if invoked with
ntpd --version
>Fix:
Apply the following patch:

--- /usr/src/external/bsd/ntp/scripts/mkver.orig        2015-10-06 23:31:07.000000000 +0100
+++ /usr/src/external/bsd/ntp/scripts/mkver     2015-11-13 16:50:06.000000000 +0000
@@ -3,7 +3,7 @@

 ConfStr="$PROG"

-ConfStr="$ConfStr 4.2.8p3"
+ConfStr="$ConfStr 4.2.8p4"

 case "$CSET" in
  '') ;;


Rebuild ntp. This fix will also need pullup requests to NetBSD-7 and NetBSD-6


>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50426 CVS commit: src/external/bsd/ntp/scripts
Date: Fri, 13 Nov 2015 15:31:28 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Fri Nov 13 20:31:28 UTC 2015

 Modified Files:
 	src/external/bsd/ntp/scripts: mkver

 Log Message:
 PR/50426: Dave Tyson: Fix ntp reported version.


 To generate a diff of this commit:
 cvs rdiff -u -r1.7 -r1.8 src/external/bsd/ntp/scripts/mkver

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Fri, 13 Nov 2015 22:15:02 +0000
State-Changed-Why:
christos fixed it. Thanks!


From: "Manuel Bouyer" <bouyer@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50426 CVS commit: [netbsd-6] src/external/bsd/ntp/scripts
Date: Sun, 15 Nov 2015 16:16:53 +0000

 Module Name:	src
 Committed By:	bouyer
 Date:		Sun Nov 15 16:16:53 UTC 2015

 Modified Files:
 	src/external/bsd/ntp/scripts [netbsd-6]: mkver

 Log Message:
 Pull up following revision(s) (requested by christos in ticket #1346):
 	external/bsd/ntp/scripts/mkver: revision 1.8
 PR/50426: Dave Tyson: Fix ntp reported version.


 To generate a diff of this commit:
 cvs rdiff -u -r1.2.2.2 -r1.2.2.3 src/external/bsd/ntp/scripts/mkver

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Manuel Bouyer" <bouyer@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50426 CVS commit: [netbsd-6-0] src/external/bsd/ntp/scripts
Date: Sun, 15 Nov 2015 16:17:00 +0000

 Module Name:	src
 Committed By:	bouyer
 Date:		Sun Nov 15 16:17:00 UTC 2015

 Modified Files:
 	src/external/bsd/ntp/scripts [netbsd-6-0]: mkver

 Log Message:
 Pull up following revision(s) (requested by christos in ticket #1346):
 	external/bsd/ntp/scripts/mkver: revision 1.8
 PR/50426: Dave Tyson: Fix ntp reported version.


 To generate a diff of this commit:
 cvs rdiff -u -r1.2.8.2 -r1.2.8.3 src/external/bsd/ntp/scripts/mkver

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Manuel Bouyer" <bouyer@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50426 CVS commit: [netbsd-6-1] src/external/bsd/ntp/scripts
Date: Sun, 15 Nov 2015 16:17:03 +0000

 Module Name:	src
 Committed By:	bouyer
 Date:		Sun Nov 15 16:17:03 UTC 2015

 Modified Files:
 	src/external/bsd/ntp/scripts [netbsd-6-1]: mkver

 Log Message:
 Pull up following revision(s) (requested by christos in ticket #1346):
 	external/bsd/ntp/scripts/mkver: revision 1.8
 PR/50426: Dave Tyson: Fix ntp reported version.


 To generate a diff of this commit:
 cvs rdiff -u -r1.2.16.2 -r1.2.16.3 src/external/bsd/ntp/scripts/mkver

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Jeff Rizzo" <riz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50426 CVS commit: [netbsd-7] src/external/bsd/ntp/scripts
Date: Tue, 17 Nov 2015 19:09:08 +0000

 Module Name:	src
 Committed By:	riz
 Date:		Tue Nov 17 19:09:08 UTC 2015

 Modified Files:
 	src/external/bsd/ntp/scripts [netbsd-7]: mkver

 Log Message:
 Pull up following revision(s) (requested by christos in ticket #1036):
 	external/bsd/ntp/scripts/mkver: revision 1.8
 PR/50426: Dave Tyson: Fix ntp reported version.


 To generate a diff of this commit:
 cvs rdiff -u -r1.4.4.3 -r1.4.4.4 src/external/bsd/ntp/scripts/mkver

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Jeff Rizzo" <riz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50426 CVS commit: [netbsd-7-0] src/external/bsd/ntp/scripts
Date: Tue, 17 Nov 2015 19:09:22 +0000

 Module Name:	src
 Committed By:	riz
 Date:		Tue Nov 17 19:09:22 UTC 2015

 Modified Files:
 	src/external/bsd/ntp/scripts [netbsd-7-0]: mkver

 Log Message:
 Pull up following revision(s) (requested by christos in ticket #1036):
 	external/bsd/ntp/scripts/mkver: revision 1.8
 PR/50426: Dave Tyson: Fix ntp reported version.


 To generate a diff of this commit:
 cvs rdiff -u -r1.4.4.2.2.1 -r1.4.4.2.2.2 src/external/bsd/ntp/scripts/mkver

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search