NetBSD Problem Report #50483

From dholland@netbsd.org  Fri Nov 27 19:35:22 2015
Return-Path: <dholland@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 1D7BAA64EF
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 27 Nov 2015 19:35:22 +0000 (UTC)
Message-Id: <20151127193521.DA17A14A2E1@mail.netbsd.org>
Date: Fri, 27 Nov 2015 19:35:21 +0000 (UTC)
From: dholland@netbsd.org
Reply-To: dholland@netbsd.org
To: gnats-bugs@gnats.NetBSD.org
Subject: assym.h is not rebuilt
X-Send-Pr-Version: 3.95

>Number:         50483
>Category:       kern
>Synopsis:       assym.h is not rebuilt
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Nov 27 19:40:00 +0000 2015
>Closed-Date:    Sat Nov 28 22:53:17 +0000 2015
>Last-Modified:  Sat Nov 28 22:53:17 +0000 2015
>Originator:     David A. Holland
>Release:        NetBSD 7.99.21 (20151118)
>Organization:
>Environment:
System: NetBSD valkyrie 7.99.1 NetBSD 7.99.1 (VALKYRIE) #17: Wed Oct 14 03:21:03 EDT 2015  dholland@valkyrie:/usr/src/sys/arch/amd64/compile/VALKYRIE amd64
Architecture: x86_64
Machine: amd64
>Description:

assym.h doesn't depend on the header files it's derived from. This
results in out of date info and crashes in locore if core data
structures are changed.

Might be specific to amd64 but I assume most of the logic involved is
MI.

I doubt this has been true forever so it was probably caused by some
of the recent config and kernel build rototilling.

>How-To-Repeat:

valkyrie% touch ../../../../sys/proc.h 
valkyrie% make assym.h
`assym.h' is up to date.
valkyrie% 

>Fix:

>Release-Note:

>Audit-Trail:
From: Frank Zerangue <frank.zerangue@gmail.com>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: kern/50483: assym.h is not rebuilt
Date: Fri, 27 Nov 2015 13:51:49 -0600

 > Might be specific to amd64 but I assume most of the logic involved is
 > MI.


 I found it to be true for arm/imx31 as well.

 Frank Zerangue

 > On Nov 27, 2015, at 1:40 PM, dholland@NetBSD.org wrote:
 >=20
 >> Number:         50483
 >> Category:       kern
 >> Synopsis:       assym.h is not rebuilt
 >> Confidential:   no
 >> Severity:       critical
 >> Priority:       high
 >> Responsible:    kern-bug-people
 >> State:          open
 >> Class:          sw-bug
 >> Submitter-Id:   net
 >> Arrival-Date:   Fri Nov 27 19:40:00 +0000 2015
 >> Originator:     David A. Holland
 >> Release:        NetBSD 7.99.21 (20151118)
 >> Organization:
 >> Environment:
 > System: NetBSD valkyrie 7.99.1 NetBSD 7.99.1 (VALKYRIE) #17: Wed Oct =
 14 03:21:03 EDT 2015  =
 dholland@valkyrie:/usr/src/sys/arch/amd64/compile/VALKYRIE amd64
 > Architecture: x86_64
 > Machine: amd64
 >> Description:
 >=20
 > assym.h doesn't depend on the header files it's derived from. This
 > results in out of date info and crashes in locore if core data
 > structures are changed.
 >=20
 > Might be specific to amd64 but I assume most of the logic involved is
 > MI.
 >=20
 > I doubt this has been true forever so it was probably caused by some
 > of the recent config and kernel build rototilling.
 >=20
 >> How-To-Repeat:
 >=20
 > valkyrie% touch ../../../../sys/proc.h=20
 > valkyrie% make assym.h
 > `assym.h' is up to date.
 > valkyrie%=20
 >=20
 >> Fix:
 >=20

From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50483 CVS commit: src/sys/conf
Date: Fri, 27 Nov 2015 15:33:56 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Fri Nov 27 20:33:55 UTC 2015

 Modified Files:
 	src/sys/conf: Makefile.kern.inc

 Log Message:
 PR/50483: David A. Holland: fix building of assym.d:

 	1. use += to add to DEPS
 	2. move inclusion of rules mk. files before the rules are defined
 	   so that variables are set.

 Now we get on amd64:

 	mkdep: ignoring acpi_wakeup_low.d: No such file or directory
 	mkdep: ignoring amd64func.d: No such file or directory
 	mkdep: ignoring busfunc.d: No such file or directory
 	mkdep: ignoring copy.d: No such file or directory
 	mkdep: ignoring cpu_in_cksum.d: No such file or directory
 	mkdep: ignoring cpufunc.d: No such file or directory

 because there are no rules to generate those, but it is harmless.


 To generate a diff of this commit:
 cvs rdiff -u -r1.247 -r1.248 src/sys/conf/Makefile.kern.inc

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Masao Uebayashi <uebayasi@gmail.com>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: kern/50483: assym.h is not rebuilt
Date: Sat, 28 Nov 2015 11:23:49 +0900

 My regression, my bad.

 I wanted to make DEPS symmetric with SRCS.  I seem to have made a
 mistake because of that.

 I would fix this by making 'assym.d' be always built
 (s/^assym.d:/assym.d!/ in sys/conf/assym.mk).

 *

 I can also point out that touching a *.h doesn't cause all other
 indirect *.d to be regenerated, even on source before my rototill:

 echo '#include <sys/foo.h>' >>sys/conf/param.c
 echo '#include <sys/bar.h>' >sys/sys/foo.h
 touch sys/sys/bar.h
 (build kernel)
 touch sys/sys/bar.h
 (build kernel)

 => is param.d rebuilt?
 => is kernel rebuilt?

 The easiest fix would be to make all *.d generation rule be always
 built (s/xxx.d:/xxx.d!/) too.

 On Sat, Nov 28, 2015 at 4:40 AM,  <dholland@netbsd.org> wrote:
 >>Number:         50483
 >>Category:       kern
 >>Synopsis:       assym.h is not rebuilt
 >>Confidential:   no
 >>Severity:       critical
 >>Priority:       high
 >>Responsible:    kern-bug-people
 >>State:          open
 >>Class:          sw-bug
 >>Submitter-Id:   net
 >>Arrival-Date:   Fri Nov 27 19:40:00 +0000 2015
 >>Originator:     David A. Holland
 >>Release:        NetBSD 7.99.21 (20151118)
 >>Organization:
 >>Environment:
 > System: NetBSD valkyrie 7.99.1 NetBSD 7.99.1 (VALKYRIE) #17: Wed Oct 14 03:21:03 EDT 2015  dholland@valkyrie:/usr/src/sys/arch/amd64/compile/VALKYRIE amd64
 > Architecture: x86_64
 > Machine: amd64
 >>Description:
 >
 > assym.h doesn't depend on the header files it's derived from. This
 > results in out of date info and crashes in locore if core data
 > structures are changed.
 >
 > Might be specific to amd64 but I assume most of the logic involved is
 > MI.
 >
 > I doubt this has been true forever so it was probably caused by some
 > of the recent config and kernel build rototilling.
 >
 >>How-To-Repeat:
 >
 > valkyrie% touch ../../../../sys/proc.h
 > valkyrie% make assym.h
 > `assym.h' is up to date.
 > valkyrie%
 >
 >>Fix:
 >

From: christos@zoulas.com (Christos Zoulas)
To: gnats-bugs@NetBSD.org, kern-bug-people@netbsd.org, 
	gnats-admin@netbsd.org, netbsd-bugs@netbsd.org, dholland@netbsd.org
Cc: 
Subject: Re: kern/50483: assym.h is not rebuilt
Date: Fri, 27 Nov 2015 21:30:09 -0500

 On Nov 28,  2:25am, uebayasi@gmail.com (Masao Uebayashi) wrote:
 -- Subject: Re: kern/50483: assym.h is not rebuilt

 |  My regression, my bad.
 |  
 |  I wanted to make DEPS symmetric with SRCS.  I seem to have made a
 |  mistake because of that.
 |  
 |  I would fix this by making 'assym.d' be always built
 |  (s/^assym.d:/assym.d!/ in sys/conf/assym.mk).
 |  
 |  *
 |  
 |  I can also point out that touching a *.h doesn't cause all other
 |  indirect *.d to be regenerated, even on source before my rototill:
 |  
 |  echo '#include <sys/foo.h>' >>sys/conf/param.c
 |  echo '#include <sys/bar.h>' >sys/sys/foo.h
 |  touch sys/sys/bar.h
 |  (build kernel)
 |  touch sys/sys/bar.h
 |  (build kernel)

 I fixed it already.

 christos

From: Masao Uebayashi <uebayasi@gmail.com>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: kern/50483: assym.h is not rebuilt
Date: Sat, 28 Nov 2015 12:43:14 +0900

 Ah.  Thanks.

 BTW, the same bug (rebuilding *.d) exists in lib/libc too.

 On Sat, Nov 28, 2015 at 11:30 AM, Christos Zoulas <christos@zoulas.com> wrote:
 > On Nov 28,  2:25am, uebayasi@gmail.com (Masao Uebayashi) wrote:
 > -- Subject: Re: kern/50483: assym.h is not rebuilt
 >
 > |  My regression, my bad.
 > |
 > |  I wanted to make DEPS symmetric with SRCS.  I seem to have made a
 > |  mistake because of that.
 > |
 > |  I would fix this by making 'assym.d' be always built
 > |  (s/^assym.d:/assym.d!/ in sys/conf/assym.mk).
 > |
 > |  *
 > |
 > |  I can also point out that touching a *.h doesn't cause all other
 > |  indirect *.d to be regenerated, even on source before my rototill:
 > |
 > |  echo '#include <sys/foo.h>' >>sys/conf/param.c
 > |  echo '#include <sys/bar.h>' >sys/sys/foo.h
 > |  touch sys/sys/bar.h
 > |  (build kernel)
 > |  touch sys/sys/bar.h
 > |  (build kernel)
 >
 > I fixed it already.
 >
 > christos

From: David Holland <dholland-bugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: kern/50483: assym.h is not rebuilt
Date: Sat, 28 Nov 2015 05:21:17 +0000

 On Sat, Nov 28, 2015 at 03:45:01AM +0000, Masao Uebayashi wrote:
  >  BTW, the same bug (rebuilding *.d) exists in lib/libc too.

 *.d doesn't rebuild correctly anywhere in the tree, I'm afraid.

 -- 
 David A. Holland
 dholland@netbsd.org

From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: gnats-bugs@NetBSD.org
Cc: kern-bug-people@netbsd.org, gnats-admin@netbsd.org,
	netbsd-bugs@netbsd.org, dholland@netbsd.org
Subject: Re: kern/50483: assym.h is not rebuilt
Date: Sat, 28 Nov 2015 12:44:21 +0100

 On Sat, Nov 28, 2015 at 05:25:01AM +0000, David Holland wrote:
 > The following reply was made to PR kern/50483; it has been noted by GNATS.
 > 
 > From: David Holland <dholland-bugs@netbsd.org>
 > To: gnats-bugs@NetBSD.org
 > Cc: 
 > Subject: Re: kern/50483: assym.h is not rebuilt
 > Date: Sat, 28 Nov 2015 05:21:17 +0000
 > 
 >  On Sat, Nov 28, 2015 at 03:45:01AM +0000, Masao Uebayashi wrote:
 >   >  BTW, the same bug (rebuilding *.d) exists in lib/libc too.
 >  
 >  *.d doesn't rebuild correctly anywhere in the tree, I'm afraid.

 That's not true. I know at least one component in the tree that handles
 them correctly.

 Joerg

From: christos@zoulas.com (Christos Zoulas)
To: gnats-bugs@NetBSD.org, kern-bug-people@netbsd.org, 
	gnats-admin@netbsd.org, netbsd-bugs@netbsd.org, dholland@netbsd.org
Cc: 
Subject: Re: kern/50483: assym.h is not rebuilt
Date: Sat, 28 Nov 2015 08:08:46 -0500

 On Nov 28,  5:25am, dholland-bugs@netbsd.org (David Holland) wrote:
 -- Subject: Re: kern/50483: assym.h is not rebuilt

 |  *.d doesn't rebuild correctly anywhere in the tree, I'm afraid.

 do you have specific examples?

From: David Holland <dholland-bugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: kern/50483: assym.h is not rebuilt
Date: Sat, 28 Nov 2015 15:12:21 +0000

 On Sat, Nov 28, 2015 at 01:10:02PM +0000, Christos Zoulas wrote:
  >  On Nov 28,  5:25am, dholland-bugs@netbsd.org (David Holland) wrote:
  >  -- Subject: Re: kern/50483: assym.h is not rebuilt
  >  
  >  |  *.d doesn't rebuild correctly anywhere in the tree, I'm afraid.
  >  
  >  do you have specific examples?

 No, it appears my understanding is out of date.

 -- 
 David A. Holland
 dholland@netbsd.org

State-Changed-From-To: open->closed
State-Changed-By: mrg@NetBSD.org
State-Changed-When: Sat, 28 Nov 2015 22:53:17 +0000
State-Changed-Why:
christos fixed it.


>Unformatted:

Home	PR Database Search