NetBSD Problem Report #50688
From www@NetBSD.org Thu Jan 21 17:44:49 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.NetBSD.org [199.233.217.200])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
by mollari.NetBSD.org (Postfix) with ESMTPS id D86137ABE0
for <gnats-bugs@gnats.NetBSD.org>; Thu, 21 Jan 2016 17:44:48 +0000 (UTC)
Message-Id: <20160121174448.0686A7ACC8@mollari.NetBSD.org>
Date: Thu, 21 Jan 2016 17:44:48 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/arch/hpcmips/dev/plumpower.c:119: possible bad bitmask ?
X-Send-Pr-Version: www-1.0
>Number: 50688
>Category: port-hpcmips
>Synopsis: src/sys/arch/hpcmips/dev/plumpower.c:119: possible bad bitmask ?
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: andvar
>State: analyzed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Thu Jan 21 17:45:01 +0000 2016
>Closed-Date:
>Last-Modified: Wed Sep 11 19:25:33 +0000 2024
>Originator: David Binderman
>Release: cvs dated 20160121
>Organization:
>Environment:
>Description:
[src/sys/arch/hpcmips/dev/plumpower.c:119] -> [src/sys/arch/hpcmips/dev/plumpower.c:119]: (style) Same expression on both sides of '|'.
Source code is
plum_conf_write(regt, regh, PLUM_POWER_RESETC_REG,
PLUM_POWER_RESETC_IO5CL1 |
PLUM_POWER_RESETC_IO5CL1);
At a simple level, it might be suitable to remove the duplicate.
Or maybe there is a simple typo:
$ fgrep PLUM_POWER_RESETC_IO5CL src/sys/arch/hpcmips/dev/*.h
src/sys/arch/hpcmips/dev/plumpowerreg.h:#define PLUM_POWER_RESETC_IO5CL1 0x00000002
src/sys/arch/hpcmips/dev/plumpowerreg.h:#define PLUM_POWER_RESETC_IO5CL0 0x00000001
$
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
From: "Andrius Varanavicius" <andvar@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/50688 CVS commit: src/sys/arch/hpcmips/dev
Date: Sat, 7 Sep 2024 14:28:19 +0000
Module Name: src
Committed By: andvar
Date: Sat Sep 7 14:28:19 UTC 2024
Modified Files:
src/sys/arch/hpcmips/dev: plumpower.c
Log Message:
Change duplicate PLUM_POWER_RESETC_IO5CL1 to PLUM_POWER_RESETC_IO5CL0.
I believe it was a typo, since plum_power_ioreset(pc) call states that
it is resetting high/low I/O bus and TC6358TB Technical Data (page 128)
describes the bit to be set for clearing I/O active low device signals.
pullups are likely not necessary, there are no known issues reported.
Reported by David Binderman. PR port-hpcmips/50688
To generate a diff of this commit:
cvs rdiff -u -r1.14 -r1.15 src/sys/arch/hpcmips/dev/plumpower.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Responsible-Changed-From-To: port-hpcmips-maintainer->andvar
Responsible-Changed-By: andvar@NetBSD.org
Responsible-Changed-When: Wed, 11 Sep 2024 19:25:06 +0000
Responsible-Changed-Why:
May have a chance to test on actual hardware before closing, thus changing
to analyzed before closing or creating pullups.
State-Changed-From-To: open->analyzed
State-Changed-By: andvar@NetBSD.org
State-Changed-When: Wed, 11 Sep 2024 19:25:33 +0000
State-Changed-Why:
Committed a potential typo fix.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.47 2022/09/11 19:34:41 kim Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2024
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.