NetBSD Problem Report #50694

From www@NetBSD.org  Fri Jan 22 17:14:54 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.NetBSD.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id EA03C7AC9F
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 22 Jan 2016 17:14:53 +0000 (UTC)
Message-Id: <20160122171453.04AC97ACB3@mollari.NetBSD.org>
Date: Fri, 22 Jan 2016 17:14:53 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/dev/pci/if_alc.c:1421: possible bad bitmask ?
X-Send-Pr-Version: www-1.0

>Number:         50694
>Category:       kern
>Synopsis:       src/sys/dev/pci/if_alc.c:1421: possible bad bitmask ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jan 22 17:15:00 +0000 2016
>Closed-Date:    Tue Jan 26 16:09:05 +0000 2016
>Last-Modified:  Tue Jan 26 16:09:05 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160121
>Organization:
>Environment:
>Description:

[src/sys/dev/pci/if_alc.c:1421] -> [src/sys/dev/pci/if_alc.c:1420]: (style) Same expression on both sides of '|'.

Source code is

    ifp->if_capabilities |= IFCAP_CSUM_IPv4_Tx | IFCAP_CSUM_IPv4_Rx |
                IFCAP_CSUM_TCPv4_Tx | IFCAP_CSUM_TCPv4_Rx |
                IFCAP_CSUM_UDPv4_Tx | IFCAP_CSUM_TCPv4_Rx;

Suggest new code

     ifp->if_capabilities |= IFCAP_CSUM_IPv4_Tx | IFCAP_CSUM_IPv4_Rx |
                IFCAP_CSUM_TCPv4_Tx | IFCAP_CSUM_TCPv4_Rx |
                IFCAP_CSUM_UDPv4_Tx | IFCAP_CSUM_UDPv4_Rx;

>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50694 CVS commit: src/sys/dev/pci
Date: Tue, 26 Jan 2016 11:02:50 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Tue Jan 26 16:02:50 UTC 2016

 Modified Files:
 	src/sys/dev/pci: if_alc.c

 Log Message:
 PR/50694: David Binderman: Fix wrong pasto constant.


 To generate a diff of this commit:
 cvs rdiff -u -r1.17 -r1.18 src/sys/dev/pci/if_alc.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Tue, 26 Jan 2016 16:09:05 +0000
State-Changed-Why:
Christos fixed it, thanks!


>Unformatted:

Home	PR Database Search