NetBSD Problem Report #50738

From www@NetBSD.org  Mon Feb  1 16:43:56 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.NetBSD.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 6E5347A20F
	for <gnats-bugs@gnats.NetBSD.org>; Mon,  1 Feb 2016 16:43:56 +0000 (UTC)
Message-Id: <20160201164355.5BDB97ACC0@mollari.NetBSD.org>
Date: Mon,  1 Feb 2016 16:43:55 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/dev/pci/n8/common/api/n8_pk_ops.c:103: off by one error ?
X-Send-Pr-Version: www-1.0

>Number:         50738
>Category:       kern
>Synopsis:       src/sys/dev/pci/n8/common/api/n8_pk_ops.c:103: off by one error ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Feb 01 16:45:00 +0000 2016
>Closed-Date:    Mon Feb 01 17:56:35 +0000 2016
>Last-Modified:  Mon Feb 01 17:56:35 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160131
>Organization:
>Environment:
>Description:


[src/sys/dev/pci/n8/common/api/n8_pk_ops.c:103]: (style) Array index 'i' is used before limits check.


  while ((in_p->value_p[i] == 0x0) && (i < in_p->lengthBytes))


>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50738 CVS commit: src/sys/dev/pci/n8/common/api
Date: Mon, 1 Feb 2016 12:40:49 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Mon Feb  1 17:40:49 UTC 2016

 Modified Files:
 	src/sys/dev/pci/n8/common/api: n8_pk_ops.c

 Log Message:
 PR/50738: David Binderman: Check bounds before dereferencing.


 To generate a diff of this commit:
 cvs rdiff -u -r1.1 -r1.2 src/sys/dev/pci/n8/common/api/n8_pk_ops.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Mon, 01 Feb 2016 17:56:35 +0000
State-Changed-Why:
Fixed by christos, thanks!


>Unformatted:

Home	PR Database Search