NetBSD Problem Report #50749

From www@NetBSD.org  Tue Feb  2 10:38:17 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.NetBSD.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 8322C7A215
	for <gnats-bugs@gnats.NetBSD.org>; Tue,  2 Feb 2016 10:38:17 +0000 (UTC)
Message-Id: <20160202103816.769D77ACB5@mollari.NetBSD.org>
Date: Tue,  2 Feb 2016 10:38:16 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/dev/dev_verbose.c: 2 * off by one error ?
X-Send-Pr-Version: www-1.0

>Number:         50749
>Category:       kern
>Synopsis:       src/sys/dev/dev_verbose.c: 2 * off by one error ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Feb 02 10:40:00 +0000 2016
>Closed-Date:    Wed Feb 03 08:18:39 +0000 2016
>Last-Modified:  Wed Feb 03 08:18:39 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160131
>Organization:
>Environment:
>Description:

1.

[src/sys/dev/dev_verbose.c:68]: (style) Array index 'n' is used before limits check.

Source code is

        while (vendors[n] != 0 && n < nvendors)
            n++;

2.

[src/sys/dev/dev_verbose.c:89]: (style) Array index 'n' is used before limits check.

Source code is

     while (products[n] != 0 && n < nproducts)

>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50749 CVS commit: src/sys/dev
Date: Wed, 3 Feb 2016 00:29:43 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Wed Feb  3 05:29:43 UTC 2016

 Modified Files:
 	src/sys/dev: dev_verbose.c

 Log Message:
 PR/50749: David Binderman: check bounds before dereference.


 To generate a diff of this commit:
 cvs rdiff -u -r1.1 -r1.2 src/sys/dev/dev_verbose.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Wed, 03 Feb 2016 08:18:39 +0000
State-Changed-Why:
Fixed by christos, thanks!


>Unformatted:

Home	PR Database Search