NetBSD Problem Report #50755
From www@NetBSD.org Wed Feb 3 09:50:57 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.NetBSD.org [199.233.217.200])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
by mollari.NetBSD.org (Postfix) with ESMTPS id 53F917A140
for <gnats-bugs@gnats.NetBSD.org>; Wed, 3 Feb 2016 09:50:57 +0000 (UTC)
Message-Id: <20160203095056.8521A7AC9C@mollari.NetBSD.org>
Date: Wed, 3 Feb 2016 09:50:56 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/arch/arm/omap/omap2430_intr.c:458: array index out of range ?
X-Send-Pr-Version: www-1.0
>Number: 50755
>Category: port-arm
>Synopsis: src/sys/arch/arm/omap/omap2430_intr.c:458: array index out of range ?
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: port-arm-maintainer
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Wed Feb 03 09:55:00 +0000 2016
>Closed-Date: Tue May 31 02:30:31 +0000 2016
>Last-Modified: Tue May 31 02:30:31 +0000 2016
>Originator: David Binderman
>Release: cvs dated 20160203
>Organization:
>Environment:
>Description:
[src/sys/arch/arm/omap/omap2430_intr.c:458]: (error) Array 'intrgroups[7]' accessed at index 7, which is out of bounds.
Source code is
KASSERT((intrgroups[7].ig_pending_irqs & intrgroups[7].ig_irqsbyipl[ipl]) == 0);
but
[6].ig_sources[ 0 ... 31 ].is_group = 6,
#ifdef OMAP_2430
[7].ig_sources[ 0 ... 31 ].is_group = 7,
#endif
Suggest the KASSERT needs to go into a #ifdef OMAP_2430 block.
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/50755 CVS commit: src/sys/arch/arm/omap
Date: Tue, 31 May 2016 02:26:00 +0000
Module Name: src
Committed By: dholland
Date: Tue May 31 02:26:00 UTC 2016
Modified Files:
src/sys/arch/arm/omap: omap2430_intr.c
Log Message:
PR 50755 David Binderman: assert about table entries only when they exist.
To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7 src/sys/arch/arm/omap/omap2430_intr.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Tue, 31 May 2016 02:30:31 +0000
State-Changed-Why:
fixed, thanks
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2014
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.