NetBSD Problem Report #50784

From www@NetBSD.org  Mon Feb  8 16:21:05 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.NetBSD.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id D61877A215
	for <gnats-bugs@gnats.NetBSD.org>; Mon,  8 Feb 2016 16:21:04 +0000 (UTC)
Message-Id: <20160208162104.0BDEB7ACB9@mollari.NetBSD.org>
Date: Mon,  8 Feb 2016 16:21:04 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/compat/ndis/subr_ntoskrnl.c:439: possible missing { and } ?
X-Send-Pr-Version: www-1.0

>Number:         50784
>Category:       misc
>Synopsis:       src/sys/compat/ndis/subr_ntoskrnl.c:439: possible missing { and } ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    misc-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Feb 08 16:25:00 +0000 2016
>Closed-Date:    Mon Feb 08 17:23:45 +0000 2016
>Last-Modified:  Mon Feb 08 17:23:45 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160208
>Organization:
>Environment:
>Description:
[src/sys/compat/ndis/subr_ntoskrnl.c:439]: (style) Statements following return, break, continue, goto or throw will never be executed.

Source code is

    while (e != &drv->dro_driverext->dre_usrext) {
        ce = (custom_extension *)e;
        if (ce->ce_clid == clid)
            printf("found\n");
            return((void *)(ce + 1));
        e = e->nle_flink;
    }

Maybe better code

    while (e != &drv->dro_driverext->dre_usrext) {
        ce = (custom_extension *)e;
        if (ce->ce_clid == clid) {
            printf("found\n");
            return((void *)(ce + 1));
        }
        e = e->nle_flink;
    }

>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50784 CVS commit: src/sys/compat/ndis
Date: Mon, 8 Feb 2016 11:42:05 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Mon Feb  8 16:42:04 UTC 2016

 Modified Files:
 	src/sys/compat/ndis: subr_ntoskrnl.c

 Log Message:
 PR/50784: David Binderman: Add missing braces, this is not python.


 To generate a diff of this commit:
 cvs rdiff -u -r1.25 -r1.26 src/sys/compat/ndis/subr_ntoskrnl.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Mon, 08 Feb 2016 17:23:45 +0000
State-Changed-Why:
Fixed by christos, thanks.


>Unformatted:

Home	PR Database Search