NetBSD Problem Report #50786

From www@NetBSD.org  Tue Feb  9 04:21:19 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.NetBSD.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id D8E377A220
	for <gnats-bugs@gnats.NetBSD.org>; Tue,  9 Feb 2016 04:21:18 +0000 (UTC)
Message-Id: <20160209042117.ADFAC7ACC0@mollari.NetBSD.org>
Date: Tue,  9 Feb 2016 04:21:17 +0000 (UTC)
From: Tr@visPaul.me
Reply-To: Tr@visPaul.me
To: gnats-bugs@NetBSD.org
Subject: gpio_set_info function in the sqlite lua module is incorrectly named
X-Send-Pr-Version: www-1.0

>Number:         50786
>Category:       lib
>Synopsis:       gpio_set_info function in the sqlite lua module is incorrectly named
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    lib-bug-people
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Feb 09 04:25:00 +0000 2016
>Closed-Date:    Mon Feb 15 15:57:34 +0000 2016
>Last-Modified:  Mon Feb 15 16:00:01 +0000 2016
>Originator:     Travis Paul
>Release:        current
>Organization:
>Environment:
NetBSD kagato.netverb.com 7.99.26 NetBSD 7.99.26 (kagato) #0: Sun Feb  7 11:33:50 EST 2016  tpaul@kagato.netverb.com:/build/obj/sys/arch/amd64/compile/kagato amd64
>Description:
The gpio_set_info function in the lua sqlite module should be called sqlite_set_info
>How-To-Repeat:
The incorrect name appears to be harmless when running the module.
>Fix:
Index: sqlite.c
===================================================================
RCS file: /cvsroot/src/lib/lua/sqlite/sqlite.c,v
retrieving revision 1.7
diff -u -r1.7 sqlite.c
--- sqlite.c    19 Jul 2014 18:38:34 -0000      1.7
+++ sqlite.c    9 Feb 2016 04:13:43 -0000
@@ -392,7 +392,7 @@
 };

 static void
-gpio_set_info(lua_State *L)
+sqlite_set_info(lua_State *L)
 {
        lua_pushliteral(L, "_COPYRIGHT");
        lua_pushliteral(L, "Copyright (C) 2011, 2012, 2013 by "
@@ -449,7 +449,7 @@
        luaL_newlib(L, sqlite_methods);
        luaL_setfuncs(L, db_methods, 0);
        luaL_setfuncs(L, stmt_methods, 0);
-       gpio_set_info(L);
+       sqlite_set_info(L);

        /* The database connection metatable */
        if (luaL_newmetatable(L, SQLITE_DB_METATABLE)) {

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: mbalmer@NetBSD.org
State-Changed-When: Mon, 15 Feb 2016 15:57:34 +0000
State-Changed-Why:
fixed in -current, thanks!


From: "Marc Balmer" <mbalmer@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50786 CVS commit: src/lib/lua/sqlite
Date: Mon, 15 Feb 2016 15:56:33 +0000

 Module Name:	src
 Committed By:	mbalmer
 Date:		Mon Feb 15 15:56:33 UTC 2016

 Modified Files:
 	src/lib/lua/sqlite: sqlite.c

 Log Message:
 Fix function name, no functional change.
 Found by Travis Paul, (see PR/50786), thanks for reporting!


 To generate a diff of this commit:
 cvs rdiff -u -r1.7 -r1.8 src/lib/lua/sqlite/sqlite.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search