NetBSD Problem Report #50855

From www@NetBSD.org  Fri Feb 26 17:21:18 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.NetBSD.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 4FF987ACCE
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 26 Feb 2016 17:21:18 +0000 (UTC)
Message-Id: <20160226172117.7B47D7ACD9@mollari.NetBSD.org>
Date: Fri, 26 Feb 2016 17:21:17 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/arch/arc/isa/isadma_bounce.c: 2 * redundant conditions
X-Send-Pr-Version: www-1.0

>Number:         50855
>Category:       port-arc
>Synopsis:       src/sys/arch/arc/isa/isadma_bounce.c: 2 * redundant conditions
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-arc-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Feb 26 17:25:00 +0000 2016
>Closed-Date:    Fri Feb 26 23:37:49 +0000 2016
>Last-Modified:  Fri Feb 26 23:37:49 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160226
>Organization:
>Environment:
>Description:
1.

[src/sys/arch/arc/isa/isadma_bounce.c:254]: (style) Redundant condition: error!=0. 'error==0 || (error!=0 && (cookie.id_flags&1)==0)' is equivalent to 'error==0 || (cookie.id_flags&1)==0'

Source code is

    if (error == 0 ||
        (error != 0 && (cookie->id_flags & ID_MIGHT_NEED_BOUNCE) == 0))

2.

[src/sys/arch/arc/isa/isadma_bounce.c:324]: (style) Redundant condition: error!=0. 'error==0 || (error!=0 && (cookie.id_flags&1)==0)' is equivalent to 'error==0 || (cookie.id_flags&1)==0'

Source code is

    if (error == 0 ||
        (error != 0 && (cookie->id_flags & ID_MIGHT_NEED_BOUNCE) == 0))

>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50855 CVS commit: src/sys/arch/arc/isa
Date: Fri, 26 Feb 2016 13:14:38 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Fri Feb 26 18:14:38 UTC 2016

 Modified Files:
 	src/sys/arch/arc/isa: isadma_bounce.c

 Log Message:
 PR/50855: David Binderman: Remove redundant code.


 To generate a diff of this commit:
 cvs rdiff -u -r1.14 -r1.15 src/sys/arch/arc/isa/isadma_bounce.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Fri, 26 Feb 2016 23:37:49 +0000
State-Changed-Why:
Christos fixed it, thanks.


>Unformatted:

Home	PR Database Search