NetBSD Problem Report #50874
From www@NetBSD.org Mon Feb 29 17:48:41 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
by mollari.NetBSD.org (Postfix) with ESMTPS id F2DEB7ACA2
for <gnats-bugs@gnats.NetBSD.org>; Mon, 29 Feb 2016 17:48:40 +0000 (UTC)
Message-Id: <20160229174840.288937ACBB@mollari.NetBSD.org>
Date: Mon, 29 Feb 2016 17:48:40 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/dev/pci/n8/common/n8_SKSManager.c:139: pointless test ?
X-Send-Pr-Version: www-1.0
>Number: 50874
>Category: kern
>Synopsis: src/sys/dev/pci/n8/common/n8_SKSManager.c:139: pointless test ?
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: kern-bug-people
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Mon Feb 29 17:50:00 +0000 2016
>Closed-Date: Mon Feb 29 20:40:49 +0000 2016
>Last-Modified: Mon Feb 29 20:40:49 +0000 2016
>Originator: David Binderman
>Release: cvs dated 20160229
>Organization:
>Environment:
>Description:
src/sys/dev/pci/n8/common/n8_SKSManager.c:139]: (style) Checking if unsigned variable 'targetSKS' is less than zero.
Source code is
if ((targetSKS < 0) || (targetSKS >= NSPcount_g))
but
N8_Status_t n8_SKSWrite(const unsigned int targetSKS,
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/50874 CVS commit: src/sys/dev/pci/n8/common
Date: Mon, 29 Feb 2016 13:18:04 -0500
Module Name: src
Committed By: christos
Date: Mon Feb 29 18:18:04 UTC 2016
Modified Files:
src/sys/dev/pci/n8/common: n8_SKSManager.c
Log Message:
PR/50874: David Binderman: unsigned can't be negative
To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/sys/dev/pci/n8/common/n8_SKSManager.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Mon, 29 Feb 2016 20:40:49 +0000
State-Changed-Why:
Fixed by christos, thanks.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2014
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.