NetBSD Problem Report #50880

From www@NetBSD.org  Wed Mar  2 17:53:49 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 521B07A21B
	for <gnats-bugs@gnats.NetBSD.org>; Wed,  2 Mar 2016 17:53:49 +0000 (UTC)
Message-Id: <20160302175348.75C307ACC8@mollari.NetBSD.org>
Date: Wed,  2 Mar 2016 17:53:48 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/lib/libedit/terminal.c: two small problems 
X-Send-Pr-Version: www-1.0

>Number:         50880
>Category:       lib
>Synopsis:       src/lib/libedit/terminal.c: two small problems
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    lib-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Mar 02 17:55:00 +0000 2016
>Closed-Date:    Wed Mar 02 20:00:43 +0000 2016
>Last-Modified:  Wed Mar 02 20:00:43 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160302
>Organization:
>Environment:
>Description:
[src/lib/libedit/terminal.c:381]: (style) Redundant condition: If 'EXPR != 0', the comparison 'EXPR != 0' is always true.

Source code is

        if (*tmp != NULL && *tmp != '\0' && *tmp != *str) {

Also,

[src/lib/libedit/terminal.c:668]: (warning) %d in format string (no. 2) requires 'int' but the argument type is 'size_t {aka unsigned long}'.

Source code is

        (void) fprintf(el->el_errfile,
            "%s: n is ridiculous: %d\r\n", __func__, n);

>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50880 CVS commit: src/lib/libedit
Date: Wed, 2 Mar 2016 14:24:20 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Wed Mar  2 19:24:20 UTC 2016

 Modified Files:
 	src/lib/libedit: Makefile chartype.h common.c read.c refresh.c
 	    terminal.c vi.c

 Log Message:
 PR/50880: David Binderman: Remove redundant code.
 While here, fix all debugging formats.


 To generate a diff of this commit:
 cvs rdiff -u -r1.55 -r1.56 src/lib/libedit/Makefile
 cvs rdiff -u -r1.23 -r1.24 src/lib/libedit/chartype.h
 cvs rdiff -u -r1.39 -r1.40 src/lib/libedit/common.c
 cvs rdiff -u -r1.85 -r1.86 src/lib/libedit/read.c
 cvs rdiff -u -r1.44 -r1.45 src/lib/libedit/refresh.c
 cvs rdiff -u -r1.22 -r1.23 src/lib/libedit/terminal.c
 cvs rdiff -u -r1.54 -r1.55 src/lib/libedit/vi.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Wed, 02 Mar 2016 20:00:43 +0000
State-Changed-Why:
Fixed by christos, thanks.


>Unformatted:

Home	PR Database Search