NetBSD Problem Report #50919

From www@NetBSD.org  Wed Mar  9 10:51:54 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id A084F7ABE6
	for <gnats-bugs@gnats.NetBSD.org>; Wed,  9 Mar 2016 10:51:54 +0000 (UTC)
Message-Id: <20160309105153.85F4C7ABF7@mollari.NetBSD.org>
Date: Wed,  9 Mar 2016 10:51:53 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/lib/libform/type_enum.c:99]: (error) Memory leak: new
X-Send-Pr-Version: www-1.0

>Number:         50919
>Category:       lib
>Synopsis:       src/lib/libform/type_enum.c:99]: (error) Memory leak: new
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    lib-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Mar 09 10:55:00 +0000 2016
>Closed-Date:    Wed Mar 09 20:36:25 +0000 2016
>Last-Modified:  Wed Mar 09 20:36:25 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160308
>Organization:
>Environment:
>Description:
Source code is

        if (_formi_create_dbg_file() != E_OK)
            return NULL;

Suggest add call to free inside the if.

Also, in the same file:

[src/lib/libform/type_enum.c:110]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.
[src/lib/libform/type_enum.c:118]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.
[src/lib/libform/type_enum.c:175]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.
[src/lib/libform/type_enum.c:175]: (warning) %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'.
[src/lib/libform/type_enum.c:190]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.
[src/lib/libform/type_enum.c:190]: (warning) %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'.
[src/lib/libform/type_enum.c:255]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.
[src/lib/libform/type_enum.c:294]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.
[src/lib/libform/type_enum.c:303]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.
[src/lib/libform/type_enum.c:338]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.
[src/lib/libform/type_enum.c:346]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.

>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50919 CVS commit: src/lib/libform
Date: Wed, 9 Mar 2016 14:47:13 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Wed Mar  9 19:47:13 UTC 2016

 Modified Files:
 	src/lib/libform: field.c form.c internals.c internals.h post.c
 	    type_enum.c type_ipv4.c

 Log Message:
 PR/50919: David Binderman: Re-do all the debug stuff in a more sustainable way.


 To generate a diff of this commit:
 cvs rdiff -u -r1.30 -r1.31 src/lib/libform/field.c
 cvs rdiff -u -r1.15 -r1.16 src/lib/libform/form.c
 cvs rdiff -u -r1.37 -r1.38 src/lib/libform/internals.c
 cvs rdiff -u -r1.10 -r1.11 src/lib/libform/internals.h \
     src/lib/libform/type_ipv4.c
 cvs rdiff -u -r1.9 -r1.10 src/lib/libform/post.c
 cvs rdiff -u -r1.11 -r1.12 src/lib/libform/type_enum.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Wed, 09 Mar 2016 20:36:25 +0000
State-Changed-Why:
Fixed by christos, thanks.



>Unformatted:

Home	PR Database Search