NetBSD Problem Report #50920

From www@NetBSD.org  Wed Mar  9 11:02:24 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 6D4DC7ABE5
	for <gnats-bugs@gnats.NetBSD.org>; Wed,  9 Mar 2016 11:02:24 +0000 (UTC)
Message-Id: <20160309110223.677A17ACC3@mollari.NetBSD.org>
Date: Wed,  9 Mar 2016 11:02:23 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sbin/newfs_udf/newfs_udf.c:128]: (error) Memory leak: pos
X-Send-Pr-Version: www-1.0

>Number:         50920
>Category:       bin
>Synopsis:       src/sbin/newfs_udf/newfs_udf.c:128]: (error) Memory leak: pos
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Mar 09 11:05:00 +0000 2016
>Closed-Date:    Wed Mar 09 20:36:36 +0000 2016
>Last-Modified:  Wed Mar 09 20:36:36 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160308
>Organization:
>Environment:
>Description:
Source code is

        pos->sector_data = calloc(1, context.sector_size);
        if (pos->sector_data == NULL)
            return ENOMEM;

Suggest add missing call to free inside the if.



>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50920 CVS commit: src/sbin/newfs_udf
Date: Wed, 9 Mar 2016 14:48:24 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Wed Mar  9 19:48:24 UTC 2016

 Modified Files:
 	src/sbin/newfs_udf: newfs_udf.c

 Log Message:
 PR/50920: David Binderman: fix leak


 To generate a diff of this commit:
 cvs rdiff -u -r1.18 -r1.19 src/sbin/newfs_udf/newfs_udf.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Wed, 09 Mar 2016 20:36:36 +0000
State-Changed-Why:
Fixed by christos, thanks.


>Unformatted:

Home	PR Database Search