NetBSD Problem Report #50928

From www@NetBSD.org  Wed Mar  9 12:45:26 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id EECFE7ABD8
	for <gnats-bugs@gnats.NetBSD.org>; Wed,  9 Mar 2016 12:45:25 +0000 (UTC)
Message-Id: <20160309124525.1FCB37ACA1@mollari.NetBSD.org>
Date: Wed,  9 Mar 2016 12:45:25 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/arch/amiga/dev/sbic.c: 2 * suspicious condition ?
X-Send-Pr-Version: www-1.0

>Number:         50928
>Category:       kern
>Synopsis:       src/sys/arch/amiga/dev/sbic.c: 2 * suspicious condition ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Mar 09 12:50:00 +0000 2016
>Closed-Date:    Wed Mar 09 20:37:32 +0000 2016
>Last-Modified:  Wed Mar 09 20:37:32 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160308
>Organization:
>Environment:
>Description:

1.

Source code is

src/sys/arch/amiga/dev/sbic.c:1999]: (style) Suspicious condition (bitwise operator + comparison); Clarify expression with parentheses.

    while(csr & 0x07 != MESG_OUT_PHASE) {

That could be tidier.

2.

src/sys/arch/amiga/dev/sbic.c:2007]: (style) Suspicious condition (bitwise operator + comparison); Clarify expression with parentheses.

   if( csr & 0x07 != MESG_OUT_PHASE ) {

Also in the same file

[src/sys/arch/amiga/dev/sbic.c:781]: (style) Variable 'asr' is assigned a value that is never used.
[src/sys/arch/amiga/dev/sbic.c:1128]: (style) Variable 'asr' is assigned a value that is never used.
[src/sys/arch/amiga/dev/sbic.c:717]: (style) Consecutive return, break, continue, goto or throw statements are unnecessary.

>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50928 CVS commit: src/sys/arch/amiga/dev
Date: Wed, 9 Mar 2016 15:11:41 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Wed Mar  9 20:11:41 UTC 2016

 Modified Files:
 	src/sys/arch/amiga/dev: sbic.c

 Log Message:
 PR/50928: David Binderman: Clarify precedence with parentheses.


 To generate a diff of this commit:
 cvs rdiff -u -r1.74 -r1.75 src/sys/arch/amiga/dev/sbic.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Wed, 09 Mar 2016 20:37:32 +0000
State-Changed-Why:
Fixed by christos, thanks.


>Unformatted:

Home	PR Database Search