NetBSD Problem Report #50930

From martin@duskware.de  Wed Mar  9 19:34:16 2016
Return-Path: <martin@duskware.de>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 579387A0F3
	for <gnats-bugs@gnats.NetBSD.org>; Wed,  9 Mar 2016 19:34:16 +0000 (UTC)
Date: Wed, 09 Mar 2016 20:34:11 CET
From: martin@NetBSD.org
Reply-To: martin@NetBSD.org
To: gnats-bugs@NetBSD.org
Subject: bogus make test
X-Send-Pr-Version: 3.95

>Number:         50930
>Category:       toolchain
>Synopsis:       bogus make test
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    toolchain-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Mar 09 19:35:00 +0000 2016
>Closed-Date:    Mon May 30 17:07:39 +0000 2016
>Last-Modified:  Mon May 30 17:07:39 +0000 2016
>Originator:     Martin Husemann
>Release:        NetBSD 7.99.26
>Organization:
The NetBSD Foundation, Inc.
>Environment:
System: NetBSD night-owl.duskware.de 7.99.26 NetBSD 7.99.26 (NIGHT-OWL) #391: Thu Feb 25 11:24:27 CET 2016 martin@night-owl.duskware.de:/usr/src/sys/arch/amd64/compile/NIGHT-OWL amd64
Architecture: x86_64
Machine: amd64
>Description:

Building sparc bootblocks issues a warning about Makefile.buildboot:
CFLAGS=         ${${ACTIVE_CC} == "clang":? -Oz -fomit-frame-pointer : -Os } -f$

nbmake: Bad conditional expression ` == "clang"' in  == "clang"? -Oz -fomit-frame-pointer : -Os 


>How-To-Repeat:

cd sys/arch/sparc/stand/boot && $TOOLDIR/bin/nbmake-spard obj

>Fix:

Move include of bsd.own.mk before include of Makefile.buildboot ?

>Release-Note:

>Audit-Trail:
From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50930 CVS commit: src/sys/arch/sparc/stand
Date: Thu, 10 Mar 2016 09:00:24 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Thu Mar 10 09:00:24 UTC 2016

 Modified Files:
 	src/sys/arch/sparc/stand: Makefile.buildboot Makefile.inc

 Log Message:
 Add a few includes of bsd.own.mk to avoid broken test conditions
 on ACTIVE_CC - this might not be the correct fix for PR 50930,
 but it avoids the issue.


 To generate a diff of this commit:
 cvs rdiff -u -r1.30 -r1.31 src/sys/arch/sparc/stand/Makefile.buildboot
 cvs rdiff -u -r1.11 -r1.12 src/sys/arch/sparc/stand/Makefile.inc

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Mon, 30 May 2016 17:07:39 +0000
State-Changed-Why:
fixed (seems like the correct fix to me)


>Unformatted:

Home	PR Database Search