NetBSD Problem Report #50945

From www@NetBSD.org  Fri Mar 11 17:06:37 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id E10337A20E
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 11 Mar 2016 17:06:36 +0000 (UTC)
Message-Id: <20160311170636.15FFD7ACA6@mollari.NetBSD.org>
Date: Fri, 11 Mar 2016 17:06:36 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/arch/sparc64/sparc64/compat_16_machdep.c:291]: (style) Suspicious condition
X-Send-Pr-Version: www-1.0

>Number:         50945
>Category:       port-sparc64
>Synopsis:       src/sys/arch/sparc64/sparc64/compat_16_machdep.c:291]: (style) Suspicious condition
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-sparc64-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Mar 11 17:10:00 +0000 2016
>Closed-Date:    Sat Mar 12 02:19:35 +0000 2016
>Last-Modified:  Sat Mar 12 02:19:35 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160311
>Organization:
>Environment:
>Description:
src/sys/arch/sparc64/sparc64/compat_16_machdep.c:291]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.


Source code is

   if ((vaddr_t)scp & 3 || (error = copyin((void *)scp, &sc, sizeof sc) != 0))

Maybe better code

   if (((vaddr_t) scp & 3) 
      || ((error = copyin((void *)scp, &sc, sizeof sc)) != 0))




>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50945 CVS commit: src/sys/arch/sparc64/sparc64
Date: Fri, 11 Mar 2016 13:31:03 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Fri Mar 11 18:31:03 UTC 2016

 Modified Files:
 	src/sys/arch/sparc64/sparc64: compat_16_machdep.c

 Log Message:
 PR/50945: David Binderman: sprinkle parens


 To generate a diff of this commit:
 cvs rdiff -u -r1.15 -r1.16 src/sys/arch/sparc64/sparc64/compat_16_machdep.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 12 Mar 2016 02:19:35 +0000
State-Changed-Why:
christos committed it


>Unformatted:

Home	PR Database Search