NetBSD Problem Report #50954

From www@NetBSD.org  Fri Mar 11 17:32:38 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 055C87AC07
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 11 Mar 2016 17:32:38 +0000 (UTC)
Message-Id: <20160311173237.29ACB7ACC7@mollari.NetBSD.org>
Date: Fri, 11 Mar 2016 17:32:37 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/usr.sbin/rpc.lockd/test.c:41]: (style) Suspicious condition
X-Send-Pr-Version: www-1.0

>Number:         50954
>Category:       bin
>Synopsis:       src/usr.sbin/rpc.lockd/test.c:41]: (style) Suspicious condition
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Mar 11 17:35:00 +0000 2016
>Closed-Date:    Sat Mar 12 02:09:31 +0000 2016
>Last-Modified:  Sat Mar 12 02:09:31 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160311
>Organization:
>Environment:
>Description:
src/usr.sbin/rpc.lockd/test.c:41]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.


Source code is

   if (st = clnt_call(clnt, NLM_LOCK, xdr_nlm_lockargs, argp, xdr_nlm_res,
        &res, TIMEOUT) != RPC_SUCCESS) {



Maybe better code


   if ((st = clnt_call(clnt, NLM_LOCK, xdr_nlm_lockargs, argp, xdr_nlm_res,
        &res, TIMEOUT)) != RPC_SUCCESS) {












>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50954 CVS commit: src/usr.sbin/rpc.lockd
Date: Sat, 12 Mar 2016 02:01:23 +0000

 Module Name:	src
 Committed By:	dholland
 Date:		Sat Mar 12 02:01:23 UTC 2016

 Modified Files:
 	src/usr.sbin/rpc.lockd: test.c

 Log Message:
 Fix operator precedence in complex conditional by separating out the
 assignment part. PR 50954 from David Binderman. While here, separate
 out the assignment in all the other similar conditionals too.


 To generate a diff of this commit:
 cvs rdiff -u -r1.4 -r1.5 src/usr.sbin/rpc.lockd/test.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 12 Mar 2016 02:09:31 +0000
State-Changed-Why:
I committed it


>Unformatted:

Home	PR Database Search