NetBSD Problem Report #51015

From www@NetBSD.org  Sat Mar 26 15:27:05 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id BE55B7A2AE
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 26 Mar 2016 15:27:05 +0000 (UTC)
Message-Id: <20160326152704.D68F47ABFC@mollari.NetBSD.org>
Date: Sat, 26 Mar 2016 15:27:04 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/arch/ofppc/stand/ofwboot/mbr.c:133: pointless decrement ?
X-Send-Pr-Version: www-1.0

>Number:         51015
>Category:       port-ofppc
>Synopsis:       src/sys/arch/ofppc/stand/ofwboot/mbr.c:133: pointless decrement ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-ofppc-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Mar 26 15:30:00 +0000 2016
>Closed-Date:    Mon Apr 04 09:41:19 +0000 2016
>Last-Modified:  Mon Apr 04 09:41:19 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160326
>Organization:
>Environment:
>Description:
src/sys/arch/ofppc/stand/ofwboot/mbr.c:133]: (style) Assignment of function parameter has no effect outside the function.

Source code is

   recursion--;


Suggest remove.
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51015 CVS commit: src/sys/arch/ofppc/stand/ofwboot
Date: Wed, 30 Mar 2016 17:14:55 -0400

 Module Name:	src
 Committed By:	christos
 Date:		Wed Mar 30 21:14:55 UTC 2016

 Modified Files:
 	src/sys/arch/ofppc/stand/ofwboot: mbr.c

 Log Message:
 PR/51015: David Binderman: remove useless code


 To generate a diff of this commit:
 cvs rdiff -u -r1.4 -r1.5 src/sys/arch/ofppc/stand/ofwboot/mbr.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Mon, 04 Apr 2016 09:41:19 +0000
State-Changed-Why:
Fixed by christos, thanks.


>Unformatted:

Home	PR Database Search