NetBSD Problem Report #51187

From www@NetBSD.org  Mon May 30 06:19:30 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 77A697ABD1
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 30 May 2016 06:19:30 +0000 (UTC)
Message-Id: <20160530061929.99D457ABDD@mollari.NetBSD.org>
Date: Mon, 30 May 2016 06:19:29 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/arch/i386/i386/multiboot.c:596]: (style) Redundant condition
X-Send-Pr-Version: www-1.0

>Number:         51187
>Category:       port-i386
>Synopsis:       src/sys/arch/i386/i386/multiboot.c:596]: (style) Redundant condition
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-i386-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon May 30 06:20:01 +0000 2016
>Closed-Date:    Tue May 31 03:52:25 +0000 2016
>Last-Modified:  Tue May 31 03:52:25 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160529
>Organization:
>Environment:
>Description:
src/sys/arch/i386/i386/multiboot.c:596]: (style) Redundant condition: If 'EXPR == ' '', the comparison 'EXPR != 0' is always true.

Source code is

    while (*cl != '\0' && *cl == ' ')

Suggest new code

    while (*cl == ' ')


Also in the same file

[src/sys/arch/i386/i386/multiboot.c:228]: (warning) %d in format string (no. 2) requires 'int' but the argument type is 'size_t {aka unsigned long}'.
[src/sys/arch/i386/i386/multiboot.c:230]: (warning) %d in format string (no. 2) requires 'int' but the argument type is 'size_t {aka unsigned long}'.

Suggest use %lu, not %d.
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51187 CVS commit: src/sys/arch/i386/i386
Date: Mon, 30 May 2016 17:45:26 +0000

 Module Name:	src
 Committed By:	dholland
 Date:		Mon May 30 17:45:26 UTC 2016

 Modified Files:
 	src/sys/arch/i386/i386: multiboot.c

 Log Message:
 PR 51187 David Binderman: simplify redundant conditional


 To generate a diff of this commit:
 cvs rdiff -u -r1.22 -r1.23 src/sys/arch/i386/i386/multiboot.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Tue, 31 May 2016 03:52:25 +0000
State-Changed-Why:
fixed, thanks


>Unformatted:

Home	PR Database Search