NetBSD Problem Report #51200
From dholland@netbsd.org Tue May 31 04:11:12 2016
Return-Path: <dholland@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
by mollari.NetBSD.org (Postfix) with ESMTPS id 33A097A469
for <gnats-bugs@gnats.NetBSD.org>; Tue, 31 May 2016 04:11:12 +0000 (UTC)
Message-Id: <20160531041111.EDCE785E8D@mail.netbsd.org>
Date: Tue, 31 May 2016 04:11:11 +0000 (UTC)
From: dholland@netbsd.org
Reply-To: dholland@netbsd.org
To: gnats-bugs@NetBSD.org
Subject: gets considered harmful even in libsa
X-Send-Pr-Version: 3.95
>Number: 51200
>Category: kern
>Synopsis: gets considered harmful even in libsa
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: kern-bug-people
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Tue May 31 04:15:00 +0000 2016
>Closed-Date: Sat Aug 27 07:16:26 +0000 2016
>Last-Modified: Sat Aug 27 07:16:26 +0000 2016
>Originator: David A. Holland
>Release: NetBSD 7.99.30 (20160531)
>Organization:
>Environment:
n/a
>Description:
There's a gets() in libsa, in its full traditional overflowable glory.
This is really probably not such a great idea today in the era of
console servers and such, but apart from that it also causes code
scanners to light up red.
Should change it to gets_sa or something that takes a bound as well as
a buffer pointer. Hard part is testing all the affected bootbollocks.
>How-To-Repeat:
code reading
>Fix:
>Release-Note:
>Audit-Trail:
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/acorn26/stand/boot26
Date: Sat, 11 Jun 2016 06:24:36 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 06:24:36 UTC 2016
Modified Files:
src/sys/arch/acorn26/stand/boot26: boot26.c
Log Message:
PR 51200 gets in libsa considered harmful: use kgets
To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7 src/sys/arch/acorn26/stand/boot26/boot26.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/acorn32/stand/boot32
Date: Sat, 11 Jun 2016 06:25:21 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 06:25:21 UTC 2016
Modified Files:
src/sys/arch/acorn32/stand/boot32: boot32.c
Log Message:
PR 51200 gets in libsa considered harmful: use kgets
To generate a diff of this commit:
cvs rdiff -u -r1.41 -r1.42 src/sys/arch/acorn32/stand/boot32/boot32.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/alpha/stand/common
Date: Sat, 11 Jun 2016 06:26:07 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 06:26:07 UTC 2016
Modified Files:
src/sys/arch/alpha/stand/common: boot.c
Log Message:
PR 51200 gets in libsa considered harmful: use kgets
To generate a diff of this commit:
cvs rdiff -u -r1.32 -r1.33 src/sys/arch/alpha/stand/common/boot.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/alpha/stand/standtest
Date: Sat, 11 Jun 2016 06:26:50 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 06:26:50 UTC 2016
Modified Files:
src/sys/arch/alpha/stand/standtest: test.c
Log Message:
PR 51200 gets in libsa considered harmful: use kgets
To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7 src/sys/arch/alpha/stand/standtest/test.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/atari/stand/bootxx
Date: Sat, 11 Jun 2016 06:28:07 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 06:28:07 UTC 2016
Modified Files:
src/sys/arch/atari/stand/bootxx: bootxx.c
Log Message:
PR 51200 gets in libsa considered harmful: use kgets
To generate a diff of this commit:
cvs rdiff -u -r1.16 -r1.17 src/sys/arch/atari/stand/bootxx/bootxx.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/bebox/stand/boot
Date: Sat, 11 Jun 2016 06:28:49 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 06:28:49 UTC 2016
Modified Files:
src/sys/arch/bebox/stand/boot: monitor.c
Log Message:
PR 51200 gets in libsa considered harmful: use kgets
To generate a diff of this commit:
cvs rdiff -u -r1.10 -r1.11 src/sys/arch/bebox/stand/boot/monitor.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/hpcmips/stand/lcboot
Date: Sat, 11 Jun 2016 06:29:24 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 06:29:24 UTC 2016
Modified Files:
src/sys/arch/hpcmips/stand/lcboot: main.c
Log Message:
PR 51200 gets in libsa considered harmful: use kgets
To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7 src/sys/arch/hpcmips/stand/lcboot/main.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/landisk/stand/boot
Date: Sat, 11 Jun 2016 06:31:49 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 06:31:49 UTC 2016
Modified Files:
src/sys/arch/landisk/stand/boot: boot2.c monitor.c
Log Message:
PR 51200 gets in libsa considered harmful: use kgets
To generate a diff of this commit:
cvs rdiff -u -r1.5 -r1.6 src/sys/arch/landisk/stand/boot/boot2.c
cvs rdiff -u -r1.3 -r1.4 src/sys/arch/landisk/stand/boot/monitor.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/macppc/stand/ofwboot
Date: Sat, 11 Jun 2016 06:32:46 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 06:32:46 UTC 2016
Modified Files:
src/sys/arch/macppc/stand/ofwboot: boot.c
Log Message:
PR 51200 gets in libsa considered harmful: use kgets
To generate a diff of this commit:
cvs rdiff -u -r1.27 -r1.28 src/sys/arch/macppc/stand/ofwboot/boot.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/mvme68k/stand/netboot
Date: Sat, 11 Jun 2016 06:33:30 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 06:33:30 UTC 2016
Modified Files:
src/sys/arch/mvme68k/stand/netboot: boot.c
Log Message:
PR 51200 gets in libsa considered harmful: use kgets
To generate a diff of this commit:
cvs rdiff -u -r1.16 -r1.17 src/sys/arch/mvme68k/stand/netboot/boot.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/mvmeppc/stand/boot
Date: Sat, 11 Jun 2016 06:34:00 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 06:34:00 UTC 2016
Modified Files:
src/sys/arch/mvmeppc/stand/boot: boot.c
Log Message:
PR 51200 gets in libsa considered harmful: use kgets
To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7 src/sys/arch/mvmeppc/stand/boot/boot.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/ofppc/stand/ofwboot
Date: Sat, 11 Jun 2016 06:35:38 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 06:35:38 UTC 2016
Modified Files:
src/sys/arch/ofppc/stand/ofwboot: boot.c
Log Message:
PR 51200 gets in libsa considered harmful: use kgets
To generate a diff of this commit:
cvs rdiff -u -r1.23 -r1.24 src/sys/arch/ofppc/stand/ofwboot/boot.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/pmax/include
Date: Sat, 11 Jun 2016 06:38:18 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 06:38:18 UTC 2016
Modified Files:
src/sys/arch/pmax/include: dec_prom.h
Log Message:
gets -> unsafe_gets; nothing uses this but let's not start by accident.
(related to PR 51200)
To generate a diff of this commit:
cvs rdiff -u -r1.23 -r1.24 src/sys/arch/pmax/include/dec_prom.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/prep/stand/boot
Date: Sat, 11 Jun 2016 06:38:50 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 06:38:50 UTC 2016
Modified Files:
src/sys/arch/prep/stand/boot: monitor.c
Log Message:
PR 51200 gets in libsa considered harmful: use kgets
To generate a diff of this commit:
cvs rdiff -u -r1.8 -r1.9 src/sys/arch/prep/stand/boot/monitor.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/rs6000/stand/boot
Date: Sat, 11 Jun 2016 06:39:25 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 06:39:25 UTC 2016
Modified Files:
src/sys/arch/rs6000/stand/boot: monitor.c
Log Message:
PR 51200 gets in libsa considered harmful: use kgets
To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/sys/arch/rs6000/stand/boot/monitor.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/next68k/stand/boot
Date: Sat, 11 Jun 2016 06:35:00 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 06:35:00 UTC 2016
Modified Files:
src/sys/arch/next68k/stand/boot: boot.c
Log Message:
PR 51200 gets in libsa considered harmful: use kgets
To generate a diff of this commit:
cvs rdiff -u -r1.11 -r1.12 src/sys/arch/next68k/stand/boot/boot.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/sandpoint/stand/altboot
Date: Sat, 11 Jun 2016 06:40:24 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 06:40:24 UTC 2016
Modified Files:
src/sys/arch/sandpoint/stand/altboot: main.c
Log Message:
PR 51200 gets in libsa considered harmful: use kgets
To generate a diff of this commit:
cvs rdiff -u -r1.27 -r1.28 src/sys/arch/sandpoint/stand/altboot/main.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/sbmips/stand/common
Date: Sat, 11 Jun 2016 06:41:12 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 06:41:12 UTC 2016
Modified Files:
src/sys/arch/sbmips/stand/common: boot.c
Log Message:
PR 51200 gets in libsa considered harmful: use kgets
To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7 src/sys/arch/sbmips/stand/common/boot.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/shark/stand/ofwboot
Date: Sat, 11 Jun 2016 06:41:56 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 06:41:55 UTC 2016
Modified Files:
src/sys/arch/shark/stand/ofwboot: boot.c
Log Message:
PR 51200 gets in libsa considered harmful: use kgets
To generate a diff of this commit:
cvs rdiff -u -r1.7 -r1.8 src/sys/arch/shark/stand/ofwboot/boot.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/vax/boot/boot
Date: Sat, 11 Jun 2016 06:42:27 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 06:42:27 UTC 2016
Modified Files:
src/sys/arch/vax/boot/boot: boot.c
Log Message:
PR 51200 gets in libsa considered harmful: use kgets
To generate a diff of this commit:
cvs rdiff -u -r1.33 -r1.34 src/sys/arch/vax/boot/boot/boot.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/sparc/stand/boot
Date: Sat, 11 Jun 2016 06:43:16 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 06:43:16 UTC 2016
Modified Files:
src/sys/arch/sparc/stand/boot: boot.c
Log Message:
PR 51200 gets in libsa considered harmful: use kgets
To generate a diff of this commit:
cvs rdiff -u -r1.29 -r1.30 src/sys/arch/sparc/stand/boot/boot.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/sparc/stand/ofwboot
Date: Sat, 11 Jun 2016 06:43:47 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 06:43:47 UTC 2016
Modified Files:
src/sys/arch/sparc/stand/ofwboot: boot.c
Log Message:
PR 51200 gets in libsa considered harmful: use kgets
To generate a diff of this commit:
cvs rdiff -u -r1.32 -r1.33 src/sys/arch/sparc/stand/ofwboot/boot.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/sun68k/stand
Date: Sat, 11 Jun 2016 06:49:46 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 06:49:46 UTC 2016
Modified Files:
src/sys/arch/sun68k/stand/libsa: gets.c xxboot.c
src/sys/arch/sun68k/stand/tapeboot: boot.c
Log Message:
PR 51200 gets in libsa considered harmful: change own gets() to kgets()
and use it.
To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 src/sys/arch/sun68k/stand/libsa/gets.c
cvs rdiff -u -r1.6 -r1.7 src/sys/arch/sun68k/stand/libsa/xxboot.c
cvs rdiff -u -r1.7 -r1.8 src/sys/arch/sun68k/stand/tapeboot/boot.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/x68k/stand/boot
Date: Sat, 11 Jun 2016 06:50:21 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 06:50:21 UTC 2016
Modified Files:
src/sys/arch/x68k/stand/boot: boot.c
Log Message:
PR 51200 gets in libsa considered harmful: use kgets
To generate a diff of this commit:
cvs rdiff -u -r1.22 -r1.23 src/sys/arch/x68k/stand/boot/boot.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/x68k/stand/boot
Date: Sat, 11 Jun 2016 06:57:46 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 06:57:46 UTC 2016
Modified Files:
src/sys/arch/x68k/stand/boot: boot.c
Log Message:
Revert this one; I can't tell for sure if it's using libsa gets or its
own firmware one in ../libdos. If the latter, switching and bringing
in the libsa one (a) might not work and (b) might make the bootloader
overflow size limits.
PR 51200.
To generate a diff of this commit:
cvs rdiff -u -r1.23 -r1.24 src/sys/arch/x68k/stand/boot/boot.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/zaurus/stand/zboot
Date: Sat, 11 Jun 2016 06:58:42 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 06:58:42 UTC 2016
Modified Files:
src/sys/arch/zaurus/stand/zboot: boot.c bootmenu.c
Log Message:
PR 51200 gets in libsa considered harmful: use kgets
To generate a diff of this commit:
cvs rdiff -u -r1.7 -r1.8 src/sys/arch/zaurus/stand/zboot/boot.c
cvs rdiff -u -r1.4 -r1.5 src/sys/arch/zaurus/stand/zboot/bootmenu.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/lib/libsa
Date: Sat, 11 Jun 2016 06:59:21 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 06:59:21 UTC 2016
Modified Files:
src/sys/lib/libsa: getfile.c
Log Message:
PR 51200 gets in libsa considered harmful: use kgets
To generate a diff of this commit:
cvs rdiff -u -r1.9 -r1.10 src/sys/lib/libsa/getfile.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Responsible-Changed-From-To: kern-bug-people->port-x68k-maintainer
Responsible-Changed-By: dholland@NetBSD.org
Responsible-Changed-When: Sat, 11 Jun 2016 07:05:28 +0000
Responsible-Changed-Why:
Only one left, which is in arch/x68k/stand/boot/boot.c and needs attention
from someone with platform knowledge. When that one's eliminated, or is
shown to be using a firmware gets() and using kgets() from libsa would be
too large or otherwise infeasible... then gets can and should be removed
from libsa. (at that point set the category back to kern)
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/amiga/stand/bootblock/boot
Date: Sat, 11 Jun 2016 07:01:25 +0000
Module Name: src
Committed By: dholland
Date: Sat Jun 11 07:01:25 UTC 2016
Modified Files:
src/sys/arch/amiga/stand/bootblock/boot: main.c
Log Message:
PR 51200 gets in libsa considered harmful: use kgets
To generate a diff of this commit:
cvs rdiff -u -r1.30 -r1.31 src/sys/arch/amiga/stand/bootblock/boot/main.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Responsible-Changed-From-To: port-x68k-maintainer->kern-bug-people
Responsible-Changed-By: isaki@NetBSD.org
Responsible-Changed-When: Thu, 04 Aug 2016 12:22:03 +0000
Responsible-Changed-Why:
x68k now uses kgets().
From: "Tetsuya Isaki" <isaki@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/arch/x68k/stand/boot
Date: Thu, 4 Aug 2016 12:15:08 +0000
Module Name: src
Committed By: isaki
Date: Thu Aug 4 12:15:08 UTC 2016
Modified Files:
src/sys/arch/x68k/stand/boot: boot.c
Log Message:
gets -> kgets. the last part of PR/51200.
It was using libsa's gets, so it's possible to change to kgets
as rev 1.23. I've confirmed that it works.
To generate a diff of this commit:
cvs rdiff -u -r1.29 -r1.30 src/sys/arch/x68k/stand/boot/boot.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: David Holland <dholland@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: Tetsuya Isaki <isaki@netbsd.org>
Subject: Re: PR/51200 CVS commit: src/sys/arch/x68k/stand/boot
Date: Thu, 4 Aug 2016 17:46:23 +0000
On Thu, Aug 04, 2016 at 12:35:01PM +0000, Tetsuya Isaki wrote:
> Modified Files:
> src/sys/arch/x68k/stand/boot: boot.c
>
> Log Message:
> gets -> kgets. the last part of PR/51200.
> It was using libsa's gets, so it's possible to change to kgets
> as rev 1.23. I've confirmed that it works.
Whee! Thanks :-)
--
David A. Holland
dholland@netbsd.org
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51200 CVS commit: src/sys/lib/libsa
Date: Sat, 27 Aug 2016 06:31:42 +0000
Module Name: src
Committed By: dholland
Date: Sat Aug 27 06:31:42 UTC 2016
Modified Files:
src/sys/lib/libsa: gets.c
Log Message:
PR 51200 gets in libsa considered harmful: remove gets() from libsa.
To generate a diff of this commit:
cvs rdiff -u -r1.13 -r1.14 src/sys/lib/libsa/gets.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 27 Aug 2016 07:16:26 +0000
State-Changed-Why:
Done.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2014
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.
Home