NetBSD Problem Report #51285

From www@NetBSD.org  Mon Jun 27 08:01:50 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 049417A477
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 27 Jun 2016 08:01:50 +0000 (UTC)
Message-Id: <20160627080115.788077AAA2@mollari.NetBSD.org>
Date: Mon, 27 Jun 2016 08:01:15 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Missing dt_proc_unlock in dt_module.c
X-Send-Pr-Version: www-1.0

>Number:         51285
>Category:       misc
>Synopsis:       Missing dt_proc_unlock in dt_module.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pgoyette
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jun 27 08:05:00 +0000 2016
>Closed-Date:    Sun Jul 10 10:39:13 +0000 2016
>Last-Modified:  Sun Jul 10 10:39:13 +0000 2016
>Originator:     Henning Petersen
>Release:        Netbsd-current
>Organization:
>Environment:
>Description:
In error path is missing one dt_proc_unlock.
>How-To-Repeat:

>Fix:
diff -u -p -r1.12 dt_module.c
--- external/cddl/osnet/dist/lib/libdtrace/common/dt_module.c	6 Oct 2015 01:18:47 -0000	1.12
+++ external/cddl/osnet/dist/lib/libdtrace/common/dt_module.c	14 Apr 2016 05:25:58 -0000
@@ -713,6 +713,7 @@ dt_module_load_proc(dtrace_hdl_t *dtp, d
 	arg.dpa_count = 0;
 	if (Pobject_iter_resolved(p, dt_module_load_proc_count, &arg) != 0) {
 		dt_dprintf("failed to iterate objects\n");
+		dt_proc_unlock(dtp, p);
 		dt_proc_release(dtp, p);
 		return (dt_set_errno(dtp, EDT_CANTLOAD));
 	}

>Release-Note:

>Audit-Trail:
From: "Paul Goyette" <pgoyette@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51285 CVS commit: src/external/cddl/osnet/dist/lib/libdtrace/common
Date: Thu, 30 Jun 2016 00:23:37 +0000

 Module Name:	src
 Committed By:	pgoyette
 Date:		Thu Jun 30 00:23:36 UTC 2016

 Modified Files:
 	src/external/cddl/osnet/dist/lib/libdtrace/common: dt_module.c

 Log Message:
 Add missing dp_proc_unlock() in error path.

 From PR kern/51285 (Henning Petersen)

 XXX Pullup to 7 and 7-0


 To generate a diff of this commit:
 cvs rdiff -u -r1.13 -r1.14 \
     src/external/cddl/osnet/dist/lib/libdtrace/common/dt_module.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Responsible-Changed-From-To: misc-bug-people->pgoyette
Responsible-Changed-By: pgoyette@NetBSD.org
Responsible-Changed-When: Thu, 30 Jun 2016 00:28:12 +0000
Responsible-Changed-Why:
I handled it.


State-Changed-From-To: open->closed
State-Changed-By: pgoyette@NetBSD.org
State-Changed-When: Thu, 30 Jun 2016 00:28:12 +0000
State-Changed-Why:
Fix committed.  Even though the commit message suggests that this might
need to be pulled up to -7 and -7-0, it appears that none of the other
changes over the past 4+ years have been pulled up, so let's not bother
with this one, either.


From: David Holland <dholland-bugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: misc/51285 (Missing dt_proc_unlock in dt_module.c)
Date: Thu, 30 Jun 2016 01:16:47 +0000

 On Thu, Jun 30, 2016 at 12:28:12AM +0000, pgoyette@NetBSD.org wrote:
  > Fix committed.  Even though the commit message suggests that this might
  > need to be pulled up to -7 and -7-0, it appears that none of the other
  > changes over the past 4+ years have been pulled up, so let's not bother
  > with this one, either.

 -7 hasn't exactly been around for 4+ years :-)

 -- 
 David A. Holland
 dholland@netbsd.org

From: matthew green <mrg@eterna.com.au>
To: gnats-bugs@NetBSD.org
Cc: pgoyette@NetBSD.org, gnats-admin@netbsd.org, netbsd-bugs@netbsd.org,
    henning.petersen@t-online.de
Subject: re: misc/51285 (Missing dt_proc_unlock in dt_module.c)
Date: Thu, 30 Jun 2016 11:48:52 +1000

 >  On Thu, Jun 30, 2016 at 12:28:12AM +0000, pgoyette@NetBSD.org wrote:
 >   > Fix committed.  Even though the commit message suggests that this might
 >   > need to be pulled up to -7 and -7-0, it appears that none of the other
 >   > changes over the past 4+ years have been pulled up, so let's not bother
 >   > with this one, either.
 >  
 >  -7 hasn't exactly been around for 4+ years :-)

 there is work to get dtrace in -7 updated happening, so i wouldn't
 ignore this change for there.


 .mrg.

State-Changed-From-To: closed->pending-pullups
State-Changed-By: pgoyette@NetBSD.org
State-Changed-When: Thu, 30 Jun 2016 01:55:45 +0000
State-Changed-Why:
Waiting for pullup-7 #1191


From: Paul Goyette <paul@whooppee.com>
To: matthew green <mrg@eterna.com.au>
Cc: gnats-bugs@NetBSD.org, pgoyette@NetBSD.org, gnats-admin@netbsd.org, 
    netbsd-bugs@netbsd.org, henning.petersen@t-online.de
Subject: re: misc/51285 (Missing dt_proc_unlock in dt_module.c)
Date: Thu, 30 Jun 2016 09:50:42 +0800 (PHT)

 On Thu, 30 Jun 2016, matthew green wrote:

 >>  On Thu, Jun 30, 2016 at 12:28:12AM +0000, pgoyette@NetBSD.org wrote:
 >>  > Fix committed.  Even though the commit message suggests that this might
 >>  > need to be pulled up to -7 and -7-0, it appears that none of the other
 >>  > changes over the past 4+ years have been pulled up, so let's not bother
 >>  > with this one, either.
 >>
 >>  -7 hasn't exactly been around for 4+ years :-)
 >
 > there is work to get dtrace in -7 updated happening, so i wouldn't
 > ignore this change for there.

 Ah, that makes a difference!

 I'll request the pull-up for this fix.  Hopefully other fixes (including 
 the one from riz@ "Make this build for me" will get reviewed and pulled 
 up as appropriate.


 +------------------+--------------------------+------------------------+
 | Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:      |
 | (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com   |
 | Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd.org |
 +------------------+--------------------------+------------------------+

From: Paul Goyette <paul@whooppee.com>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: bin/51285
Date: Thu, 30 Jun 2016 11:10:40 +0800 (PHT)

 Here's another related commit:

 Module Name:    src
 Committed By:   christos
 Date:           Thu Jun 30 03:05:45 UTC 2016

 Modified Files:
          src/external/ibm-public/postfix/libexec/smtpd: Makefile

 Log Message:
 Makefile.inc needs -I${DIST} to be the source dir of the program we are
 compiling, make it so.


 To generate a diff of this commit:
 cvs rdiff -u -r1.4 -r1.5 \
      src/external/ibm-public/postfix/libexec/smtpd/Makefile



 +------------------+--------------------------+------------------------+
 | Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:      |
 | (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com   |
 | Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd.org |
 +------------------+--------------------------+------------------------+

State-Changed-From-To: pending-pullups->closed
State-Changed-By: pgoyette@NetBSD.org
State-Changed-When: Sun, 10 Jul 2016 10:39:13 +0000
State-Changed-Why:
Pullups are not needed here - netbsd-7 uses a much older code base.


>Unformatted:

Home	PR Database Search