NetBSD Problem Report #51441

From martin@duskware.de  Tue Aug 23 20:25:57 2016
Return-Path: <martin@duskware.de>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 786777A271
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 23 Aug 2016 20:25:57 +0000 (UTC)
From: martin@NetBSD.org
Reply-To: martin@NetBSD.org
To: gnats-bugs@NetBSD.org
Subject: libshmfence fails to build
X-Send-Pr-Version: 3.95

>Number:         51441
>Category:       xsrc
>Synopsis:       libshmfence fails to build
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    xsrc-manager
>State:          feedback
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Aug 23 20:30:00 +0000 2016
>Closed-Date:    
>Last-Modified:  Wed Jul 05 23:16:38 +0000 2023
>Originator:     Martin Husemann
>Release:        NetBSD 7.99.36
>Organization:
The NetBSD Foundation, Inc.
>Environment:
System: NetBSD thirdstage.duskware.de 7.99.36 NetBSD 7.99.36 (MODULAR) #543: Mon Aug 22 16:54:45 CEST 2016 martin@thirdstage.duskware.de:/usr/src/sys/arch/sparc64/compile/MODULAR sparc64
Architecture: sparc64
Machine: sparc64
>Description:

Building natively (with old xort server) and MKDEBUG=yes + MKDEBUGLIB=yes
fails on sparc64:

--- xshmfence_semaphore.po ---
/usr/tools/bin/sparc64--netbsd-gcc -O2 -pipe   -std=gnu99   -Werror   -fPIE -fst
ack-protector -Wstack-protector   --param ssp-buffer-size=1  -fno-strict-aliasin
g  --sysroot=/ -DSHMDIR=\"/var/shm\" -DHAVE_SEMAPHORE -DLIBXSHM_PAGESIZE=4096  -
D_FORTIFY_SOURCE=2 -DNO_ALLOCA -DCSRG_BASED -DFUNCPROTO=15 -DNARROWPROTO -I//usr
/X11R7/include -c -DGPROF -DPROF    -pg /usr/xsrc/external/mit/libxshmfence/dist
/src/xshmfence_semaphore.c -o xshmfence_semaphore.po
--- xshmfence_semaphore.pico ---
/usr/xsrc/external/mit/libxshmfence/dist/src/xshmfence_semaphore.c: In function 
'xshmfence_init':
/usr/xsrc/external/mit/libxshmfence/dist/src/xshmfence_semaphore.c:152:1: error:
 stack protector not protecting local variables: variable length buffer [-Werror
=stack-protector]
 xshmfence_init(int fd)
 ^
cc1: all warnings being treated as errors


>How-To-Repeat:
s/a

>Fix:
n/a

>Release-Note:

>Audit-Trail:
From: Patrick Welche <prlw1@cam.ac.uk>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: xsrc/51441: libshmfence fails to build
Date: Tue, 30 Aug 2016 12:24:22 +0100

 Does

    http://mail-index.netbsd.org/pkgsrc-changes/2016/08/24/msg145610.html
    cvs rdiff -u -r1.5 -r1.6 pkgsrc/x11/libxshmfence/files/xshmfence_semaphore.c

 help?

From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: xsrc/51441: libshmfence fails to build
Date: Sun, 4 Sep 2016 13:30:39 +0200

 On Tue, Aug 30, 2016 at 11:25:01AM +0000, Patrick Welche wrote:
 >  Does
 >  
 >     http://mail-index.netbsd.org/pkgsrc-changes/2016/08/24/msg145610.html
 >     cvs rdiff -u -r1.5 -r1.6 pkgsrc/x11/libxshmfence/files/xshmfence_semaphore.c
 >  
 >  help?

 No, it is the PAGE_ALIGN in the declaration of the semaphore struct (and
 the init function using that on the stack). Besides, for sparc64 the
 PAGE_ALIGN is bogus anyway.

 Martin

State-Changed-From-To: open->feedback
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Wed, 05 Jul 2023 23:16:38 +0000
State-Changed-Why:
Does this still fail to build?

I don't see the VLA and I can't reproduce it by compiling a reduced
test case with my sparc64--netbsd-gcc -Wstack-protector.


>Unformatted:

Home	PR Database Search