NetBSD Problem Report #51553

From www@NetBSD.org  Tue Oct 11 15:47:35 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 370307A28E
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 11 Oct 2016 15:47:35 +0000 (UTC)
Message-Id: <20161011154734.588E27A2C6@mollari.NetBSD.org>
Date: Tue, 11 Oct 2016 15:47:34 +0000 (UTC)
From: dcb@NetBSD.org
Reply-To: dcb@NetBSD.org
To: gnats-bugs@NetBSD.org
Subject: src/sys/altq/altq_jobs.c: 2 * pointless local variables ?
X-Send-Pr-Version: www-1.0

>Number:         51553
>Category:       kern
>Synopsis:       src/sys/altq/altq_jobs.c: 2 * pointless local variables ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Oct 11 15:50:00 +0000 2016
>Closed-Date:    Mon Nov 21 14:33:29 +0000 2016
>Last-Modified:  Mon Nov 21 14:33:29 +0000 2016
>Originator:     David Binderman
>Release:        cvs-20161011
>Organization:
>Environment:
>Description:
[src/sys/altq/altq_jobs.c:1573]: (style) Variable 'backlogged_classes' is modified but its new value is never used.
[src/sys/altq/altq_jobs.c:1714]: (style) Variable 'backlogged_classes' is modified but its new value is never used.

$ fgrep backlogged_classes src/sys/altq/altq_jobs.c
	int active_classes, backlogged_classes;
	backlogged_classes = 0;
			backlogged_classes++;
	int i, active_classes, backlogged_classes;
	backlogged_classes = 0;
			backlogged_classes ++;
$ 


Suggest delete local variables "backlogged_classes". They aren't used anywhere.

>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51553 CVS commit: src/sys/altq
Date: Mon, 21 Nov 2016 07:15:36 +0000

 Module Name:	src
 Committed By:	dholland
 Date:		Mon Nov 21 07:15:36 UTC 2016

 Modified Files:
 	src/sys/altq: altq_jobs.c

 Log Message:
 PR 51553 David Binderman: don't bother counting up backlogged classes
 when not doing anything with the results.


 To generate a diff of this commit:
 cvs rdiff -u -r1.9 -r1.10 src/sys/altq/altq_jobs.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Mon, 21 Nov 2016 14:33:29 +0000
State-Changed-Why:
fixed, thanks


>Unformatted:

Home	PR Database Search