NetBSD Problem Report #51772

From yorickhardy@gmail.com  Wed Jan  4 08:14:55 2017
Return-Path: <yorickhardy@gmail.com>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 45E3A7A2DE
	for <gnats-bugs@gnats.NetBSD.org>; Wed,  4 Jan 2017 08:14:55 +0000 (UTC)
Message-Id: <586caefc.4306c20a.d0b9e.73df@mx.google.com>
Date: Wed, 04 Jan 2017 10:14:49 +0200
From: yorickhardy@gmail.com
Reply-To: yorickhardy@gmail.com
To: gnats-bugs@NetBSD.org
Subject: Custom kernel names
X-Send-Pr-Version: 3.95

>Number:         51772
>Category:       kern
>Synopsis:       Custom kernel names
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jan 04 08:15:00 +0000 2017
>Closed-Date:    Wed Jan 04 16:11:43 +0000 2017
>Last-Modified:  Wed Jan 04 16:11:43 +0000 2017
>Originator:     Yorick Hardy
>Release:        NetBSD 7.99.53
>Organization:

>Environment:
System: NetBSD HOME 7.99.53 NetBSD 7.99.53 (YORICK.amd64) #0: Sun Jan 1 16:42:47 SAST 2017 root@HOME:/root/build.amd64.local/obj/sys/arch/amd64/compile/YORICK.amd64 amd64
Architecture: x86_64
Machine: amd64
>Description:
Since revision 1.228 of src/sys/conf/Makefile.kern.inc, kernels with a name
other than "netbsd" failed to build.
>How-To-Repeat:
>Fix:
Index: sys/conf/Makefile.kern.inc
===================================================================
RCS file: /cvsroot/src/sys/conf/Makefile.kern.inc,v
retrieving revision 1.250
diff -u -r1.250 Makefile.kern.inc
--- sys/conf/Makefile.kern.inc	9 Apr 2016 18:51:44 -0000	1.250
+++ sys/conf/Makefile.kern.inc	4 Jan 2017 07:59:02 -0000
@@ -213,10 +213,10 @@
 SYSTEM_LD?=	${_MKSHMSG} "   link  ${.CURDIR:T}/${.TARGET}"; \
 		${_MKSHECHO}\
 		${LD} -Map ${.TARGET}.map --cref ${LINKFLAGS} -o ${.TARGET} \
-		'$${SYSTEM_OBJ:N*swap*netbsd*}' '$${EXTRA_OBJ}' vers.o \
+		'$${SYSTEM_OBJ:N*swap${.TARGET}*}' '$${EXTRA_OBJ}' vers.o \
 		${OBJS:M*swap${.TARGET}.o}; \
 		${LD} -Map ${.TARGET}.map --cref ${LINKFLAGS} -o ${.TARGET} \
-		${SYSTEM_OBJ:N*swap*netbsd*} ${EXTRA_OBJ} vers.o \
+		${SYSTEM_OBJ:N*swap${.TARGET}*} ${EXTRA_OBJ} vers.o \
 		${OBJS:M*swap${.TARGET}.o}

 TEXTADDR?=	${LOADADDRESS}			# backwards compatibility

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51772 CVS commit: src/sys/conf
Date: Wed, 4 Jan 2017 10:43:04 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Wed Jan  4 15:43:04 UTC 2017

 Modified Files:
 	src/sys/conf: Makefile.kern.inc

 Log Message:
 PR/51772: Yorick Hardy: Don't hard-code "netbsd", use ${.TARGET} consistently.


 To generate a diff of this commit:
 cvs rdiff -u -r1.250 -r1.251 src/sys/conf/Makefile.kern.inc

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Wed, 04 Jan 2017 16:11:43 +0000
State-Changed-Why:
Fixed by christos.


>Unformatted:

Home	PR Database Search