NetBSD Problem Report #51809

From www@NetBSD.org  Tue Jan 10 09:27:49 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 604907A26E
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 10 Jan 2017 09:27:49 +0000 (UTC)
Message-Id: <20170110092748.739F87A2B2@mollari.NetBSD.org>
Date: Tue, 10 Jan 2017 09:27:48 +0000 (UTC)
From: yaneurabeya@gmail.com
Reply-To: yaneurabeya@gmail.com
To: gnats-bugs@NetBSD.org
Subject: [PATCH] tests/lib/libc/gen/t_ftok: fix file descriptor leak
X-Send-Pr-Version: www-1.0

>Number:         51809
>Category:       bin
>Synopsis:       [PATCH] tests/lib/libc/gen/t_ftok: fix file descriptor leak
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jan 10 09:30:00 +0000 2017
>Closed-Date:    Tue Jan 10 18:15:49 +0000 2017
>Last-Modified:  Tue Jan 10 18:15:49 +0000 2017
>Originator:     Ngie Cooper
>Release:        7.0.2
>Organization:
>Environment:
n/a
>Description:
Don't leak fd after opening it.
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/51809: [PATCH] tests/lib/libc/gen/t_ftok: fix file descriptor
 leak
Date: Tue, 10 Jan 2017 01:30:30 -0800

 --Apple-Mail=_109201EA-C822-4790-860B-958254A29715
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain;
 	charset=us-ascii

 Patch attached.

 --Apple-Mail=_109201EA-C822-4790-860B-958254A29715
 Content-Disposition: attachment;
 	filename=t_ftok-dont-leak-fd-after-open.patch
 Content-Type: application/octet-stream;
 	x-unix-mode=0644;
 	name="t_ftok-dont-leak-fd-after-open.patch"
 Content-Transfer-Encoding: 7bit

 Index: t_ftok.c
 ===================================================================
 RCS file: /cvsroot/src/tests/lib/libc/gen/t_ftok.c,v
 retrieving revision 1.1
 diff -u -r1.1 t_ftok.c
 --- t_ftok.c	8 Nov 2011 05:47:00 -0000	1.1
 +++ t_ftok.c	10 Jan 2017 09:26:39 -0000
 @@ -68,6 +68,7 @@
  	fd = open(path, O_RDONLY | O_CREAT);

  	ATF_REQUIRE(fd >= 0);
 +	(void)close(fd);
  	ATF_REQUIRE(link(path, hlnk) == 0);
  	ATF_REQUIRE(symlink(path, slnk) == 0);


 --Apple-Mail=_109201EA-C822-4790-860B-958254A29715--

From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51809 CVS commit: src/tests/lib/libc/gen
Date: Tue, 10 Jan 2017 10:19:52 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Tue Jan 10 15:19:52 UTC 2017

 Modified Files:
 	src/tests/lib/libc/gen: t_ftok.c

 Log Message:
 PR/51809: Ngie Cooper: fix file descriptor leak


 To generate a diff of this commit:
 cvs rdiff -u -r1.1 -r1.2 src/tests/lib/libc/gen/t_ftok.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Tue, 10 Jan 2017 18:15:49 +0000
State-Changed-Why:
christos committed it, thanks


>Unformatted:

Home	PR Database Search