NetBSD Problem Report #51812
From www@NetBSD.org Tue Jan 10 09:45:10 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
by mollari.NetBSD.org (Postfix) with ESMTPS id 9ACDB7A2B4
for <gnats-bugs@gnats.NetBSD.org>; Tue, 10 Jan 2017 09:45:10 +0000 (UTC)
Message-Id: <20170110094509.B97787A2B6@mollari.NetBSD.org>
Date: Tue, 10 Jan 2017 09:45:09 +0000 (UTC)
From: yaneurabeya@gmail.com
Reply-To: yaneurabeya@gmail.com
To: gnats-bugs@NetBSD.org
Subject: [PATCH] tests/lib/libc/gen/t_time: add missing #define for gettimeofday
X-Send-Pr-Version: www-1.0
>Number: 51812
>Category: bin
>Synopsis: [PATCH] tests/lib/libc/gen/t_time: add missing #define for gettimeofday
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: bin-bug-people
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Tue Jan 10 09:50:00 +0000 2017
>Closed-Date: Tue Jan 10 18:19:37 +0000 2017
>Last-Modified: Tue Jan 10 18:19:37 +0000 2017
>Originator: Ngie Cooper
>Release: 7.0.2
>Organization:
>Environment:
n/a
>Description:
FreeBSD needs this #include to compile the testcase, which is fulfilled via header pollution on NetBSD.
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: bin/51812: [PATCH] tests/lib/libc/gen/t_time: add missing #define
for gettimeofday
Date: Tue, 10 Jan 2017 01:51:28 -0800
--Apple-Mail=_58D2824B-D0C4-4E8D-8747-FE4523C65C78
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
charset=us-ascii
Patch attached.
--Apple-Mail=_58D2824B-D0C4-4E8D-8747-FE4523C65C78
Content-Disposition: attachment;
filename=t_time-fix-missing-includes.patch
Content-Type: application/octet-stream;
x-unix-mode=0644;
name="t_time-fix-missing-includes.patch"
Content-Transfer-Encoding: 7bit
Index: t_time.c
===================================================================
RCS file: /cvsroot/src/tests/lib/libc/gen/t_time.c,v
retrieving revision 1.3
diff -u -p -r1.3 t_time.c
--- t_time.c 31 Oct 2014 12:22:38 -0000 1.3
+++ t_time.c 10 Jan 2017 09:51:09 -0000
@@ -31,6 +31,7 @@
#include <sys/cdefs.h>
__RCSID("$NetBSD: t_time.c,v 1.3 2014/10/31 12:22:38 justin Exp $");
+#include <sys/time.h>
#include <atf-c.h>
#include <errno.h>
#include <inttypes.h>
--Apple-Mail=_58D2824B-D0C4-4E8D-8747-FE4523C65C78--
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51812 CVS commit: src/tests/lib/libc/gen
Date: Tue, 10 Jan 2017 10:32:46 -0500
Module Name: src
Committed By: christos
Date: Tue Jan 10 15:32:46 UTC 2017
Modified Files:
src/tests/lib/libc/gen: t_time.c
Log Message:
PR/51812: Ngie Cooper: According to ToG gettimeofday() needs <sys/time.h>
To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/tests/lib/libc/gen/t_time.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Tue, 10 Jan 2017 18:19:37 +0000
State-Changed-Why:
christos committed it, thanks
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2014
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.