NetBSD Problem Report #51813

From www@NetBSD.org  Tue Jan 10 09:47:17 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 5122D7A26E
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 10 Jan 2017 09:47:17 +0000 (UTC)
Message-Id: <20170110094716.2F0F57A2AF@mollari.NetBSD.org>
Date: Tue, 10 Jan 2017 09:47:16 +0000 (UTC)
From: yaneurabeya@gmail.com
Reply-To: yaneurabeya@gmail.com
To: gnats-bugs@NetBSD.org
Subject: [PATCH] tests/lib/libc/gen/t_ttyname.c: don't leak fd in :ttyname_err
X-Send-Pr-Version: www-1.0

>Number:         51813
>Category:       bin
>Synopsis:       [PATCH] tests/lib/libc/gen/t_ttyname.c: don't leak fd in :ttyname_err
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jan 10 09:50:00 +0000 2017
>Closed-Date:    Tue Jan 10 18:20:08 +0000 2017
>Last-Modified:  Tue Jan 10 18:20:08 +0000 2017
>Originator:     Ngie Cooper
>Release:        7.0.2
>Organization:
>Environment:
n/a
>Description:
This fixes a file descriptor leak pointed out by Coverity on FreeBSD
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/51813: [PATCH] tests/lib/libc/gen/t_ttyname.c: don't leak fd
 in :ttyname_err
Date: Tue, 10 Jan 2017 01:51:50 -0800

 --Apple-Mail=_2A392ED0-3788-4BC3-85C8-CE67E59AFFC6
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain;
 	charset=us-ascii

 Patch attached.

 --Apple-Mail=_2A392ED0-3788-4BC3-85C8-CE67E59AFFC6
 Content-Disposition: attachment;
 	filename=t_ttyname-dont-leak-fd.patch
 Content-Type: application/octet-stream;
 	x-unix-mode=0644;
 	name="t_ttyname-dont-leak-fd.patch"
 Content-Transfer-Encoding: 7bit

 Index: t_ttyname.c
 ===================================================================
 RCS file: /cvsroot/src/tests/lib/libc/gen/t_ttyname.c,v
 retrieving revision 1.3
 diff -p -u -r1.3 t_ttyname.c
 --- t_ttyname.c	1 May 2011 18:14:01 -0000	1.3
 +++ t_ttyname.c	10 Jan 2017 09:46:09 -0000
 @@ -78,6 +78,7 @@ ATF_TC_BODY(ttyname_err, tc)

  		ATF_REQUIRE(ttyname(fd) == NULL);
  		ATF_REQUIRE(errno == ENOTTY);
 +		(void)close(fd);
  	}
  }


 --Apple-Mail=_2A392ED0-3788-4BC3-85C8-CE67E59AFFC6--

From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51813 CVS commit: src/tests/lib/libc/gen
Date: Tue, 10 Jan 2017 10:33:40 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Tue Jan 10 15:33:40 UTC 2017

 Modified Files:
 	src/tests/lib/libc/gen: t_ttyname.c

 Log Message:
 PR/51813: Ngie Cooper: don't leak fd :ttyname_err


 To generate a diff of this commit:
 cvs rdiff -u -r1.3 -r1.4 src/tests/lib/libc/gen/t_ttyname.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Tue, 10 Jan 2017 18:20:08 +0000
State-Changed-Why:
christos committed it, thanks


>Unformatted:

Home	PR Database Search