NetBSD Problem Report #51827

From www@NetBSD.org  Wed Jan 11 15:02:05 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 879BE7A270
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 11 Jan 2017 15:02:05 +0000 (UTC)
Message-Id: <20170111150204.7318B7A2B2@mollari.NetBSD.org>
Date: Wed, 11 Jan 2017 15:02:04 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/arch/ofppc/pci/ofwpci.c:176: pointless local variable ?
X-Send-Pr-Version: www-1.0

>Number:         51827
>Category:       port-ofppc
>Synopsis:       src/sys/arch/ofppc/pci/ofwpci.c:176: pointless local variable ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-ofppc-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jan 11 15:05:00 +0000 2017
>Closed-Date:    Sun Jan 15 18:39:09 +0000 2017
>Last-Modified:  Sun Jan 15 18:39:09 +0000 2017
>Originator:     David Binderman
>Release:        cvs-20170111
>Organization:
>Environment:
>Description:
src/sys/arch/ofppc/pci/ofwpci.c:176]: (style) Variable 'isprim' is modified but its new value is never used.

$ fgrep isprim src/sys/arch/ofppc/pci/ofwpci.c
	int i, isprim = 0;
		isprim++;
$ 

Suggest delete local variable isprim.

>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51827 CVS commit: src/sys/arch/ofppc/pci
Date: Wed, 11 Jan 2017 13:19:29 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Wed Jan 11 18:19:29 UTC 2017

 Modified Files:
 	src/sys/arch/ofppc/pci: ofwpci.c

 Log Message:
 PR/51827: David Binderman: delete pointless local variable


 To generate a diff of this commit:
 cvs rdiff -u -r1.13 -r1.14 src/sys/arch/ofppc/pci/ofwpci.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: snj@NetBSD.org
State-Changed-When: Sun, 15 Jan 2017 18:39:09 +0000
State-Changed-Why:
christos committed the patch.  thanks!


>Unformatted:

Home	PR Database Search