NetBSD Problem Report #51843

From www@NetBSD.org  Fri Jan 13 04:55:11 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 4B2447A2B6
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 13 Jan 2017 04:55:11 +0000 (UTC)
Message-Id: <20170113045510.597C97A2BD@mollari.NetBSD.org>
Date: Fri, 13 Jan 2017 04:55:10 +0000 (UTC)
From: yaneurabeya@gmail.com
Reply-To: yaneurabeya@gmail.com
To: gnats-bugs@NetBSD.org
Subject: [PATCH] tests/lib/libc/sys/t_umask: don't leak file descriptor
X-Send-Pr-Version: www-1.0

>Number:         51843
>Category:       bin
>Synopsis:       [PATCH] tests/lib/libc/sys/t_umask: don't leak file descriptor
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jan 13 05:00:00 +0000 2017
>Closed-Date:    Sun Jan 15 19:33:06 +0000 2017
>Last-Modified:  Sun Jan 15 19:33:06 +0000 2017
>Originator:     Ngie Cooper
>Release:        7.0.2
>Organization:
>Environment:
n/a
>Description:
Don't leak file descriptor after open(2) call.
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/51843: [PATCH] tests/lib/libc/sys/t_umask: don't leak file
 descriptor
Date: Thu, 12 Jan 2017 21:05:15 -0800

 --Apple-Mail=_6B6D8386-14ED-4995-9A6D-15B40234652D
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain;
 	charset=us-ascii

 Patch attached.
 -Ngie

 --Apple-Mail=_6B6D8386-14ED-4995-9A6D-15B40234652D
 Content-Disposition: attachment;
 	filename=t_umask-dont-leak-fd.patch
 Content-Type: application/octet-stream;
 	x-unix-mode=0644;
 	name="t_umask-dont-leak-fd.patch"
 Content-Transfer-Encoding: 7bit

 Index: lib/libc/sys/t_umask.c
 ===================================================================
 RCS file: /cvsroot/src/tests/lib/libc/sys/t_umask.c,v
 retrieving revision 1.1
 diff -u -r1.1 t_umask.c
 --- lib/libc/sys/t_umask.c	7 Jul 2011 06:57:54 -0000	1.1
 +++ lib/libc/sys/t_umask.c	13 Jan 2017 05:04:56 -0000
 @@ -129,6 +129,7 @@
  		if (fd < 0)
  			continue;

 +		(void)close(fd);
  		(void)memset(&st, 0, sizeof(struct stat));

  		if (stat(path, &st) != 0) {

 --Apple-Mail=_6B6D8386-14ED-4995-9A6D-15B40234652D--

From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51843 CVS commit: src/tests/lib/libc/sys
Date: Fri, 13 Jan 2017 14:34:19 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Fri Jan 13 19:34:19 UTC 2017

 Modified Files:
 	src/tests/lib/libc/sys: t_umask.c

 Log Message:
 PR/51843: Ngie Cooper: don't leak file descriptor


 To generate a diff of this commit:
 cvs rdiff -u -r1.1 -r1.2 src/tests/lib/libc/sys/t_umask.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: snj@NetBSD.org
State-Changed-When: Sun, 15 Jan 2017 19:33:06 +0000
State-Changed-Why:
christos committed it. thanks!


>Unformatted:

Home	PR Database Search