NetBSD Problem Report #51847

From www@NetBSD.org  Fri Jan 13 05:39:20 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 140357A264
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 13 Jan 2017 05:39:20 +0000 (UTC)
Message-Id: <20170113053918.E9A187A2A1@mollari.NetBSD.org>
Date: Fri, 13 Jan 2017 05:39:18 +0000 (UTC)
From: yaneurabeya@gmail.com
Reply-To: yaneurabeya@gmail.com
To: gnats-bugs@NetBSD.org
Subject: [PATCH] tests/lib/libc/sys/t_sigqueue: various fixes
X-Send-Pr-Version: www-1.0

>Number:         51847
>Category:       bin
>Synopsis:       [PATCH] tests/lib/libc/sys/t_sigqueue: various fixes
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jan 13 05:40:00 +0000 2017
>Closed-Date:    Sun Jan 15 19:41:10 +0000 2017
>Last-Modified:  Sun Jan 15 19:41:10 +0000 2017
>Originator:     Ngie Cooper
>Release:        7.0.2
>Organization:
>Environment:
n/a
>Description:
- Dump signals in `handler`/`myhandler` for diagnosis purposes.
- Check result from sigaddset.
- Use `ATF_CHECK_MSG` instead of `ATF_REQUIRE_MSG` and print out all undelivered signals.
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/51847: [PATCH] tests/lib/libc/sys/t_sigqueue: various fixes
Date: Thu, 12 Jan 2017 22:38:54 -0800

 --Apple-Mail=_D8248F9F-CF32-4166-AB38-F3433B5B538D
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain;
 	charset=us-ascii

 Patch attached.
 -Ngie

 --Apple-Mail=_D8248F9F-CF32-4166-AB38-F3433B5B538D
 Content-Disposition: attachment;
 	filename=t_sigqueue-various-fixes.patch
 Content-Type: application/octet-stream;
 	x-unix-mode=0644;
 	name="t_sigqueue-various-fixes.patch"
 Content-Transfer-Encoding: 7bit

 Index: lib/libc/sys/t_sigqueue.c
 ===================================================================
 RCS file: /cvsroot/src/tests/lib/libc/sys/t_sigqueue.c,v
 retrieving revision 1.6
 diff -u -r1.6 t_sigqueue.c
 --- lib/libc/sys/t_sigqueue.c	4 Aug 2016 06:43:43 -0000	1.6
 +++ lib/libc/sys/t_sigqueue.c	13 Jan 2017 05:36:16 -0000
 @@ -32,10 +32,11 @@
  #include <sys/cdefs.h>
  __RCSID("$NetBSD: t_sigqueue.c,v 1.6 2016/08/04 06:43:43 christos Exp $");

 -
  #include <atf-c.h>
 +#include <err.h>
  #include <errno.h>
  #include <signal.h>
 +#include <stdio.h>
  #include <stdlib.h>
  #include <sched.h>
  #include <unistd.h>
 @@ -46,7 +47,7 @@
  static int value;

  static void
 -handler(int signo, siginfo_t *info, void *data)
 +handler(int signo __unused, siginfo_t *info, void *data __unused)
  {
  	value = info->si_value.sival_int;
  	kill(0, SIGINFO);
 @@ -107,9 +108,10 @@
  static int delivered[CNT];

  static void
 -myhandler(int signo, siginfo_t *info, void *context)
 +myhandler(int signo, siginfo_t *info, void *context __unused)
  {
  	delivered[count++] = signo;
 +	printf("Signal #%zu: signo: %d\n", (size_t)count, signo);
  }

  static int
 @@ -176,7 +178,8 @@
  	sigset_t mask, orig;
  	sigemptyset(&mask);
  	for (size_t i = 0; i < CNT; i++)
 -		sigaddset(&mask, signals[i]);
 +		if (sigaddset(&mask, signals[i]) == -1)
 +			warn("sigaddset");

  	ATF_REQUIRE(sigprocmask(SIG_BLOCK, &mask, &orig) != -1);

 @@ -185,13 +188,17 @@

  	ATF_REQUIRE(sigprocmask(SIG_UNBLOCK, &mask, &orig) != -1);
  	sleep(1);
 -	ATF_REQUIRE_MSG((size_t)count == ndelivered,
 +	ATF_CHECK_MSG((size_t)count == ndelivered,
  	    "count %zu != ndelivered %zu", (size_t)count, ndelivered);
  	for (size_t i = 0; i < ndelivered; i++)
  		ATF_REQUIRE_MSG(ordered[i] == delivered[i],
  		    "%zu: ordered %d != delivered %d",
  		    i, ordered[i], delivered[i]);

 +	if ((size_t)count > ndelivered)
 +		for (size_t i = ndelivered; i < (size_t)count; i++)
 +			printf("Undelivered signal #%zu: %d\n", i, ordered[i]);
 +
  	for (size_t i = 0; i < ndelivered; i++)
  		ATF_REQUIRE(sigaction(signals[i], &oact[i], NULL) != -1);
  }

 --Apple-Mail=_D8248F9F-CF32-4166-AB38-F3433B5B538D--

From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51847 CVS commit: src/tests/lib/libc/sys
Date: Fri, 13 Jan 2017 15:44:10 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Fri Jan 13 20:44:10 UTC 2017

 Modified Files:
 	src/tests/lib/libc/sys: t_sigqueue.c

 Log Message:
 PR/51847: Ngie Cooper: More error checks, add __unused


 To generate a diff of this commit:
 cvs rdiff -u -r1.6 -r1.7 src/tests/lib/libc/sys/t_sigqueue.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: snj@NetBSD.org
State-Changed-When: Sun, 15 Jan 2017 19:41:10 +0000
State-Changed-Why:
christos committed it. thanks!


>Unformatted:

Home	PR Database Search