NetBSD Problem Report #51850
From www@NetBSD.org Fri Jan 13 05:57:19 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
by mollari.NetBSD.org (Postfix) with ESMTPS id 299487A26A
for <gnats-bugs@gnats.NetBSD.org>; Fri, 13 Jan 2017 05:57:19 +0000 (UTC)
Message-Id: <20170113055718.262D47A2A1@mollari.NetBSD.org>
Date: Fri, 13 Jan 2017 05:57:18 +0000 (UTC)
From: yaneurabeya@gmail.com
Reply-To: yaneurabeya@gmail.com
To: gnats-bugs@NetBSD.org
Subject: [PATCH] tests/lib/libc/sys/t_connect: add sys/socket.h for socket(2) and don't leak fds
X-Send-Pr-Version: www-1.0
>Number: 51850
>Category: bin
>Synopsis: [PATCH] tests/lib/libc/sys/t_connect: add sys/socket.h for socket(2) and don't leak fds
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: bin-bug-people
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Fri Jan 13 06:00:00 +0000 2017
>Closed-Date: Sun Jan 15 19:43:33 +0000 2017
>Last-Modified: Sun Jan 15 19:43:33 +0000 2017
>Originator: Ngie Cooper
>Release: 7.0.2
>Organization:
>Environment:
n/a
>Description:
- Add sys/socket.h for socket(2).
- Don't leak opened file descriptors/sockets.
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: bin/51850: [PATCH] tests/lib/libc/sys/t_connect: add sys/socket.h
for socket(2) and don't leak fds
Date: Thu, 12 Jan 2017 22:05:48 -0800
--Apple-Mail=_D4E98839-D0B0-4CFB-9B8B-98A030D6DCA2
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
charset=us-ascii
Patch attached.
-Ngie
--Apple-Mail=_D4E98839-D0B0-4CFB-9B8B-98A030D6DCA2
Content-Disposition: attachment;
filename=t_connect-add-sys-socket-for-socket-and-close-fds.patch
Content-Type: application/octet-stream;
x-unix-mode=0644;
name="t_connect-add-sys-socket-for-socket-and-close-fds.patch"
Content-Transfer-Encoding: 7bit
Index: lib/libc/sys/t_connect.c
===================================================================
RCS file: /cvsroot/src/tests/lib/libc/sys/t_connect.c,v
retrieving revision 1.2
diff -u -r1.2 t_connect.c
--- lib/libc/sys/t_connect.c 5 Apr 2015 23:17:41 -0000 1.2
+++ lib/libc/sys/t_connect.c 13 Jan 2017 05:55:20 -0000
@@ -26,6 +26,7 @@
* IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+#include <sys/socket.h>
#include <err.h>
#include <errno.h>
#include <string.h>
@@ -52,6 +53,9 @@
slist = socket(AF_INET, SOCK_STREAM, 0);
sd = socket(AF_INET, SOCK_STREAM, 0);
+ ATF_REQUIRE(sd > 0);
+ ATF_REQUIRE(slist > 0);
+
/* bind listening socket */
memset(&sinlist, 0, sizeof(sinlist));
sinlist.sin_family = AF_INET;
@@ -88,6 +92,7 @@
ATF_REQUIRE(ntohs(sin.sin_port) <= IPPORT_RESERVEDMAX);
close(sd);
+ close(slist);
}
ATF_TC(connect_foreign_family);
--Apple-Mail=_D4E98839-D0B0-4CFB-9B8B-98A030D6DCA2--
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51850 CVS commit: src/tests/lib/libc/sys
Date: Fri, 13 Jan 2017 15:09:48 -0500
Module Name: src
Committed By: christos
Date: Fri Jan 13 20:09:48 UTC 2017
Modified Files:
src/tests/lib/libc/sys: t_connect.c
Log Message:
PR/51850: Ngie Cooper: add sys/socket.h for socket(2) and don't leak fds
To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/tests/lib/libc/sys/t_connect.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->closed
State-Changed-By: snj@NetBSD.org
State-Changed-When: Sun, 15 Jan 2017 19:43:33 +0000
State-Changed-Why:
christos committed it. thanks!
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2014
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.