NetBSD Problem Report #51854

From www@NetBSD.org  Fri Jan 13 06:11:59 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 926017A1AF
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 13 Jan 2017 06:11:59 +0000 (UTC)
Message-Id: <20170113061157.8A0F97A2BF@mollari.NetBSD.org>
Date: Fri, 13 Jan 2017 06:11:57 +0000 (UTC)
From: yaneurabeya@gmail.com
Reply-To: yaneurabeya@gmail.com
To: gnats-bugs@NetBSD.org
Subject: [PATCH] tests/lib/libc/sys/t_listen: add sys/socket.h include and check result from socket(2)
X-Send-Pr-Version: www-1.0

>Number:         51854
>Category:       bin
>Synopsis:       [PATCH] tests/lib/libc/sys/t_listen: add sys/socket.h include and check result from socket(2)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jan 13 06:15:00 +0000 2017
>Closed-Date:    Sun Jan 15 19:52:39 +0000 2017
>Last-Modified:  Sun Jan 15 19:52:39 +0000 2017
>Originator:     Ngie Cooper
>Release:        7.0.2
>Organization:
>Environment:
n/a
>Description:
- Add sys/socket.h for socket(2).
- Check result from socket(2) with ATF_REQUIRE_MSG.
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/51854: [PATCH] tests/lib/libc/sys/t_listen: add sys/socket.h
 include and check result from socket(2)
Date: Thu, 12 Jan 2017 22:27:18 -0800

 --Apple-Mail=_E9D44E0F-46BF-4DAE-B94D-FFC2A4395FB3
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain;
 	charset=us-ascii

 Patch attached.
 -Ngie

 --Apple-Mail=_E9D44E0F-46BF-4DAE-B94D-FFC2A4395FB3
 Content-Disposition: attachment;
 	filename=t_listen-add-sys-socket-and-check-result-from-socket.patch
 Content-Type: application/octet-stream;
 	x-unix-mode=0644;
 	name="t_listen-add-sys-socket-and-check-result-from-socket.patch"
 Content-Transfer-Encoding: 7bit

 Index: lib/libc/sys/t_listen.c
 ===================================================================
 RCS file: /cvsroot/src/tests/lib/libc/sys/t_listen.c,v
 retrieving revision 1.4
 diff -u -r1.4 t_listen.c
 --- lib/libc/sys/t_listen.c	18 Mar 2012 07:00:52 -0000	1.4
 +++ lib/libc/sys/t_listen.c	13 Jan 2017 06:12:22 -0000
 @@ -26,6 +26,7 @@
   * IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
   */

 +#include <sys/socket.h>
  #include <atf-c.h>
  #include <err.h>
  #include <errno.h>
 @@ -106,6 +107,7 @@
  	int sd, val;

  	sd = socket(AF_INET, SOCK_STREAM, 0);
 +	ATF_REQUIRE_MSG(sd != -1, "socket failed: %s", strerror(errno));

  	val = IP_PORTRANGE_LOW;
  	if (setsockopt(sd, IPPROTO_IP, IP_PORTRANGE, &val,

 --Apple-Mail=_E9D44E0F-46BF-4DAE-B94D-FFC2A4395FB3--

From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51854 CVS commit: src/tests/lib/libc/sys
Date: Fri, 13 Jan 2017 15:41:50 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Fri Jan 13 20:41:50 UTC 2017

 Modified Files:
 	src/tests/lib/libc/sys: t_listen.c

 Log Message:
 PR/51854: Ngie Cooper: sys/socket.h include and check result from socket(2)


 To generate a diff of this commit:
 cvs rdiff -u -r1.4 -r1.5 src/tests/lib/libc/sys/t_listen.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: snj@NetBSD.org
State-Changed-When: Sun, 15 Jan 2017 19:52:39 +0000
State-Changed-Why:
christos committed it. thanks!


>Unformatted:

Home	PR Database Search