NetBSD Problem Report #51860

From www@NetBSD.org  Fri Jan 13 07:01:29 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id EB6AE7A264
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 13 Jan 2017 07:01:29 +0000 (UTC)
Message-Id: <20170113070129.1BE267A280@mollari.NetBSD.org>
Date: Fri, 13 Jan 2017 07:01:29 +0000 (UTC)
From: yaneurabeya@gmail.com
Reply-To: yaneurabeya@gmail.com
To: gnats-bugs@NetBSD.org
Subject: [PATCH] tests/lib/libc/sys/t_revoke: don't leak fd
X-Send-Pr-Version: www-1.0

>Number:         51860
>Category:       bin
>Synopsis:       [PATCH] tests/lib/libc/sys/t_revoke: don't leak fd
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jan 13 07:05:00 +0000 2017
>Closed-Date:    Sun Jan 15 19:59:05 +0000 2017
>Last-Modified:  Sun Jan 15 19:59:05 +0000 2017
>Originator:     Ngie Cooper
>Release:        7.0.2
>Organization:
>Environment:
n/a
>Description:
Don't leak fd.
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/51860: [PATCH] tests/lib/libc/sys/t_revoke: don't leak fd
Date: Thu, 12 Jan 2017 23:06:49 -0800

 --Apple-Mail=_AA9106D2-F495-41AE-A976-276A7DD9F421
 Content-Disposition: attachment;
 	filename=t_revoke-dont-leak-fd.patch
 Content-Type: application/octet-stream;
 	x-unix-mode=0644;
 	name="t_revoke-dont-leak-fd.patch"
 Content-Transfer-Encoding: 7bit

 Index: lib/libc/sys/t_revoke.c
 ===================================================================
 RCS file: /cvsroot/src/tests/lib/libc/sys/t_revoke.c,v
 retrieving revision 1.1
 diff -u -r1.1 t_revoke.c
 --- lib/libc/sys/t_revoke.c	7 Jul 2011 06:57:54 -0000	1.1
 +++ lib/libc/sys/t_revoke.c	13 Jan 2017 06:47:33 -0000
 @@ -167,6 +167,7 @@
  	if (WIFEXITED(sta) == 0 || WEXITSTATUS(sta) != EXIT_SUCCESS)
  		atf_tc_fail("revoke(2) did not obey permissions");

 +	(void)close(fd);
  	ATF_REQUIRE(unlink(path) == 0);
  }


 --Apple-Mail=_AA9106D2-F495-41AE-A976-276A7DD9F421--

From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51860 CVS commit: src/tests/lib/libc/sys
Date: Fri, 13 Jan 2017 16:15:57 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Fri Jan 13 21:15:57 UTC 2017

 Modified Files:
 	src/tests/lib/libc/sys: t_revoke.c

 Log Message:
 PR/51860: Ngie Cooper: don't leak fd


 To generate a diff of this commit:
 cvs rdiff -u -r1.1 -r1.2 src/tests/lib/libc/sys/t_revoke.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: snj@NetBSD.org
State-Changed-When: Sun, 15 Jan 2017 19:59:05 +0000
State-Changed-Why:
christos committed it. thanks!


>Unformatted:

Home	PR Database Search